Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Bug ID: 904329 Summary: Review Request: perl-Data-Validate-Domain - Domain validation methods Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: long@rule.lv
Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Data-Validate-Domain.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Data-Validate-Domain-0.10-1.fc16.src... Description: This module collects domain validation routines to make input validation, and untainting easier and more readable.
All functions return an untainted value if the test passes, and undef if it fails. This means that you should always check for a defined status explicitly. Don't assume the return will be true. (e.g. is_username('0'))
The value to test is always the first (and often only) argument.
Fedora Account System Username: normunds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Normunds long@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |903826 | |(perl-Net-Domain-TLD)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Normunds long@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|903826 | |(perl-Net-Domain-TLD) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Normunds long@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Depends On| |903826 | |(perl-Net-Domain-TLD)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #1 from Normunds long@rule.lv --- All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.
Need sponsor.
bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec
Thanks.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Petr Ĺ abata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |psabata@redhat.com Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #2 from Petr Ĺ abata psabata@redhat.com --- Removing FE-NEEDSPONSOR.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Bug 904329 depends on bug 903826, which changed state.
Bug 903826 Summary: Review Request: perl-Net-Domain-TLD - Work with TLD names https://bugzilla.redhat.com/show_bug.cgi?id=903826
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #3 from Normunds fedorapkg@rule.lv --- Specfiles and packages updated according to lessons learned from the following reviewed bugs:
Bug 903824 bug 903829 bug 904328
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #4 from Petr Pisar ppisar@redhat.com --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: be17fbc945c8ab3faac8870bed99704c023919863e583c56b43e9df05ef7a39a). Ok. Summary verified from lib/Data/Validate/Domain.pm. Ok. Description verified from lib/Data/Validate/Domain.pm. Ok. License verified from lib/Data/Validate/Domain.pm, and README. Ok. No XS code, noarch BuildArch is Ok.
TODO: Qualify `perl(Net::Domain::TLD)' build- and run-requirement with `>= 1.62' constraint (META.yml:12).
Test::Pod::Coverage is optional. Ok. Test::Pod is optional. Ok.
All tests pass. Ok.
$ rpmlint perl-Data-Validate-Domain.spec ../SRPMS/perl-Data-Validate-Domain-0.10-1.fc19.src.rpm ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm perl-Data-Validate-Domain.src: W: spelling-error %description -l en_US untainting -> tainting, unstinting, taunting perl-Data-Validate-Domain.src: W: spelling-error %description -l en_US undef -> unfed, under, funded perl-Data-Validate-Domain.src: W: spelling-error %description -l en_US username -> user name, user-name, surname perl-Data-Validate-Domain.noarch: W: spelling-error %description -l en_US untainting -> tainting, unstinting, taunting perl-Data-Validate-Domain.noarch: W: spelling-error %description -l en_US undef -> unfed, under, funded perl-Data-Validate-Domain.noarch: W: spelling-error %description -l en_US username -> user name, user-name, surname 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Feb 5 17:20 /usr/share/doc/perl-Data-Validate-Domain-0.10 -rw-r--r-- 1 root root 2231 Dec 29 2010 /usr/share/doc/perl-Data-Validate-Domain-0.10/Changes -rw-r--r-- 1 root root 9026 May 16 2007 /usr/share/doc/perl-Data-Validate-Domain-0.10/README -rw-r--r-- 1 root root 4734 Feb 5 17:20 /usr/share/man/man3/Data::Validate::Domain.3pm.gz drwxr-xr-x 2 root root 0 Feb 5 17:20 /usr/share/perl5/vendor_perl/Data drwxr-xr-x 2 root root 0 Feb 5 17:20 /usr/share/perl5/vendor_perl/Data/Validate -rw-r--r-- 1 root root 11838 Dec 29 2010 /usr/share/perl5/vendor_perl/Data/Validate/Domain.pm File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(Net::Domain::TLD) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Data::Validate::Domain) = 0.10 1 perl-Data-Validate-Domain = 0.10-1.fc19 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Data-Validate-Domain-0.10-1.fc19.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4930421). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #5 from Normunds fedorapkg@rule.lv --- Thank you for your review.
TODO - requirement with version fixed; Changed e-mail as requested in another review.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Normunds fedorapkg@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #6 from Normunds fedorapkg@rule.lv --- New Package SCM Request ======================= Package Name: perl-Data-Validate-Domain Short Description: Domain validation methods Perl module Owners: normunds psabata Branches: f16 f17 f18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-Domain-0.10-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Data-Validate-Domain-0.10-1.fc1...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-Domain-0.10-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Data-Validate-Domain-0.10-1.fc1...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-Domain-0.10-1.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-Domain-0.10-1.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=904329
Petr Ĺ abata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |perl-Data-Validate-Domain-0 | |.10-1.fc18 Resolution|--- |CURRENTRELEASE Last Closed| |2014-04-03 09:46:28
package-review@lists.fedoraproject.org