[Bug 2297189] New: Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Bug ID: 2297189
           Summary: Review Request: rust-open-enum - Attribute for
                    generating "open" fieldless enums that accept any
                    integer value
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://osteffen.fedorapeople.org/packages/rust-open-enum/rust-open-enum.spe...
SRPM URL:
https://osteffen.fedorapeople.org/packages/rust-open-enum/rust-open-enum-0.5...
Description: Attribute for generating "open" fieldless enums that accept any
integer value
Fedora Account System Username: osteffen

This crate is packaged directly from crates.io.

It depends on rust-open-enum-derive
(https://bugzilla.redhat.com/show_bug.cgi?id=2297188)

This is part of the effort to add the Coconut-SVSM paravisor to Fedora.
It would enables Fedora virtualization hosts to launch confidential
virtual machines using AMD's SEV-SNP technology.
See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/op
                   |                            |en-enum

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7723523
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189
Bug 2297189 depends on bug 2297188, which changed state.

Bug 2297188 Summary: Review Request: rust-open-enum-derive - Attribute for generating "open" fieldless enums that accept any integer value
https://bugzilla.redhat.com/show_bug.cgi?id=2297188

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

--- Comment #2 from Oliver Steffen  ---
Spec URL:
https://osteffen.fedorapeople.org/packages/rust-open-enum/rust-open-enum.spe...
SRPM URL:
https://osteffen.fedorapeople.org/packages/rust-open-enum/rust-open-enum-0.5...
Description: Attribute for generating "open" fieldless enums that accept any
integer value
Fedora Account System Username: osteffen

This crate is packaged directly from crates.io.

It depends on rust-open-enum-derive
(https://bugzilla.redhat.com/show_bug.cgi?id=2297188)

This is part of the effort to add the Coconut-SVSM paravisor to Fedora.
It would enables Fedora virtualization hosts to launch confidential
virtual machines using AMD's SEV-SNP technology.
See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP

Updated the spec file and srpm, dependency rust-open-enum-derive was added to
rawhide.

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #3 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8867410
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #4 from Fabio Valentini  ---
Taking this review.

There's some things that need to be addressed, but they're inter-related.

You left some FIXME items generated by rust2rpm in the spec file without ...
fixing them:
> # FIXME: paste output of %%cargo_license_summary here
> License:        # FIXME

Incidentally, it looks like that "test_lints" executable only serves some test
purpose,
and probably shouldn't even be shipped as a package in Fedora.

You can prevent generation of this subpackage with a rust2rpm.toml config file
like this:

```
[package]
cargo-install-bin = false
```

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Oliver Steffen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|AutomationTriaged           |

--- Comment #5 from Oliver Steffen  ---
Sorry about that. Fixed it.

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Fabio Valentini  ---
No need to be sorry - sometimes this is too easy to miss.
It might be good to have rust2rpm print a warning in this case, that the
generated spec file has FIXME items in it that need to be addressed.

===

Package looks good to me now. I see that you're also trimming the Summary to be
within expected length limits, you can also make this permanent with a
rust2rpm.toml setting:

```
[package]
summary = "Attribute for generating "open" fieldless enums that accept any
integer value"
cargo-install-bin = false
```

Don't forget to also commit the rust2rpm.toml file you have to dist-git on
import, it's only useful if kept around :)

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #7 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-open-enum

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #8 from Fedora Update System  ---
FEDORA-2025-b8a9b073dd (rust-open-enum-0.5.2-1.fc43) has been submitted as an
update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b8a9b073dd

[Bug 2297189] Review Request: rust-open-enum - Attribute for generating "open" fieldless enums that accept any integer value

https://bugzilla.redhat.com/show_bug.cgi?id=2297189

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2025-04-16 09:33:58

--- Comment #9 from Fedora Update System  ---
FEDORA-2025-b8a9b073dd (rust-open-enum-0.5.2-1.fc43) has been pushed to the
Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.