https://bugzilla.redhat.com/show_bug.cgi?id=1558976
Bug ID: 1558976 Summary: Review Request: mycrypto - Client-side tool for interacting with the Ethereum network Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: rene.purcell@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora... Description: This is the second package I submit, It's pretty much an upstream fork from the other package I've made(etherwallet). There's no binary, no real dependency other than a browser. The package install the files in /usr/share/mycrypto/ and copy a .desktop file which open /usr/share/mycrypto/index.html with xdg-open. Fedora Account System Username: arsenick
https://bugzilla.redhat.com/show_bug.cgi?id=1558976
Rene Jr Purcell rene.purcell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1558976
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Changelog is empty
- There's a license file https://github.com/MyCryptoHQ/mycrypto.com/blob/master/LICENSE that you must install with %license in %files
https://bugzilla.redhat.com/show_bug.cgi?id=1558976
--- Comment #2 from Rene Jr Purcell rene.purcell@gmail.com --- Thanks, changelog has been added, same for the license file.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora...
I wasn't able to find the LICENSE file in the release zip and I've found I'm not using the source tarball. I'm using the .zip release which seems to be a version where gulp has already been run. So I've read the guideline regarding binary or library and I'm not sure if this fit as a binary, does it ? Should I use the source and run gulp in my specfile ?
https://bugzilla.redhat.com/show_bug.cgi?id=1558976
--- Comment #3 from Rene Jr Purcell rene.purcell@gmail.com --- Ok, I guess this answer my question: https://fedoraproject.org/wiki/Packaging:JavaScript#Compilation.2FMinificati...
I'll create a new version of the spec using the source tarball an use gulp in the %install section. If it's not necessary feel free to let me know, oterwise I'm working on it.
Thanks for your help!
https://bugzilla.redhat.com/show_bug.cgi?id=1558976
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Use the source and use Gulp in build, then install the whole.
Bump to the latest revision.
package-review@lists.fedoraproject.org