[Bug 2076657] New: Review Request: rust-integer-encoding - Varint+zigzag and fixedint integer encoding/decoding
9:50 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
Bug ID: 2076657
Summary: Review Request: rust-integer-encoding - Varint+zigzag
and fixedint integer encoding/decoding
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: carmelo.sarta.main(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://raw.githubusercontent.com/Laiot/rust-integer-encoding-rpm/master/...
SRPM URL:
https://github.com/Laiot/rust-integer-encoding-rpm/raw/master/rust-intege...
Description: Varint+zigzag and fixedint integer encoding/decoding
Fedora Account System Username: laiot
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
9:37 a.m.
New subject: [Bug 2076657] Review Request: rust-integer-encoding - Varint+zigzag
and fixedint integer encoding/decoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |decathorpe(a)gmail.com
Status|NEW |POST
Doc Type|--- |If docs needed, set a value
Flags| |fedora-review+
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
--- Comment #1 from Fabio Valentini <decathorpe(a)gmail.com> ---
Two small things:
- trim the Summary in the spec file the same way you did for the bug title
(i.e. remove the URL in parentheses)
- exclude the "coverage.sh" script from being included in packaged files (i.e.
by patching Cargo.toml to add "exclude = ["/coverage.sh"]")
Other than that, I'm only curious what you're packaging this crate for :)
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org:
project: $crate
homepage: https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter: alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- track package in koschei for all built branches
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
10:20 a.m.
New subject: [Bug 2076657] Review Request: rust-integer-encoding - Varint+zigzag
and fixedint integer encoding/decoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #2 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-integer-encoding
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
3:33 p.m.
New subject: [Bug 2076657] Review Request: rust-integer-encoding - Varint+zigzag
and fixedint integer encoding/decoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #3 from Fabio Valentini <decathorpe(a)gmail.com> ---
Hey, looks like you missed one of my comments:
- exclude the "coverage.sh" script from being included in packaged files (i.e.
by patching Cargo.toml to add "exclude = ["/coverage.sh"]")
And the build failed due to what looks like endianness-related problems (s390x
is our only big-endian architecture).
You might want to report this with the upstream project, otherwise the crate
will most probably not work correctly on s390x.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
5:14 p.m.
New subject: [Bug 2076657] Review Request: rust-integer-encoding - Varint+zigzag
and fixedint integer encoding/decoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #4 from Carmelo Sarta <carmelo.sarta.main(a)gmail.com> ---
Sorry about that, I just pushed the patched .spec but apparently you're right,
the build fails. I will report this to the upstream project.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
7:01 a.m.
New subject: [Bug 2076657] Review Request: rust-integer-encoding - Varint+zigzag
and fixedint integer encoding/decoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com> ---
Looks like this is the issue you reported?
https://github.com/dermesser/integer-encoding-rs/issues/24
Please follow up there.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
8:21 a.m.
New subject: [Bug 2076657] Review Request: rust-integer-encoding - Varint+zigzag
and fixedint integer encoding/decoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(carmelo.sarta.mai
| |n(a)gmail.com)
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
588
days inactive
788
days old
package-review@lists.fedoraproject.org
6 comments
1 participants
participants (1)
-
bugzilla＠redhat.com