[Bug 2028899] New: Review Request: rust-tree-sitter-loader - Locates, builds, and loads tree-sitter grammars at runtime
https://bugzilla.redhat.com/show_bug.cgi?id=2028899
Bug ID: 2028899 Summary: Review Request: rust-tree-sitter-loader - Locates, builds, and loads tree-sitter grammars at runtime Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: alebastr89@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://alebastr.fedorapeople.org/review/tree-sitter-cli/rust-tree-sitter-lo... SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/rust-tree-sitter... Copr build: https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/build/... Description: Locates, builds, and loads tree-sitter grammars at runtime
Fedora Account System Username: alebastr Note: generated with `rust2rpm -a`; added upstream license file as required by the MIT license
https://bugzilla.redhat.com/show_bug.cgi?id=2028899
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2028900
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2028900 [Bug 2028900] Review Request: rust-tree-sitter-cli - CLI tool for developing, testing, and using Tree-sitter parsers
https://bugzilla.redhat.com/show_bug.cgi?id=2028899
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://alebastr.fedorapeople.org/review/tree-sitter-cli/rust-tree-sitter-lo... SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/rust-tree-sitter... Copr build: https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/build/... Description: Locates, builds, and loads tree-sitter grammars at runtime
Fedora Account System Username: alebastr Note: generated with `rust2rpm -a`; added upstream license file as required by the MIT license
https://bugzilla.redhat.com/show_bug.cgi?id=2028899
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- You seem to have updated the spec file or SRPM, but not both, please reconcile those changes before importing the package:
Diff spec file in url and in SRPM --------------------------------- --- /home/deca/Downloads/2028899-rust-tree-sitter-loader/srpm/rust-tree-sitter-loader.spec 2022-03-09 15:59:42.961643210 +0100 +++ /home/deca/Downloads/2028899-rust-tree-sitter-loader/srpm-unpacked/rust-tree-sitter-loader.spec 2022-02-23 07:55:08.000000000 +0100 @@ -14,5 +14,5 @@ URL: https://crates.io/crates/tree-sitter-loader Source: %{crates_source} -# Upstream license file - tree-sitter/tree-sitter#1520 +# Upstream license file Source1: https://github.com/tree-sitter/tree-sitter/raw/v%%7Bversion%7D/LICENSE#/LICE...
Other than that, looks good to me.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest compatible version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2028899
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-sitter-loader
https://bugzilla.redhat.com/show_bug.cgi?id=2028899 Bug 2028899 depends on bug 2028895, which changed state.
Bug 2028895 Summary: Review Request: rust-tree-sitter - Rust bindings to the Tree-sitter parsing library https://bugzilla.redhat.com/show_bug.cgi?id=2028895
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2028899 Bug 2028899 depends on bug 2028896, which changed state.
Bug 2028896 Summary: Review Request: rust-tree-sitter-highlight - Library for performing syntax highlighting with Tree-sitter https://bugzilla.redhat.com/show_bug.cgi?id=2028896
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2028899 Bug 2028899 depends on bug 2028897, which changed state.
Bug 2028897 Summary: Review Request: rust-tree-sitter-tags - Library for extracting tag information https://bugzilla.redhat.com/show_bug.cgi?id=2028897
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2028899
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Fixed In Version| |rust-tree-sitter-loader-0.2 | |0.0-1.fc37 Status|POST |CLOSED Last Closed| |2022-03-10 05:43:49
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com