[Bug 988648] New: Review Request: libunity - Unity instrumenting and integration library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648

Bug ID: 988648
           Summary: Review Request: libunity - Unity instrumenting and
                    integration library
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Spec URL: http://cicku.me/libunity.soec
SRPM URL: http://cicku.me/libunity-6.12.0-1.fc20.src.rpm
Description: LibUnity is library for instrumenting- and integrating with all
aspects of the
Unity shell (lp:unity). This is not a library used in the implementation
of the Unity shell itself (lp:unity does not link against it), but a library to
be consumed by clients that wants to do deep integration with the Unity shell.
Fedora Account System Username: cicku

[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |962029

[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648

--- Comment #1 from Michael Schwendt  ---
Spec URL: http://cicku.me/libunity.spec
SRPM URL: http://cicku.me/libunity-6.12.0-1.fc20.src.rpm

Just a brief look at the spec:
> Summary:        Unity instrumenting and integration library

Somewhat pedantic, but I only took a look at this ticket because I wanted to
know whether "Unity" here is ambiguous. More clear would be

Summary: Instrumenting and integration library for the Unity shell

IMO.
> %package        devel
> Requires:       %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> %package -n     python-%{name}
> Summary:        Python bindings for libunity

Note that the "Requiring Base Package" guidelines are not specific to -devel
packages.
> %files
> %{_libdir}/girepository-1.0/*.typelib
> %{_libdir}/libunity.so.*
> %{_libdir}/libunity/libunity-protocol-private.so.*

Which package owns %{_libdir}/libunity/?
> %files devel
> %{_libdir}/libunity/libunity-protocol-private.so

Please verify how/when this lib is used. Judging based on its path it seems to
be a private plugin/extension lib, which is dlopen()'ed at runtime. Verify
whether libunity loads it via the non-versioned *.so name or the versioned one.
In that case, this file may need to be moved into the correct package.

[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1121005

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1121005
[Bug 1121005] dee-1.2.7 is available

[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648
Bug 988648 depends on bug 1121005, which changed state.

Bug 1121005 Summary: dee-1.2.7 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1121005

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648

gil cattaneo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |201449 (FE-DEADREVIEW)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.

[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648

Rex Dieter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
                 CC|                            |[e-mail]
         Resolution|---                         |NOTABUG
        Last Closed|                            |2016-01-11 15:24:32