[Bug 728979] New: Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

https://bugzilla.redhat.com/show_bug.cgi?id=728979

Summary: Review Request: perl-Tie-Simple - Variable ties made
                    easier: much, much, much easier
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---

SRPM:
http://mmaslano.fedorapeople.org/review/perl-Tie-Simple-1.03-1.fc17.src.rpm
SPEC: http://mmaslano.fedorapeople.org/review/perl-Tie-Simple.spec
Description:
This module adds the ability to quickly create new types of tie objects
without creating a complete class. It does so in such a way as to try and
make the programmers life easier when it comes to single-use ties that I
find myself wanting to use from time-to-time.

[Bug 728979] Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728979

Petr Sabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 728979] Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728979

--- Comment #1 from Petr Sabata  2011-08-08 11:06:10 EDT ---
Package: perl-Tie-Simple
Version: 1.03
Release: 1.fc17
Sources: Tie-Simple-1.03.tar.gz
Patches: 
----------

MUST items:
[  OK  ] Package does NOT include pre-built binaries or libraries
[  OK  ] Spec file is legible and written in American english
[  OK  ] Package successfully builds on at least one supported primary
architecture
[  --  ] All ExcludeArch tags valid, referencing proper bug reports
[  OK  ] Package obeys FHS (with _libexecdir and /srv exceptions)
[  OK  ] No errors reported by rpmlint
[  OK  ] Changelog present and properly formatted
[  OK  ] Package does NOT include Packager, Vendor, Copyright or PreReq tags
[  OK  ] Source tags are working URLs and sources match upstream or justified
otherwise
[  OK  ] Requires correct or justified otherwise
[ FAIL ] BuildRequires correct or justified otherwise
[  OK  ] All file names are in proper UTF-8 encoding
[  OK  ] All plain text failes are in proper UTF-8 encoding
[  --  ] Large documentation files are located in doc subpackage
[  OK  ] All documentation prefixed with %doc
[  OK  ] Documentation is NOT executable
[  OK  ] No files in %doc are needed at run-time
[  --  ] Compiler flags honor Fedora defaults or are justified
[  --  ] Package generates useful debuginfo packages
[  --  ] Header files are placed in devel subpackage
[  --  ] Unversioned shared libraries are placed in devel subpackage
[  --  ] Pkgconfig files are placed in devel subpackage
[  --  ] Full-versioned Requires of the base package in subpackages
[  --  ] Package calls ldconfig in post and postun sections for all
subpackages, if applicable
[  --  ] Static libraries are provided by static subpackage
[  OK  ] Package contains no static executables unless approved by FESCo
[  OK  ] Package does NOT bundle any system libraries
[  --  ] RPath not used for anything besides internal libraries
[  --  ] All config files are marked noreplace or justified otherwise
[  OK  ] No config files are located under /usr
[  --  ] Package contains working systemd unit files and requires systemd-units
[  --  ] All systemd unit files are named according to the Guidelines
[  --  ] Package contains a SystemV-compatible initscript only as an optional
addition to systemd unit files
[  --  ] If package contains an initscript, it's placed in sysvinit subpackage
[  --  ] A GUI application installs a proper desktop file
[  --  ] All desktop files are installed by desktop-file-install or justified
otherwise
[  OK  ] Package consistently uses macros
[  --  ] makeinstall macro is used only if make install DESTDIR=%{buildroot}
does NOT work
[  --  ] Macros in Summary and description are expandable at build-time
[  --  ] globals used in place of defines
[  --  ] Locales handled correctly -- package requires gettext and uses
find_lang, if applicable
[  --  ] Scriptlets are sane
[  OK  ] Package is not relocatable unless justified
[  OK  ] Package contains only acceptable code or content
[  OK  ] Package owns all the files and directories it creates, installs and/or
uses unless those are already owned by another package
[  OK  ] files sections do NOT contain duplicate files except for licenses
[  OK  ] Package does NOT cause any conflicts
[  OK  ] Package does NOT contain kernel modules
[  OK  ] Package does NOT bundle fonts or other general purpose data
[  OK  ] Final Requires and Provides are sane

SHOULD items:
[  OK  ] The Summary does NOT end with a period
[ NOTE ] Package does NOT include BuildRoot tag, clean section or buildroot
removal in install section
[  OK  ] Package should preserve files timestamps
[  OK  ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio,
diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info,
make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip,
util-linux-ng, which or xz
[  OK  ] Description does NOT consist of lines longer than 80 characters
[  OK  ] Package uses parallel make
[  --  ] In case of a web application, package installs date into /usr/share
instead of /var/www
[  --  ] All patches have a comment or an upstream bug link
[  --  ] Package installs manpages for all executables
[  OK  ] Package contains check section and all tests pass
[  ??  ] Package works as expected

NOTES:
------
1. The package fails to build in mock/koji due to missing BRs. Add the
following:

perl(base)
perl(Test::More)
perl(Tie::Array)
perl(Tie::Handle)
perl(Tie::Hash)
perl(Tie::Scalar)

2. The buildroot removal can be removed from the %install section.

--

Not approved.

[Bug 728979] Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728979

--- Comment #2 from Marcela Mašláňová  2011-08-08 11:12:07 EDT ---
Fixed, thank you.
http://mmaslano.fedorapeople.org/review/perl-Tie-Simple-1.03-1.fc17.src.rpm

[Bug 728979] Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728979

Petr Sabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Petr Sabata  2011-08-08 11:13:59 EDT ---
Okay, it looks good now.

[Bug 728979] Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728979

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Marcela Mašláňová  2011-08-08 11:34:07 EDT ---
New Package SCM Request
=======================
Package Name: perl-Tie-Simple
Short Description: Variable ties made easier: much, much, much easier
Owners: mmaslano psabata ppisar
Branches: F-16
InitialCC: perl-sig

[Bug 728979] Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728979

--- Comment #5 from Jon Ciesla  2011-08-08 11:36:09 EDT ---
Git done (by process-git-requests).

[Bug 728979] Review Request: perl-Tie-Simple - Variable ties made easier: much, much, much easier

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=728979

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-08-09 07:49:03