[Bug 1869128] New: Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

Bug ID: 1869128
           Summary: Review Request: ilopona - toki pona dictionary
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://appadeia.fedorapeople.org/packaging/ilopona/ilopona.spec
SRPM URL:
https://appadeia.fedorapeople.org/packaging/ilopona/ilopona-1.0.0-1.fc32.src...
Description: ilo pona is a simple dictionary application for toki pona.
Fedora Account System Username: appadeia

[Bug 1869128] Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

Bob Hepple  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

[Bug 1869128] Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

Bob Hepple  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 1869128] Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

--- Comment #1 from Bob Hepple  ---
*** The online help->License indicates "The writing in the background of the
word definitions is licensed under CC BY-NC-SA 4.0." I think this should be
mentioned in License: and %license

*** Please remove '.' from the end of the Summary: line

*** Please use desktop-file-install:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.

eg something like:
BuildRequires: desktop-file-utils
...
desktop-file-install \
        --dir %{buildroot}%{_datadir}/applications              \
        --remove-category Application                           \
        %{name}.desktop

... --add-category/--remove-category as appropriate for ilopona - see 'man
desktop-file-install'

*** Please validate appdata.xml file
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData: The AppData
files MUST correctly validate using appstream-util validate-relax
eg. something like this:

BuildRequires: libappstream-glib
...
%check (or %install)
appstream-util validate-relax --nonet %{_metainfodir}/*.appdata.xml

... note the use of %{_metainfodir} (which can also be used in %files)

*** Minor bugaboos: optional:

$ rpmlint /home/bhepple/rpmbuild/RPMS/x86_64/ilopona-1.0.0-1.fc31.x86_64.rpm
ilopona.x86_64: W: description-shorter-than-summary
ilopona.x86_64: W: no-documentation
ilopona.x86_64: W: no-manual-page-for-binary com.github.Appadeia.ilopona

[Bug 1869128] Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

--- Comment #2 from Bob Hepple  ---
I would suggest 'Education' as an additional category in .desktop

BTW - it works fine on Fedora-31.

[Bug 1869128] Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Neal Gompa  ---
CC BY-NC-SA is not permitted in Fedora:
https://fedoraproject.org/wiki/Licensing:Main#Bad_Licenses_3

[Bug 1869128] Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

--- Comment #4 from Bob Hepple  ---
So we're off to RPMFusion then, Carson. Not to worry, your existing FAS
credentials are good to go, the process is very similar to Fedora.

Here are some notes:

https://rpmfusion.org/Contributors

Once approved and the git repo is setup, getting a new package prepared is
similar to fedora but there is no bodhi: eg
rfpkg clone free/ilopona
rfpkg import ~/rpmbuild/SRPMS/ilopona-1.0.0-2.fc32.src.rpm
rfpkg ci -c
rfpkg push
rfpkg build

and branches:
rfpkg switch-branch f31
git merge master
rfpkg push
rfpkg build
... then close bugzilla

... just send me the bugzilla link when you're ready and I'll review it.

[Bug 1869128] Review Request: ilopona - toki pona dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=1869128

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail])

--- Comment #5 from Neal Gompa  ---
Carson here is the author of the application being reviewed here. He probably
can change the license of the assets to CC-BY-SA (no NC). Would you please
consider changing the license?