https://bugzilla.redhat.com/show_bug.cgi?id=2169529
Bug ID: 2169529 Summary: Review Request: python-slack-sdk - Python Slack SDK Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: omosnacek@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/omos/python-slack-sdk/fed... SRPM URL: https://download.copr.fedorainfracloud.org/results/omos/python-slack-sdk/fed... Description: The Slack platform offers several APIs to build apps. Each Slack API delivers part of the capabilities from the platform, so that you can pick just those that fit for your needs. This SDK offers a corresponding package for each of Slack’s APIs. They are small and powerful when used independently, and work seamlessly when used together, too. Fedora Account System Username: omos
COPR build: https://copr.fedorainfracloud.org/coprs/omos/python-slack-sdk/build/5519691/
https://bugzilla.redhat.com/show_bug.cgi?id=2169529
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://slack.dev/python-sl | |ack-sdk/
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5523491 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2169529
Troy Curtis troy@troycurtisjr.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |troy@troycurtisjr.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Troy Curtis troy@troycurtisjr.com --- Is this library targeted as a dependency of another package? I know that generally for development the recommendation is to not use system installed packages, so there might not a lot of users of this package unless there is already some package that you have in mind.
https://bugzilla.redhat.com/show_bug.cgi?id=2169529
--- Comment #3 from Ondrej Mosnáček omosnacek@gmail.com --- (In reply to Troy Curtis from comment #2)
Is this library targeted as a dependency of another package?
No, it's not.
I know that generally for development the recommendation is to not use system installed packages, so there might not a lot of users of this package unless there is already some package that you have in mind.
Is that recommendation officially stated anywhere? I remembered this thread [1], which lists several pros of having Python packages in Fedora (many applicable even to leaf libraries). Personally, I prefer to consume Python libraries from Fedora repos for my scripting needs, since it's easier to keep the packages up to date and I also don't need to install them again when I upgrade Fedora and the system Python version is bumped.
I plan to use this package for personal/work use (porting an existing IRC bot to Slack), so there will be at least one user :) Even if I were the only user, I don't see any harm in the package being in Fedora, as long as it's properly maintained.
[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
https://bugzilla.redhat.com/show_bug.cgi?id=2169529
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net
--- Comment #4 from Ben Beasley code@musicinmybrain.net --- There is no policy against having pure-Python library leaf packages in Fedora. Most people package pure-Python libraries as dependencies for applications, but if they are valuable to you, you are free to package them.
In this case, I think this is already packaged as part of https://src.fedoraproject.org/rpms/python-slackclient. That package should add:
%py_provides python3-slack %py_provides python3-slack-sdk
based on https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_....
https://bugzilla.redhat.com/show_bug.cgi?id=2169529
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- https://src.fedoraproject.org/rpms/python-slackclient/pull-request/2
https://bugzilla.redhat.com/show_bug.cgi?id=2169529
Ondrej Mosnáček omosnacek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|NEW |CLOSED Last Closed| |2023-02-28 14:24:41
--- Comment #6 from Ondrej Mosnáček omosnacek@gmail.com --- Oh, indeed python-slackclient is the same package. It even provides python3dist(slack-sdk), which I should have repoqueried first... Closing this review request.
package-review@lists.fedoraproject.org