[Bug 488197] New: Review Request: ibus-hangul - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ibus-hangul - The Rawcode engine for IBus

https://bugzilla.redhat.com/show_bug.cgi?id=488197

           Summary: Review Request: ibus-hangul - The Rawcode engine for
                    IBus
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: psatpute(a)redhat.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---


Spec URL: http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode.spec
SRPM URL:
http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode-1.0.0.20090303-...
Description: The Rawcode Engine for IBus

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-hangul - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Pravin Satpute <psatpute(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody(a)fedoraproject.org    |panemade(a)gmail.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Parag AN(पराग) <panemade(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Summary|Review Request: ibus-hangul |Review Request:
                   |- The Rawcode engine for    |ibus-rawcode - The Rawcode
                   |IBus                        |engine for IBus
               Flag|                            |fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197





--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com&gt;  2009-03-03 02:08:48 EDT
---
you need to BR: ibus-devel as well as need to modify configure.ac to change
package requirement from ibus-1.0 to ibus-1.1

Also, change %define to %global in spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197





--- Comment #2 from Parag AN(पराग) <panemade(a)gmail.com&gt;  2009-03-03 02:19:53 EDT
---
oops looks like ibus-devel-1.1.0.20090225-1.fc11 in rawhide provides ibus-1.0
not ibus-1.1

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197





--- Comment #3 from Pravin Satpute <psatpute(a)redhat.com&gt;  2009-03-03 02:52:51 EDT
---
remove %define as it was not require for ibus-rawcode
added BuildRequires: ibus-devel

new url

Spec URL: http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode.spec
SRPM URL:
http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode-1.0.0.20090303-...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Parag AN(पराग) <panemade(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Parag AN(पराग) <panemade(a)gmail.com&gt;  2009-03-03 03:46:43 EDT
---
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216185
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
26e7aeb1e54ebbab4de222f67ffe174f  ibus-rawcode-1.0.0.20090303.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package ibus-rawcode-1.0.0.20090303-2.fc11-i586 =>
  Requires: Requires: libc.so.6 libc.so.6(GLIBC_2.0) libdbus-1.so.3
libglib-2.0.so.0 libgobject-2.0.so.0 libibus.so.0 rtld(GNU_HASH)
  Provides: ibus-rawcode = 1.0.0.20090303-2.fc11

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Pravin Satpute <psatpute(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #5 from Pravin Satpute <psatpute(a)redhat.com&gt;  2009-03-03 04:20:06 EDT
---
New Package CVS Request
=======================
Package Name: ibus-rawcode
Short Description: The Rawcode input engine for IBus platform
Owners: pravins
Branches: devel
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Kevin Fenzi <kevin(a)tummy.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+




--- Comment #6 from Kevin Fenzi <kevin(a)tummy.com&gt;  2009-03-03 15:45:24 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488197] Review Request: ibus-rawcode - The Rawcode engine for IBus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488197


Pravin Satpute <psatpute(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE




--- Comment #7 from Pravin Satpute <psatpute(a)redhat.com&gt;  2009-03-03 23:39:54 EDT
---
completed build
Thanks Parag and Kevin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.