Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225950
Summary: Merge Review: jpackage-utils Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: fitzsim@redhat.com
Fedora Merge Review: jpackage-utils
http://cvs.fedora.redhat.com/viewcvs/devel/jpackage-utils/ Initial Owner: fitzsim@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: jpackage-utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225950
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
fitzsim@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |fitzsim@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: jpackage-utils
https://bugzilla.redhat.com/show_bug.cgi?id=225950
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
t.hartwig@itth.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |t.hartwig@itth.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: jpackage-utils
https://bugzilla.redhat.com/show_bug.cgi?id=225950
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|fitzsim@redhat.com |limb@jcomserv.net Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From limb@jcomserv.net 2008-02-04 13:04 EST ------- rpmlint:
Change Group tag to Applications/System, Utilities is not valid.
Change license, JPackage License is invalid. I think BSD is closest.
jpackage-utils.noarch: W: conffile-without-noreplace-flag /etc/java/jpackage-release A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
I can't find the tarball on the upstream site, so I can't tell you what the Source0 tag should be changed to, but it must include a URL.
The %description is a little on the large side, and sort of blind-sided me when I rpm -qi jpackage-utils. Not a blocker, just a suggestion.
Otherwise, looks great.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: jpackage-utils
https://bugzilla.redhat.com/show_bug.cgi?id=225950
------- Additional Comments From limb@jcomserv.net 2008-05-16 11:05 EST ------- Any updates?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: jpackage-utils
https://bugzilla.redhat.com/show_bug.cgi?id=225950
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dbhole@redhat.com
------- Additional Comments From limb@jcomserv.net 2008-07-25 09:59 EST ------- Adding current owner. . .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225950
--- Comment #4 from Jon Ciesla limb@jcomserv.net 2008-09-09 12:00:49 EDT --- Reviewed current SRPM from rawhide.
All the above still apply, except that the license tag has been fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225950
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2008-12-09 15:31:44 EDT --- Ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225950
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2009-03-31 11:14:38 EDT --- Tested current rawhide version, same as #4.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225950
--- Comment #7 from Deepak Bhole dbhole@redhat.com 2009-03-31 13:20:20 EDT --- None of the standard groups apply to this package. And it is not a system application, it is a collection of utility scripts only. Fedora policy allows rpmlint warnings about groups if none of the standard ones apply.
License now says BSD in rawhide.
/etc/java/jpackage-release should not be noreplace. Even if someone manually changes it for whatever reason, it should be overwritten when a new version is installed. /etc/fedora-release is the same way, %config without the noreplace.
As for the description -- there is no README in the upstream tarball, which is why it is so long I believe. I'll move it to a readme and point to it from the description.
Thanks for reviewing this. With the above description change, is it okay to close this issue?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225950
--- Comment #8 from Jon Ciesla limb@jcomserv.net 2009-03-31 13:37:13 EDT --- File the above as rpmlint exceptions and we're good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225950
Deepak Bhole dbhole@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #9 from Deepak Bhole dbhole@redhat.com 2009-03-31 14:02:46 EDT --- Great! New build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1268274
The rpmlint says: jpackage-utils.src: W: non-standard-group Utilities jpackage-utils.noarch: W: non-standard-group Utilities
The above 2 are acceptable because this package is a collection of utilities only, and there is no utility specific group in the grouplist that rpmlint searches.
jpackage-utils.noarch: W: conffile-without-noreplace-flag /etc/java/jpackage-release
The above is acceptable because even if the user changes the files, we want it to be overwritten when a newer version is installed - just as with the fedora-release file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225950
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #10 from Jon Ciesla limb@jcomserv.net 2009-04-01 08:40:32 EDT --- Great, APPROVED. Thanks!
package-review@lists.fedoraproject.org