[Bug 2156091] New: Review Request: qwtplot3d-qt6 - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Bug ID: 2156091
           Summary: Review Request: qwtplot3d-qt6 - Extended version of
                    the original QwtPlot3D library
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedor...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedor...

Description: Qt6 QwtPlot3D

Fedora Account System Username: sagitter

[Bug 2156091] Review Request: qwtplot3d-qt6 - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Vasiliy Glazov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value

[Bug 2156091] Review Request: qwtplot3d-qt6 - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Sandro Mani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sandro Mani  ---
Just a quick suggestion for future-proofness / analogy with other Qt libraries:
I'd call the base package qwtplot3d and then the subpackage qwtplot3d-qt6,
which then allows you to add say qwtplot3d-qt7 without renaming the source repo
or requiring an additional source repo. BTW, there appears to be no BR:
qwt-qt6-devel or equivalent?

[Bug 2156091] Review Request: qwtplot3d-qt6 - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

--- Comment #2 from Vasiliy Glazov  ---
1. Need to change License name to Zlib.

2. Remove %global gittag %{commit} as unused.

3. Change 
Source0:       
https://github.com/SciDAVis/qwtplot3d/archive/%%7Bcommit%7D/qwtplot3d-%%7Bco...
to
Source0:        %{url}/archive/%{commit}/qwtplot3d-%{commit}.tar.gz

4. It is really necessary?
Requires:       cmake(Qt6Core)
Requires:       cmake(Qt6Gui)

5. Change
%autosetup -n qwtplot3d-%{commit} -N

%patch0 -p1 -b .backup
to
%autosetup -p1 -n qwtplot3d-%{commit} -N

[Bug 2156091] Review Request: qwtplot3d-qt6 - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

--- Comment #3 from Vasiliy Glazov  ---
6. Change Buildrequires: to BuildRequires:

7. Need to review options list for %cmake because some of them not used:
    BUILD_EXAMPLES
    QT_QMAKE_EXECUTABLE
    QWT_INCLUDE_DIR
    QWT_LIBRARY
    QWT_VERSION_STRING
    SELECT_QT
    WITH_ZLIB

8. As I see zlib not used for build at all.

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Antonio T. sagitter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |qwtplot3d-qt6 - Extended    |qwtplot3d-qt - Extended
                   |version of the original     |version of the original
                   |QwtPlot3D library           |QwtPlot3D library

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

--- Comment #4 from Antonio T. sagitter  ---
(In reply to Sandro Mani from comment #1)
> Just a quick suggestion for future-proofness / analogy with other Qt
> libraries: I'd call the base package qwtplot3d and then the subpackage
> qwtplot3d-qt6, which then allows you to add say qwtplot3d-qt7 without
> renaming the source repo or requiring an additional source repo. BTW, there
> appears to be no BR: qwt-qt6-devel or equivalent?

I have re-named this package as qwtplot3d-qt
Probably, a Qt5 sub-package could obsolete the `qwtplot3d-qt5` rpm

(In reply to Vasiliy Glazov from comment #2)
> Change
>
> %autosetup -n qwtplot3d-%{commit} -N
>
> %patch0 -p1 -b .backup
> to
> %autosetup -p1 -n qwtplot3d-%{commit} -N

I prefer to use the %%patch command apart.

Let me work better to this package

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

--- Comment #5 from Sandro Mani  ---
Why not just qwtplot3d? Packages should use the upstream name, and the Qt "q"
is already in the q of qwt (Qt Widgets for Technical applications).

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Antonio T. sagitter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |NotReady

--- Comment #6 from Antonio T. sagitter  ---
(In reply to Sandro Mani from comment #5)
> Why not just qwtplot3d? Packages should use the upstream name, and the Qt
> "q" is already in the q of qwt (Qt Widgets for Technical applications).

qwtplot3d already exists in Fedora

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

--- Comment #7 from Sandro Mani  ---
Ah right now I see - qwtplot3d is dead upstream and qt3/qt4 only though, and
AFAICS no packages depend on either. What about switching that package to the
more recent fork and dropping qt3/qt4?

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

--- Comment #8 from Antonio T. sagitter  ---
(In reply to Sandro Mani from comment #7)
> Ah right now I see - qwtplot3d is dead upstream and qt3/qt4 only though, and
> AFAICS no packages depend on either. What about switching that package to
> the more recent fork and dropping qt3/qt4?

Yes, probably it's the better choice

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Antonio T. sagitter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|ASSIGNED                    |CLOSED
        Last Closed|                            |2023-01-01 15:01:44

--- Comment #9 from Antonio T. sagitter  ---
I'm closing this ticket.
Thank you Vasiliy and Sandro

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Antonio T. sagitter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |

[Bug 2156091] Review Request: qwtplot3d-qt - Extended version of the original QwtPlot3D library

https://bugzilla.redhat.com/show_bug.cgi?id=2156091

Antonio T. sagitter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|NotReady                    |
                URL|                            |https://lists.fedoraproject
                   |                            |.org/archives/list/devel@li
                   |                            |sts.fedoraproject.org/threa
                   |                            |d/YBJ34UEXVAHUUMPQLOOJUSDYS
                   |                            |YBHZ23D/