[Bug 537587] New: Review Request: dspam - bayesian filtering daemon, client, library and web ui - package-review

List overview All Threads
Download

newer

[Bug 537587] New: Review Request: dspam - bayesian filtering daemon, client, library and web ui

older

[Bug 561253] New: Review Request:...

[Bug 225743] New: Merge Review:...

Red Hat Bugzilla

15 Nov 2009 15 Nov '09

12:03 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: dspam - bayesian filtering daemon, client, library and web ui

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Summary: Review Request: dspam - bayesian filtering daemon, client, library and web ui Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nathanael@gnat.ca QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://www.gnat.ca/dspam.spec SRPM URL: http://www.gnat.ca/dspam-3.9.0-BETA4.src.rpm Description: The DSPAM agent masquerades as the email server's local delivery agent and filters/learns spams using an advanced Bayesian statistical approach (based on Baye's theorem of combined probabilities) which provides an administratively maintenance-free, easy-learning Anti-Spam service custom tailored to each individual user's behavior. Advanced because on top of standard Bayesian filtering is also incorporated the use of Chained Tokens, de-obfuscation, and other enhancements. DSPAM works great with Sendmail and Exim, and should work well with any other MTA that supports an external local delivery agent (postfix, qmail, etc.)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by thread

Red Hat Bugzilla

15 Nov 15 Nov

12:24 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)

--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-14 13:54:15 EDT --- ( From the message of the submitter on fedora-devel-list blocking needsponsor )

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:27 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |lvillani@binaryhelix.net

--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-14 13:56:58 EDT --- *** Bug 435121 has been marked as a duplicate of this bug. ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:20 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@ispbrasil.com.br

--- Comment #3 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-15 05:50:33 EDT --- I recommend you to read fedora packaging guidelines.

https://fedoraproject.org/wiki/PackageMaintainers

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

16 Nov 16 Nov

2:33 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #4 from Nathanael Noblet nathanael@gnat.ca 2009-11-15 16:03:16 EDT --- I have been. The file I posted has been updated probably 4 times since I posted it. I basically got it to the point where rpmlint no longer issued any warnings and I just learned I could run rpmlint on the actual rpms as well so I'm cleaning those up as well.

I've also looked over the duplicate bug that was closed and tried to learn a bit from there as well. I will continue to update this spec as I find pieces that don't meet the guidelines but some of it is simply that I'm not familiar enough with the guidelines as I go through it to notice infractions.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Nov 17 Nov

5:24 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #5 from Nathanael Noblet nathanael@gnat.ca 2009-11-16 18:54:22 EDT --- Very few rpmlint messages now...

* Mon Nov 16 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-BETA4 - Revise permission on /etc/dspam.conf and /var/lib/dspam - Remove compression on documentation - Move driver documentation to subpackages - Remove sqlite_drv.txt if neither sqlite driver is being built - Remove .la and .a files - Disable install-strip for the debuginfo package

* Sun Nov 15 2009 Stevan Bajic stevan@bajic.ch - 3.9.0-BETA4 - Splitting into libdspam package and driver package - Moving static libs and libtool archives into libdspam-devel package - Enabling build of single storage driver statically linked into DSPAM - Enabling build of single storage driver as dynamically loaded module - Compressing SQL files and documentation - Added version tag to change log - Renamed cron and logrotate scripts to follow Fedora packing guidelines - Added post/postun for libdspam and all libdspam storage drivers - Replaced all tabs with softtabs (don't know if this is needed but Nathanael had it that way) - Enabled install-strip - Extended package description

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:39 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #6 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-16 19:09:37 EDT --- what are your fedora account user name ?

Can you post a updated spec file + src.rpm file ?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:32 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #7 from Nathanael Noblet nathanael@gnat.ca 2009-11-17 01:02:02 EDT --- account user name is gnat.

The spec file + src.rpm file is at the url provided. I've been updating them directly each time I make a change.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:38 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #8 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-17 01:08:56 EDT --- please bump the version and post a updated version after each change.

spec file. src.rpm

also a koji scratch build should be welcome

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:15 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #9 from Nathanael Noblet nathanael@gnat.ca 2009-11-17 02:45:34 EDT --- Looks like it completed successfully.

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1811003

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

18 Nov 18 Nov

4:13 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #10 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-17 17:43:33 EDT --- looks like my english is too bad, because I have asked you to post spec file + src.rpm + koji scratch build,

I am sorry,

you don't want to follow my instructions then I don't want to help you!

I think no one will help you, if you don't follow instructions

please stop wasting the time of others

good luck!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:35 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #11 from Nathanael Noblet nathanael@gnat.ca 2009-11-17 18:05:38 EDT --- In the first post is the following:

Spec URL: http://www.gnat.ca/dspam.spec SRPM URL: http://www.gnat.ca/dspam-3.9.0-BETA4.src.rpm

The message *just* before yours is:

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1811003

For my koji scratch build.

I fail to see how I'm not following instructions.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:36 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #12 from Nathanael Noblet nathanael@gnat.ca 2009-11-17 18:06:38 EDT --- I will from now on bump the version as I work on it, but currently what is posted up there is the latest and greatest.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:30 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #13 from Nathanael Noblet nathanael@gnat.ca 2009-11-17 19:00:33 EDT --- Updated version info as per the naming guidelines.

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.1.BETA4.fc12.src.rpm

Nothing has changes except the version number.

About all the conditionals. I can remove them if required. However upstream would like to stay in sync with this rpm package, so was hoping we could keep the conditionals in there incase someone wanted to get the srpm and build with some conditionals to get a different package. Originally the spec file had one default of not building any of the sub packages. It has now been setup with the most sensible defaults allowing users to pick their backend storage on fedora.

If the conditionals are a problem (I looked and saw nothing in the guidelines about it). I can remove them, however as stated above upstream would then keep its own copy of the spec for whatever reason and fedora users that wanted to rebuild dspam with other options for whatever reason would have to hack the specfile.

Let me know if conditionals like that are a no no, like I said I didn't see anything in the guidelines about it.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

19 Nov 19 Nov

7:13 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Rahul Sundaram sundaram@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |sundaram@redhat.com

--- Comment #14 from Rahul Sundaram sundaram@redhat.com 2009-11-18 20:43:53 EDT ---

Please remove the conditionals especially things like

"# use "rpmbuild --with single_dyn_drv" or "rpm --define '_with_single_dyn_drv 1'" (for RPM 3.x)"

It doesn't make any sense whatsoever for a new package in Fedora to have a conditional for a non current RPM release. All the conditionals just looks very convoluted. You can keep a minimum number of them if really required with comments on where this is useful.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:28 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #15 from Nathanael Noblet nathanael@gnat.ca 2009-11-18 21:58:18 EDT --- Removed all conditionals.

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.4.BETA4.fc12.src.rpm

I'm also trying to find out about the two setgid binaries rpmlint complains about.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:31 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #16 from Nathanael Noblet nathanael@gnat.ca 2009-11-18 22:01:42 EDT --- I'm also wondering what to do about the URL: Source0: tags... The files are on sourceforge and I've seen posts on fedora-devel list about making sure that URL/Source0 can actually download the file. Are there other spec files with sourceforge downloads I can look at?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:34 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #17 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-18 22:04:01 EDT --- every fedora distro have perl and sed.

Requires: sed Requires: perl

no need to have this is requires, also you can remove versioning in requires mysql-devel >= 4.0 etc...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:35 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #18 from Rahul Sundaram sundaram@redhat.com 2009-11-18 22:05:25 EDT --- For source URL, refer to

https://fedoraproject.org/wiki/Packaging/SourceURL

There are several thousands of spec files at

http://cvs.fedoraproject.org/viewvc/rpms/

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:38 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #19 from Rahul Sundaram sundaram@redhat.com 2009-11-18 22:08:54 EDT ---

A note on Requires at

https://fedoraproject.org/wiki/Packaging/Guidelines#Requires

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:11 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #20 from Nathanael Noblet nathanael@gnat.ca 2009-11-18 22:41:27 EDT --- http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.5.BETA4.fc12.src.rpm

Thanks for the link re: Source0

* Wed Nov 18 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.5.BETA4 - Cleanup Requires - Stop building web ui as some perl dependancies are unmet - Fixed Source0 url

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:16 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #21 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-18 22:46:44 EDT --- for me no reason to use versioning.

BuildRequires: sqlite-devel >= 3.0 BuildRequires: autoconf >= 2.5 BuildRequires: automake >= 1.7

also at the bottom

# make some dirs

this is not necessary, you can use install -Dp -m , this will create directory's if necessary.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:17 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #22 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-18 22:47:39 EDT --- you can move dspam-web-ui.conf out of spec file and use it as SOURCE4, this will make your spec file small and more readable.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:45 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #23 from Rahul Sundaram sundaram@redhat.com 2009-11-18 23:15:32 EDT ---

According to packaging guidelines:

"The Vendor tag should not be used. It is set automatically by the build system"

If you build only for Fedora, you can drop

"Buildroot: %{_tmppath}/%{name}-%{version}-root"

and after the %install line, drop

"[ "$RPM_BUILD_ROOT" != "/" ] && %{__rm} -rf $RPM_BUILD_ROOT"

after the %clean line, change to

%{__rm} -rf $RPM_BUILD_ROOT

!=/ check is unnecessary. RPM takes care of that.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:50 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #24 from Rahul Sundaram sundaram@redhat.com 2009-11-18 23:20:37 EDT --- Another question: Why are you packaging the BETA release instead of the latest stable version?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:57 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #25 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-18 23:27:36 EDT ---

...

If you build only for Fedora, you can drop

"Buildroot: %{_tmppath}/%{name}-%{version}-root"

please leave the build root, I want it for EL-5

look ->

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:06 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #26 from Nathanael Noblet nathanael@gnat.ca 2009-11-19 00:36:24 EDT --- I've tried removing the # make some dirs parts so for example I now have

%{__install} -Dp -m 644 src/tools.mysql_drv/*.sql.gz $RPM_BUILD_ROOT%{_datadir}/%{name}/sql-scripts/mysql/

But it fails

/usr/bin/install: target `/home/gnat/Projects/Packages/BUILDROOT/dspam-3.9.0-0.6.BETA4.fc12.x86_64/usr/share/dspam/sql-scripts/mysql/' is not a directory: No such file or directory

I've tried looking at man install, so I'm a bit confused the -D should work should it not?

About the BETA release. 3.8.0 is REALLY old, and upstream has basically taken 3.8 and applied a bunch of fixes and community patches. Upstream had gone dead twice in the last 3 years. The original author had his software purchased by a company. That company did nothing, and released it fully open to the community that wanted to continue development. Packaging 3.8 would be a waste of time as 3.9 should be out soon enough, and is really 3.8 + fixes.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:26 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #27 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-19 00:56:16 EDT --- for what reason you're running this ?

%build aclocal -I m4 sh ./autogen.sh autoheader automake --add-missing autoconf umask 022

I think inside o autogen.sh it's run all required commands.

It's also seems to work without this, have you tried ?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:55 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #28 from Nathanael Noblet nathanael@gnat.ca 2009-11-19 10:25:47 EDT --- http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.6.BETA4.fc12.src.rpm

* Thu Nov 19 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.6.BETA4 - Use install -Dp -m instead of pre-creating the directories - Move dspam-webui.conf to Source4 - Removed some of the autoX calls

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:15 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #29 from Nathanael Noblet nathanael@gnat.ca 2009-11-19 10:45:20 EDT --- http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.7.BETA4.fc12.src.rpm

* Thu Nov 19 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.7.BETA4 - Changed BuildRoot definition - Don't test for buildroot in install section

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:46 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #30 from Nathanael Noblet nathanael@gnat.ca 2009-11-19 11:16:07 EDT --- also in release 0.7... - Remove setgid on dspamc - Moved css* binaries to disabled dspam-web subpackage

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:12 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #31 from Nathanael Noblet nathanael@gnat.ca 2009-11-19 11:42:32 EDT --- http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.8.BETA4.fc12.src.rpm

* Thu Nov 19 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.8.BETA4 - Restored css* binaries they are hash driver utilities

I'm talking with upstream about renaming their hash utils from csscompress to dspam-hash-compress or something along those lines, the names are deceiving and conflict with CRM114 if it ever got packaged.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

25 Nov 25 Nov

5:25 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #32 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-25 06:55:14 EDT --- # remove .la files find $RPM_BUILD_ROOT -name *.la | xargs rm -rf # remove .a files find $RPM_BUILD_ROOT -name *.a | xargs rm -rf

I preffer this way.

find $RPM_BUILD_ROOT -name *.la -exec rm {} ; find $RPM_BUILD_ROOT -name *.a -exec rm {} ;

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:07 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #33 from Nathanael Noblet nathanael@gnat.ca 2009-11-25 11:37:09 EDT --- * Wed Nov 25 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.9.BETA4 - Modified the line removing .la and .a files

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.9.BETA4.fc12.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

30 Nov 30 Nov

12:16 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp

--- Comment #34 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-29 13:46:10 EDT --- Some notes

A. Description, etc. * Naming - Please explain why you want to name subpackages in libdspam(-foo) style. On Fedora usually subpackages are named as "dspam-libs" or "dspam-devel" or "dspam-hash" or so.

! By the way, but for "libdspam" and "libdspam-devel", the naming of libdspam-foo subpackages are definitely wrong because none of these package contains system-wide libraries. - Files under %_libdir/dspam are just plugins and not system-wide libraries. Also see below (about calling ldconfig)

- "%package -n dspam-web" can simply be "%package web"

* Dependency between subpackages https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package - "dspam" binary rpm should have "dspam-libs = %{version}-%{release}" - "dspam-hash" should have "dspam = %{version}-%{release}" (and other subpackage should have similar dependency). ! Note that dependency between subpackages should usually be EVR (Epoch-Version-Release) specific, not just version.

* Other dependency - "Requires: pkgconfig" (for -devel subpackage) is no longer needed (for F-11/12/13) https://fedoraproject.org/wiki/PackagingDrafts/PkgconfigAutoRequires (This is still a draft, however will be accepted on 2009-12-03).

- For perl module related dependency, please use virtual provides names instead of using rpm names directly. https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

B. %prep, %build, %install, %check * Timestamp - Please consider to use --------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" --------------------------------------------------------------- to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools.

C. scriptlets / service * "source"ing /etc/profile - Why do you "source" /etc/profile? (note that rpm executes these scriptlets in subshells and subshell exits when those scriptlets are done)

* Calling /sbin/ldconfig - You don't have to call /sbin/ldconfig for rpms not containing system-wide libraries (i.e. needed only for dspam-libs binary rpm)

* restart service on %postun - is wrong because "restart" activates service even if the service was off before (this should be condrestart)

https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_...

* Missing Requires - Add missing "Requires(post): chkconfig" or so:

https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_...

* service-default-enabled https://fedoraproject.org/wiki/Packaging/SysVInitScript#.23_chkconfig:_line - rpmlint shows: ------------------------------------------------------------- dspam.i686: W: service-default-enabled /etc/rc.d/init.d/dspam ------------------------------------------------------------- i.e. currently dspam service is enabled by default once dspam rpm is enabled, which is usually not desided. Usually service should be off by default, i.e. change the line ------------------------------------------------------------- # chkconfig: 345 70 30 ------------------------------------------------------------- to ------------------------------------------------------------- # chkconfig: - 70 30 -------------------------------------------------------------

D. %files * %defattr - Now we usually use %defattr(-.root.root,-)

* Owner/Group/Permission --------------------------------------------------------------- -r-x--s--x 1 root root 88252 Nov 29 16:10 /usr/bin/dspam --------------------------------------------------------------- - However your spec file shows: --------------------------------------------------------------- 120 %configure \ 137 --with-dspam-owner='%{dspam_user}' \ 138 --with-dspam-group='%{dspam_group}' \ --------------------------------------------------------------- and build.log shows: --------------------------------------------------------------- 779 chown: changing ownership of `/builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/usr/bin/dspam': Operation not permitted 784 chgrp: changing group of `/builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/usr/bin/dspam': Operation not permitted 801 chown: changing ownership of `/builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/var/lib/dspam': Operation not permitted 802 chgrp: changing group of `/builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/var/lib/dspam': Operation not permitted 815 chown: changing ownership of `/builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/var/log/dspam': Operation not permitted 816 chgrp: changing group of `/builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/var/log/dspam': Operation not permitted --------------------------------------------------------------- So the owner/group of these files/directories seem wrong (in the binary rpms). Set these explicitly by %attr.

- Also build.log shows: --------------------------------------------------------------- 798 chmod "770" /builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/var/lib/dspam; \ 812 chmod "770" /builddir/build/BUILDROOT/dspam-3.9.0-0.9.BETA4.fc13.i386/var/log/dspam; \ --------------------------------------------------------------- However, currently these directories have 0755 permission (in the binary rpm). Please check if permissions are set correctly.

* %files entry unification - By the way %files entry --------------------------------------------------------------- %files %dir foo/ foo/* --------------------------------------------------------------- (where foo/ is a directory) can be unified as --------------------------------------------------------------- %files foo/ --------------------------------------------------------------- This style contains the directory foo/ itself and all files/directories/etc under foo/.

* Macros - Use %{_initddir} for %_sysconfdir/rc.d/init.d:

https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_the_f...

* Directory ownership issue - The following directories are not owned by any packages: -------------------------------------------------------------- /usr/share/dspam/ /usr/share/dspam/sql-scripts/ --------------------------------------------------------------

E. Misc * Permission of files in srpm -------------------------------------------------------------- dspam.src: W: strange-permission dspam-logrotate 0600 dspam.src: W: strange-permission dspam-cron 0775 dspam.src: W: strange-permission dspam-init.d 0600 -------------------------------------------------------------- - Usually we request that all files in srpm should be 0644.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4 Dec 4 Dec

2:03 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #35 from Nathanael Noblet nathanael@gnat.ca 2009-12-03 15:33:19 EDT --- I think I caught everything you pointed out except with the following:

1) I didn't do much about file/dir permissions yet but will. I have questions I'll post in a separate comment.

2) I didn't rename the libdspam to dspam-libs because you can install the library independent of dspam, it can be used in other projects/programs. If someone were to write a plugin for evolution or thunderbird. the dspam package is only necessary for an MTA, whereas the library can be used in all sorts of places.

3) The libdspam-X are required by the library for storage of all the token data it produces. So I'm not sure what to call them other than libdspam-X, I could rename them to dspam-plugin-X or dspam-storage-X but that implies you need the dspam package which you don't. So if you could advise what to do here.

%changelog * Sun Nov 29 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.10.BETA4 - Change dspam init to not be enabled by default - Add EVR dependancy from all sub packages - Removed pkgconfig requirement - package -n dspam-web renamed to package web - Updated perl requires even though dspam-web is not being built currently - Added post/preun requirements to chkconfig and initscripts - Updated defattr lines - use _initrddir instead of _sysconfdir/rc.d/init.d (RHEL compat) - updated source file permissions - get libdspam to own the sql-scripts directory

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.10.BETA4.fc12.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:11 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #36 from Nathanael Noblet nathanael@gnat.ca 2009-12-03 15:41:44 EDT --- When you say the following: ============ START QUOTE ========================================== * %files entry unification - By the way %files entry --------------------------------------------------------------- %files %dir foo/ foo/* --------------------------------------------------------------- (where foo/ is a directory) can be unified as --------------------------------------------------------------- %files foo/ --------------------------------------------------------------- This style contains the directory foo/ itself and all files/directories/etc under foo/. ============ END QUOTE ===========================================

I started looking at some of the files entries and am not sure about some of them for example.

Should %{_bindir}/* be %{_bindir}/? Wouldn't that mean I would own the bindir? So I assume you want that applied only to directories I would own.

Which brings me to my next question about that. <snip> %dir %{_datadir}/%{name}/sql-scripts/mysql %doc %attr(0644,root,root) %{_datadir}/%{name}/sql-scripts/mysql/* </snip>

Can I combine that into one line? I assume I can't because I want the attr to apply to the files and not the directory..

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Dec 5 Dec

11:30 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #37 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-05 13:00:41 EDT --- For -0.10:

* Naming (In reply to comment #35)

...

I didn't rename the libdspam to dspam-libs because you can install the

library independent of dspam, it can be used in other projects/programs. If someone were to write a plugin for evolution or thunderbird. the dspam package is only necessary for an MTA, whereas the library can be used in all sorts of places.

- Fedora already many examples about this. e.g. There are some apprecations which requires mysql-libs, but not mysql or mysql-server. And there are many other examples.

...

The libdspam-X are required by the library for storage of all the token data

it produces. So I'm not sure what to call them other than libdspam-X, I could rename them to dspam-plugin-X or dspam-storage-X but that implies you need the dspam package which you don't. So if you could advise what to do here.

- You can name as dspam-plugin-foo or dspam-foo and this does not mean that dspam(-plugin)-foo requires dspam binary rpm (unless you write so in the spec file)

* Directory ownership issue - This time the following directories are not owned by any packages: ---------------------------------------------------------------- /usr/share/dspam/ /var/lib/dspam/txt/ ----------------------------------------------------------------

(In reply to comment #36)

...

Which brings me to my next question about that.

<snip> %dir %{_datadir}/%{name}/sql-scripts/mysql %doc %attr(0644,root,root) %{_datadir}/%{name}/sql-scripts/mysql/* </snip>

Can I combine that into one line? I assume I can't because I want the attr to apply to the files and not the directory..

- I avoid to use %attr as much as possible. (0644,root,root) permission on files are default's permission so if you set this permission _in advance_, you don't have to write %attr(0644,root,root) explicitly.

i.e. set permission at %install like --------------------------------------------------------------- chmod 0644 %buildroot%_datadir/%name/*/*/* --------------------------------------------------------------- and I don't usually write %attr(0644,root,root) for files and %attr(0755,root,root) for directories.

Another thing: * Documents - Add "LICENSE" files to -libs package (because including "LICENSE" text to %doc is a must if it exists and all dspam related packages require -libs package) - And consider to move document files in dspam binary rpm to -libs package (because one can install dspam-libs package only)

And please check permission/owner/group is corrently set for all files ( especially, I don't think permission of /usr/bin/dspam is set correctly. Currently /usr/bin/dspam has (2511,root,root) permission (i.e. has setgid bit and group is root), which means when this script is executed, the process is always run with root group.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

24 Dec 24 Dec

8:23 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

--- Comment #38 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-24 09:53:31 EDT --- ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:03 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Nathanael Noblet nathanael@gnat.ca changed:

--- Comment #39 from Nathanael Noblet nathanael@gnat.ca 2009-12-24 11:33:22 EDT --- still here and kicking... We just had to migrate our server to a new dual server setup so I've been super busy... I'll address the rest of the issues.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Jan 8 Jan

4:31 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #40 from Nathanael Noblet nathanael@gnat.ca 2010-01-07 18:01:04 EDT ---

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1908312

* Wed Jan 7 2010 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.13.RC2 - Updated cron script - Added dspam-front script that will return a proper error code to avoid bounces - Fixed ownership issues of /var/lib/dspam/txt - Checked ownership/permissions of sql scripts - Don't compress sql purge scripts

* Fri Dec 18 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.12.RC2 - Bumped upstream version - Fixed requirements to be dspam-libs instead of libdspam

* Mon Dec 7 2009 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.11.BETA4 - Renamed libdspam to dspam-libs - Moved docs to -libs package - Added LICENSE file - Fixed some directory ownership issues

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.13.RC2.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:41 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #41 from Nathanael Noblet nathanael@gnat.ca 2010-01-07 18:11:52 EDT --- I've checked and the odd permissions on /var/lib/dspam in necessary for security purposes.

The dspam binary is setgid on purpose. It isn't strictly necessary in *all* ways it can be configured, however the most common ways use that. I'll get more clarification as to what it does setgid vs non setgid methods of operation. We use it on our production servers in that mode.

Is there anything else left?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:17 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #42 from Nathanael Noblet nathanael@gnat.ca 2010-01-07 18:47:10 EDT --- %changelog * Wed Jan 7 2010 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.14.RC2 - Updated cron script again - Added README.fedora for fedora specific configuration information

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.14.RC2.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:23 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #43 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-08 11:53:31 EDT --- For -0.14:

* -n specification - For example "%package -n dspam-libs" can simply be "%package libs" (and the latter form is commonly used).

Another example is that "%post -n dspam-libs -p /sbin/ldconfig" can simply be "%post libs -p /sbin/ldconfig".

* Directory ownership issue - This time the following directories are not owned by any packages: --------------------------------------------------------------------- /usr/share/dspam/sql-scripts ---------------------------------------------------------------------

* Timestamp http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps - When using "cp" or "install" commands, add "-p" option to keep timestamps on installed files.

* Again owner/group/permission (In reply to comment #41)

...

I've checked and the odd permissions on /var/lib/dspam in necessary for security purposes.

The dspam binary is setgid on purpose. It isn't strictly necessary in *all* ways it can be configured, however the most common ways use that. I'll get more clarification as to what it does setgid vs non setgid methods of operation. We use it on our production servers in that mode.

- To be clear, what I am said is that currently the group of /usr/bin/dspam is root and I guess this is wrong when this binary has setgid, because with this setgid/group executing /usr/bin/dspam is always done with root group.

build.log says: --------------------------------------------------------------------- 826 if test x"nobody" != xnone; then \ 827 chown "nobody" /builddir/build/BUILDROOT/dspam-3.9.0-0.14.RC2.i386/usr/bin/dspam; \ 828 fi 829 chown: changing ownership of `/builddir/build/BUILDROOT/dspam-3.9.0-0.14.RC2.i386/usr/bin/dspam': Operation not permitted 831 if test x"mail" != xnone; then \ 832 chgrp "mail" /builddir/build/BUILDROOT/dspam-3.9.0-0.14.RC2.i386/usr/bin/dspam; \ 833 fi 834 chgrp: changing group of `/builddir/build/BUILDROOT/dspam-3.9.0-0.14.RC2.i386/usr/bin/dspam': Operation not permitted --------------------------------------------------------------------- So I guess /usr/bin/dspam should have %attr(2511,nobody,mail). Would you again check permission/owner/group of all files/directories?

! Note - Also, for binaries/directories which have some special permission/group/owner, you should write these permission/group/owner with explicit %attr directive in the spec file like --------------------------------------------------------------------- %files ... %attr(0770,root,%{dspam_group}) %dir %{dspam_logdir}/ %attr(0770,root,%{dspam_group}) %dir %{dspam_homedir}/ %attr(%{dspam_mode},%{dspam_user},%{dspam_group}) %dir %{_var}/run/dspam ... ... %{_bindir}/css* %attr(%{dspam_mode},%{dspam_user},%{dspam_group}) %{_bindir}/dspam %{_bindir}/dspam[-_c]* ... --------------------------------------------------------------------- (i.e. if the permission/group/owner is not (0755,root,root) (for directory/ executable files) or (0644,root,root) (normal files), you must use %attr explicitly in the spec file)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:23 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:46 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #44 from Nathanael Noblet nathanael@gnat.ca 2010-01-08 13:16:50 EDT --- * Fri Jan 8 2010 Nathanael Noblet nathanael@gnat.ca - 3.9.0-0.15.RC2 - Added README.cssclean to dspam-hash - Fixed logrotate script using non-existant dspam user - Cleaned up package -n naming - Corrected dspam, and other directory permissions to nobody:mail - Moved css* to dspam-hash as they are only needed with that driver - removed nonsense configure parameter enabling and disabling syslog

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-0.15.RC2.src.rpm

----------------------------------------------------------- You were correct the dspam binary needed nobody:mail I didn't notice it wasn't the right owner as my setup doesn't run it in the daemon mode and specifically sets it to nobody:mail via postfix master.cf.

########### Questions: ########### 1) I'm wondering how you find the non-owned directories. After you showed me the other ones I tried to make sure I had them all but couldn't seem to find a command that gives that output via google...

2) The cron script for dspam requires that the user edit it to provide the path to the sql-script/backend they are using. So I would like it that upon upgrade, that file isn't overwritten however when marking it as %config(noreplace) I get rpmlint warnings about executable marked as config. Is there a proper way to have that file not be replaced by rpm on upgrades?

I have one last issue I'm tracking down in the actual usage of the program as it should be placing logs in /var/log/dspam but they are being put in /var/lib/dspam at the moment even though the configure script is being told where so dspam should be behaving. Other than that dspam seems to be working well in my VMs and live boxes upgraded from a 3-4 year old self created rpm of 3.8.0.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Jan 15 Jan

2:24 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #64 from Enrico Scholz enrico.scholz@informatik.tu-chemnitz.de 2010-01-14 15:54:42 EST --- please move /usr/bin/dspam_pg2int8 from core into -pgsql (it adds postgresql deps to core package).

Can you try to pass 'LDFLAGS=-Wl,--as-needed' somehow? Current binaries are overlinked (see 'ldd -u -r /usr/bin/dspam*' output).

There should be probably removed the worl-read permissions from the configuration files because they contain authentication data.

I would like to have a lightweighted client package with only the '/usr/bin/dspamc' program; this can be used for clients which talk to a central dspam server but do not need all the other stuff (dspam user, /var/...).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:06 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #65 from Enrico Scholz enrico.scholz@informatik.tu-chemnitz.de 2010-01-14 16:36:41 EST --- You should either require 'which' or use the 'type -p' shell builtin in the initscript.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #66 from Nathanael Noblet nathanael@gnat.ca 2010-01-15 11:30:40 EST --- If I pass LDFLAGS as request, the EPEL version segfaults.

Also about the iniscript, I'm thinking of simply putting them in hardcoded to the /etc/sysconfig/dspam file. I don't see why you'd want it to use other than the fedora provided one...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:56 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #67 from Enrico Scholz enrico.scholz@informatik.tu-chemnitz.de 2010-01-15 12:26:10 EST --- there seems to be a path traversal security issue (which is relevant because dspamd is running as root):

$ dspamc --classify --user ../../../../../../etc -- < /tmp/sp

# strace -f `pidof dspamd` stat64("/var/lib/dspam/data/././../../../../../..", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 ...

# ll / -rw-rw---- 1 root mail 1573112 15. Jan 18:24 etc.css -rw-rw---- 1 root mail 0 15. Jan 18:24 etc.lock -rw-rw---- 1 root mail 12 15. Jan 18:24 etc.stats

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:05 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #68 from Nathanael Noblet nathanael@gnat.ca 2010-01-15 12:35:33 EST --- If dspamd ran as user dspam, that would mitigate the issue, however should the dspam authors fix it anyway? I assume dspam --user parameter shouldn't really accept path chars as opposed to a sane username?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:29 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #69 from Enrico Scholz enrico.scholz@informatik.tu-chemnitz.de 2010-01-15 12:59:13 EST --- I filed upstream report at

https://sourceforge.net/tracker/?func=detail&aid=2932993&group_id=25...

IMO running as non-root is mandatory for this kind of programs.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:30 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #70 from Nathanael Noblet nathanael@gnat.ca 2010-01-15 13:00:51 EST --- * Fri Jan 15 2010 Nathanael Noblet nathanael@gnat.ca - 3.9.0-1.1 - Remove world readable perms on /etc/dspam.conf - Re-enabled dspam-web as the required dependancies exist - Added -client package - Created /etc/sysconfig/dspam file and modified initscript to use it by default

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-1.fc12.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

20 Jan 20 Jan

11:30 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #71 from Nathanael Noblet nathanael@gnat.ca 2010-01-20 01:00:09 EST --- @Mamoru Tasaka

I just submitted the clamsmtp review request. Then afterwards wanted to close the old ones I had found and marked as duplicate. Someone has submitted a new review a couple days ago. I feel that mine is further along but would you prefer I review his, or have you review mine? The relevant bugs are..

Mine: https://bugzilla.redhat.com/show_bug.cgi?id=557011 Other: https://bugzilla.redhat.com/show_bug.cgi?id=555059

The only thing mine is missing is selinux, which I'm in contact with them to have fixed.

In any case, please advise what you'd rather I do to show that I've learned the guidelines better than my first submission...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

21 Jan 21 Jan

12:06 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #72 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-20 13:36:39 EST --- Checked 3.9.0-1.1

* %setup - "%setup -q -n %{name}-3.9.0" can be simplified as "%setup -q"

! Comments - Remove comments like "# webui - disabled"

* Macros - Use %{_datadir} instead of %{_usr}/share https://fedoraproject.org/wiki/Packaging/RPMMacros

- And use %{_sysconfdir} instead of /etc .

* file splitting - %_bindir/dspam-front shell script is not useful without %_bindir/dspam (as its contents shows)

* %attr - "%attr(0755,root,root)" for directory, "%attr(0644,root,root)" for files, and "%attr(-,root,root)" are default attribute and these should be removed.

* Duplicate %files entry ------------------------------------------------------------------ %dir %attr(0755,root,root) %{_usr}/share/dspam-webui/templates %attr(-,root,root) %{_usr}/share/dspam-webui/* ------------------------------------------------------------------ - Note that %{_usr}/share/dspam-webui/* contains %{_usr}/share/dspam-webui/templates , and so this causes the following warning from rpmbuild: ------------------------------------------------------------------ 1142 Processing files: dspam-web-3.9.0-1.1.fc13.i686 1143 warning: File listed twice: /usr/share/dspam-webui/templates ------------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:02 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #73 from Nathanael Noblet nathanael@gnat.ca 2010-01-21 01:32:06 EST --- * Wed Jan 20 2010 Nathanael Noblet nathanael@gnat.ca - 3.9.0-1.3 - Fixed web comments - Replaced usr/share with macro - Moved dspam-front back to the server portion where it belongs - Changed directory name from dspam-webui to dspam-web - Updated dspam-web.conf to point to proper paths - Added external dependency script to filter out wrong perl deps

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-1.3.fc12.src.rpm

I'm just tracking down some issues with the actual web subpackage properly functioning. I've never used that particular feature of dspam on my servers so I'm just getting up to speed.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:46 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #74 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-21 12:15:59 EST --- For -1.3:

* Release number - By the way why do you use "1.3" for release number? For formally released tarball, release number in the spec file should be "X%{?dist}" where X is an integer.

* Macros - Again please use %{_sysconfdir} instead of /etc .

Except for that, this package looks good to me.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Jan 22 Jan

2:16 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #75 from Nathanael Noblet nathanael@gnat.ca 2010-01-21 15:46:25 EST --- * Thu Jan 21 2010 Nathanael Noblet nathanael@gnat.ca - 3.9.0-2 - Replaced last etc with _sysconfdir macro - Use single integer release version - Fixed dspam-web.conf to actually work by default when installed. - Updated configure.pl to point to the proper directory - Placed the relevant README's in both -libs and the main package as they are relevant for both

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-2.fc12.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:34 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #76 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-22 12:04:42 EST --- One thing:

# service dspam status ; echo $? 75

It seems that Source5 (dspam-front) is installed as /etc/sysconfig/dspam and this is perhaps incorrect.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:46 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #77 from Nathanael Noblet nathanael@gnat.ca 2010-01-22 12:16:43 EST --- * Fri Jan 22 2010 Nathanael Noblet nathanael@gnat.ca - 3.9.0-3 - Fixed missing source file affecting dspam daemon service

http://www.gnat.ca/dspam.spec http://www.gnat.ca/dspam-3.9.0-3.fc12.src.rpm

You are completely correct, that must have disappeared when I added the perl requires filter... All fixed up.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:53 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

--- Comment #78 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-22 13:23:42 EST --- Okay, now approving.

----------------------------------------------------------- This package (dspam) is APPROVED by mtasaka -----------------------------------------------------------

Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji)".

Now I am sponsoring you.

If you want to import this package into Fedora 11/12, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Removing NEEDSPONSOR.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

23 Jan 23 Jan

2:29 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Nathanael Noblet nathanael@gnat.ca changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:31 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #79 from Nathanael Noblet nathanael@gnat.ca 2010-01-22 16:01:47 EST --- New Package CVS Request ======================= Package Name: dspam Short Description: dspam - bayesian filtering daemon, client, library and web ui Owners: gnat Branches: F-11 F-12 EL-5 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

24 Jan 24 Jan

10:58 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #80 from Jason Tibbitts tibbs@math.uh.edu 2010-01-24 12:28:15 EST --- CVS done (by process-cvs-requests.py).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

25 Jan 25 Jan

8:33 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

--- Comment #81 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-25 10:03:30 EST --- Closing.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

31 Mar 31 Mar

9:01 p.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Nathanael Noblet nathanael@gnat.ca changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

--- Comment #82 from Nathanael Noblet nathanael@gnat.ca 2010-03-31 11:31:04 EDT --- Package Change Request ====================== Package Name: dspam New Branches: EL-4 Owners: gnat

Just got a request for the package for EPEL4 so if I could have a cvs branch created for it please.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1 Apr 1 Apr

2:46 a.m.

New subject: [Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=537587

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #83 from Jason Tibbitts tibbs@math.uh.edu 2010-03-31 17:16:48 EDT --- CVS done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5592

Age (days ago)

5729

Last active (days ago)

package-review@lists.fedoraproject.org

66 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla