[Bug 2358883] New: Review Request: rust-bitfield-struct0.7- Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Bug ID: 2358883
           Summary: Review Request: rust-bitfield-struct0.7- Struct-like
                    procedural macro for bit-fields
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/lleonard/bitfield-struct/...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/lleonard/bitfield-struct/...
Description: Procedural macro for bitfields that allows specifying bitfields as
structs. As this library provides a procedural macro, it has no runtime
dependencies and works for no-std environments.

Fedora Account System Username: lleonard

This is part of the effort to add the Coconut-SVSM paravisor to Fedora.
It would enables Fedora virtualization hosts to launch confidential
virtual machines using AMD's SEV-SNP technology.
See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP

Packaging version 0.7 because it's required by igvm crate

spec file was produced by rust2rpm
Builds cleanly on f41 42 and rawhide

[Bug 2358883] Review Request: rust-bitfield-struct0.7- Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

--- Comment #1 from Fedora Review Service  ---
The ticket summary is not in the correct format.
Expected:

Review Request: <main package name here> - <short summary here>

Found:

Review Request: rust-bitfield-struct0.7- Struct-like procedural macro for
bit-fields

As a consequence, the package name cannot be parsed and submitted to
be automatically build. Please modify the ticket summary and trigger a
build by typing [fedora-review-service-build].

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2358883] Review Request: rust-bitfield-struct0.7 - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Luigi Leonardi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
            Summary|Review Request:             |Review Request:
                   |rust-bitfield-struct0.7-    |rust-bitfield-struct0.7 -
                   |Struct-like procedural      |Struct-like procedural
                   |macro for bit-fields        |macro for bit-fields

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Luigi Leonardi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |rust-bitfield-struct0.7 -   |rust-bitfield-struct -
                   |Struct-like procedural      |Struct-like procedural
                   |macro for bit-fields        |macro for bit-fields

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

--- Comment #2 from Luigi Leonardi  ---
[fedora-review-service-build]

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged
                URL|                            |https://crates.io/crates/bi
                   |                            |tfield-struct

--- Comment #3 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8886802
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Luigi Leonardi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Cole Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Cole Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(osteffen@redhat.c
                   |                            |om)
             Status|NEW                         |ASSIGNED

--- Comment #4 from Cole Robinson  ---
The spec file you linked to has rpmautospec boilerplate stuff in it. Compare it
to plain output of `rust2rpm bitfield-struct@0.7.0`. I think all the extra
stuff is what's added at .src.rpm build time and shouldn't be in the spec you
submit for review, or eventually commit to git.

rawhide build is failing:

DEBUG util.py:459:  Problem 1: nothing provides requested
(crate(endian-num/default) >= 0.1.0 with crate(endian-num/default) < 0.2.0~)
DEBUG util.py:459:   Problem 2: nothing provides requested
(crate(endian-num/linux-types) >= 0.1.0 with crate(endian-num/linux-types) <
0.2.0~)

looks like osteffen just did a build recently bumping fedora rust-endian-num
from 0.1 to 0.2. https://koji.fedoraproject.org/koji/buildinfo?buildID=2696494

@[e-mail] was that for something svsm related?

Maybe we have to relax the version check for rust-bitfield-struct and see if it
can build with rust-endian-num 0.2

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

--- Comment #5 from Luigi Leonardi  ---
Spec URL:
https://gitlab.com/luigileonardi/bitfield-struct/-/raw/master/rust-bitfield-...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/lleonard/sev-snp-coconut/...

Thanks Cole for the review!
I updated the spec file, there should be no boilerplate in here. As you
suggested I switched to rust-endiam-num 0.2

I renamed it to 0.7 because there is another review request for version 0.10.

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

--- Comment #6 from Fedora Review Service  ---
Created attachment 2085039
  --> https://bugzilla.redhat.com/attachment.cgi?id=2085039&action=edit
The .spec file difference from Copr build 8886802 to 8905784

[Bug 2358883] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

--- Comment #7 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8905784
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2358883] Review Request: rust-bitfield-struct0.7 - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Cole Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |rust-bitfield-struct -      |rust-bitfield-struct0.7 -
                   |Struct-like procedural      |Struct-like procedural
                   |macro for bit-fields        |macro for bit-fields

[Bug 2358883] Review Request: rust-bitfield-struct0.7 - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Cole Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(osteffen@redhat.c |needinfo?(decathorpe@gmail.
                   |om)                         |com)
                 CC|                            |[e-mail]

--- Comment #8 from Cole Robinson  ---
This looks ok to me. One small tweak: add a comment before the `Patch:`
documenting what changed (the rust-endian-num adjustment)

+ spec matches `rust2rpm bitfield-struct@0.7` output, with `Name:` change and
metadata tweak
+ Builds on rawhide
+ Installs on rawhide
+ content looks fine

But I've never reviewed a rust compat crate before. @[e-mail] can
you double check this for me? Is there anything I'm missing re: rust compat
packages?

[Bug 2358883] Review Request: rust-bitfield-struct0.7 - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(decathorpe@gmail. |
                   |com)                        |

--- Comment #9 from Fabio Valentini  ---
> spec matches `rust2rpm bitfield-struct@0.7` output, with `Name:` change and metadata tweak

For compat packages, use `rust2rpm bitfield-struct@0.7 --compat` instead, it
will do those things automatically.

The only thing that would currently block adding this package to Fedora is that
versioned compat packages are only allowed as alternatives for existing
packages, but rust-bitfield-struct is not a package in Fedora yet.

So either

1) This package would be reviewed as a non-compat package for 0.7 and is later
updated to 0.10 and a compat package for 0.7 is added, or
2) The non-compat / 0.10 version package review
(https://bugzilla.redhat.com/show_bug.cgi?id=2359067) needs to be done first
and imported to Fedora, and then this can proceed as planned.

Indeed if 2) happens, no package review is necessary at all -- compat packages
do not require package re-reviews.

But as-is, it would not be allowed to import this versioned / compat package
without having the un-versioned non-compat package present.

[Bug 2358883] Review Request: rust-bitfield-struct0.7 - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

--- Comment #10 from Fabio Valentini  ---
That said, do you *really* need version 0.7 of bitfield-struct, or could you
patch what you're working on to build with version 0.10?

Patches like that are usually gladly accepted by upstream projects, and it's
better to not create too many compat packages, they just create additional
maintenance burden for versions of crates that are almost always no longer
maintained upstream.

[Bug 2358883] Review Request: rust-bitfield-struct0.7 - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

--- Comment #12 from Luigi Leonardi  ---
> That said, do you *really* need version 0.7 of bitfield-struct, or could you patch what you're working on to build with version 0.10?
> Patches like that are usually gladly accepted by upstream projects, and it's better to not create too many compat packages, they just create additional maintenance burden for versions of crates that are almost always no longer maintained upstream.

Upstream igvm is already using version 0.10, but has not been released yet.
SVSM, on the other hand, is using 0.6.2 but bumping the version seems to work
just fine. So yes, we can use 0.10 directly and I guess we can close this
review request.

Thanks everybody for the feedback!

[Bug 2358883] Review Request: rust-bitfield-struct0.7 - Struct-like procedural macro for bit-fields

https://bugzilla.redhat.com/show_bug.cgi?id=2358883

Luigi Leonardi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTABUG
             Status|ASSIGNED                    |CLOSED
        Last Closed|                            |2025-04-16 09:57:40