Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226510
Summary: Merge Review: udev Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: harald@redhat.com
Fedora Merge Review: udev
http://cvs.fedora.redhat.com/viewcvs/devel/udev/ Initial Owner: harald@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: udev
https://bugzilla.redhat.com/show_bug.cgi?id=226510
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |426387 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: udev
https://bugzilla.redhat.com/show_bug.cgi?id=226510
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |limb@jcomserv.net Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From limb@jcomserv.net 2008-01-29 09:53 EST ------- rpmlint on srpm: udev.src: W: strange-permission start_udev 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions.
Not a problem.
rpmlint on rpms:
udev.i386: E: script-without-shebang /lib/udev/rule_generator.functions This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.
Should be fixed.
udev.i386: W: symlink-should-be-relative /usr/bin/udevtest /sbin/udevadm Absolute symlinks are problematic eg. when working with chroot environments.
udev.i386: W: symlink-should-be-relative /usr/sbin/udevmonitor /sbin/udevadm Absolute symlinks are problematic eg. when working with chroot environments.
udev.i386: W: symlink-should-be-relative /usr/bin/udevinfo /sbin/udevadm Absolute symlinks are problematic eg. when working with chroot environments.
Not a problem.
udev.i386: W: non-conffile-in-etc /etc/modprobe.d/floppy-pnp A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.
udev.i386: W: conffile-without-noreplace-flag /etc/udev/makedev.d/50-udev.nodes A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/05-udev-early.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/40-alsa.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/40-redhat.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/50-udev-default.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-cdrom_id.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-persistent-input.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-persistent-storage-tape.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-persistent-storage.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/61-persistent-storage-edd.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/64-device-mapper.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/64-md-raid.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/75-cd-aliases-generator.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/75-persistent-net-generator.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/80-drivers.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/95-pam-console.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/95-udev-late.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
These should be OK, provided there is a place to create persistent rules.
udev.i386: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
Fine.
udev.i386: E: unknown-lsb-keyword # Requires: $local_fs udev.i386: E: missing-mandatory-lsb-keyword Provides in /etc/rc.d/init.d/udev-post The package contains an init script that does not contain one of the LSB comment block convention keywords that are mandatory.
udev.i386: E: missing-mandatory-lsb-keyword Description in /etc/rc.d/init.d/udev-post The package contains an init script that does not contain one of the LSB comment block convention keywords that are mandatory.
udev.i386: E: missing-mandatory-lsb-keyword Short-Description in /etc/rc.d/init.d/udev-post The package contains an init script that does not contain one of the LSB comment block convention keywords that are mandatory.
Should be fixed.
udev.i386: E: no-status-entry /etc/rc.d/init.d/udev-post In your init script (/etc/rc.d/init.d/your_file), you don't have a 'status' entry, which is necessary for good functionality.
udev.i386: W: no-reload-entry /etc/rc.d/init.d/udev-post In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality.
Should be fixed.
udev.i386: E: subsys-not-used /etc/rc.d/init.d/udev-post While your daemon is running, you have to put a lock file in /var/lock/subsys/. To see an example, look at this directory on your machine and examine the corresponding init scripts.
Should be fixed.
udev.i386: W: incoherent-init-script-name udev-post The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name.
Probably not a problem.
Has a .pc file, must Requires: pkgconfig.
Other wise it looks good, no other blockers.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: udev
https://bugzilla.redhat.com/show_bug.cgi?id=226510
------- Additional Comments From limb@jcomserv.net 2008-01-29 10:34 EST ------- One problem, in mock build: /usr/bin/ld: cannot find -lselinux
Already BRs libselinux-devel and libsepol-devel, not sure what the problem is, will attach full build.log.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: udev
https://bugzilla.redhat.com/show_bug.cgi?id=226510
------- Additional Comments From limb@jcomserv.net 2008-01-29 10:36 EST ------- Created an attachment (id=293293) --> (https://bugzilla.redhat.com/attachment.cgi?id=293293&action=view) Mock buildlog.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: udev
https://bugzilla.redhat.com/show_bug.cgi?id=226510
------- Additional Comments From limb@jcomserv.net 2008-05-16 11:06 EST ------- Any updates?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2008-09-09 14:06:52 EDT --- reviewed curret rawhide SRPM:
rpmlint on SRPM:
udev.src:328: E: files-attr-not-set A file or a directory entry in a %files section does not have attributes set which may result in security issues in the resulting binary package depending on the system where the package is built. Add default attributes using %defattr before it in the %files section, or use per line %attr's.
udev.src:340: E: files-attr-not-set A file or a directory entry in a %files section does not have attributes set which may result in security issues in the resulting binary package depending on the system where the package is built. Add default attributes using %defattr before it in the %files section, or use per line %attr's.
udev.src:344: E: files-attr-not-set A file or a directory entry in a %files section does not have attributes set which may result in security issues in the resulting binary package depending on the system where the package is built. Add default attributes using %defattr before it in the %files section, or use per line %attr's.
udev.src: W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 136) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
on RPMS:
libudev0.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
libudev-devel.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
libudev-devel.i386: W: no-dependency-on libudev/libudev-libs/liblibudev udev.i386: W: conffile-without-noreplace-flag /etc/modprobe.d/floppy-pnp A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: conffile-without-noreplace-flag /etc/udev/makedev.d/50-udev.nodes A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/40-alsa.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/40-alsa.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/40-redhat.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/40-redhat.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/50-udev-default.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/50-udev-default.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/60-cdrom_id.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/60-cdrom_id.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/60-persistent-input.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/60-persistent-input.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/60-persistent-storage-tape.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/60-persistent-storage-tape.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/60-persistent-storage.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/60-persistent-storage.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/60-persistent-v4l.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/60-persistent-v4l.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/61-persistent-storage-edd.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/61-persistent-storage-edd.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/64-device-mapper.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/64-device-mapper.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/64-md-raid.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/64-md-raid.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/75-cd-aliases-generator.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/75-cd-aliases-generator.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/75-persistent-net-generator.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/75-persistent-net-generator.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/79-fstab_import.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/79-fstab_import.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/80-drivers.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/80-drivers.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/95-pam-console.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/95-pam-console.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: non-etc-or-var-file-marked-as-conffile /lib/udev/rules.d/95-udev-late.rules A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var.
udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/95-udev-late.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.i386: W: dangerous-command-in-%trigger rm udev.i386: W: dangerous-command-in-%trigger rm udev.i386: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
udev.i386: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
udev.i386: W: incoherent-init-script-name udev-post The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name.
See the above issues as well.
Working on a new mock build. . .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2008-09-09 14:19:27 EDT --- Mock build/BRs OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2008-12-04 14:33:03 EDT --- Ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #8 from Harald Hoyer harald@redhat.com 2008-12-22 04:13:09 EDT --- rpmlint with udev-135-3 of rawhide:
udev.x86_64: W: conffile-without-noreplace-flag /etc/modprobe.d/floppy-pnp A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
udev.x86_64: W: dangerous-command-in-%trigger rm udev.x86_64: W: dangerous-command-in-%trigger rm udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
udev.x86_64: W: incoherent-init-script-name udev-post The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name.
libudev-devel.x86_64: W: no-dependency-on libudev/libudev-libs/liblibudev 7 packages and 0 specfiles checked; 0 errors, 7 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #9 from Harald Hoyer harald@redhat.com 2008-12-22 04:14:31 EDT --- (In reply to comment #8)
rpmlint with udev-135-3 of rawhide:
udev.x86_64: W: conffile-without-noreplace-flag /etc/modprobe.d/floppy-pnp A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
bogus
udev.x86_64: W: dangerous-command-in-%trigger rm udev.x86_64: W: dangerous-command-in-%trigger rm
bogus
udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
bogus
udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
bogus
udev.x86_64: W: incoherent-init-script-name udev-post The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name.
bogus
libudev-devel.x86_64: W: no-dependency-on libudev/libudev-libs/liblibudev 7 packages and 0 specfiles checked; 0 errors, 7 warnings.
bogus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #10 from Jon Ciesla limb@jcomserv.net 2008-12-29 10:29:40 EDT --- Can you comment in the spec, or even here, on why these are bogus?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #11 from Harald Hoyer harald@redhat.com 2009-01-08 09:05:21 EDT ---
rpmlint with udev-135-3 of rawhide:
udev.x86_64: W: conffile-without-noreplace-flag /etc/modprobe.d/floppy-pnp A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here
this file contains an alias which is missing in the kernel
udev.x86_64: W: dangerous-command-in-%trigger rm udev.x86_64: W: dangerous-command-in-%trigger rm
rm is really needed
udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
this service is _always_ needed
udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
this service is _always_ needed
udev.x86_64: W: incoherent-init-script-name udev-post The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name.
ok, I screwed up, when I named the service
libudev-devel.x86_64: W: no-dependency-on libudev/libudev-libs/liblibudev 7 packages and 0 specfiles checked; 0 errors, 7 warnings.
the devel package depends on libudev0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #12 from Jon Ciesla limb@jcomserv.net 2009-01-08 09:12:48 EDT --- Ok, I'd put comments on these in the spec, with the exception of service-enabled-default, for which you should file a bug against rpmlint for an exception.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #13 from Jon Ciesla limb@jcomserv.net 2009-03-31 11:28:52 EDT --- Ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mnowak@redhat.com Flag| |needinfo?(harald@redhat.com | |)
--- Comment #14 from Michal Nowak mnowak@redhat.com 2009-04-09 10:01:46 EDT --- * udev.src: W: strange-permission start_udev 0755
Not that common to ship SourceX files with exec perms, but installed via 0755, so, OK.
* udev.src: W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 104)
Easy stuff.
* udev.x86_64: E: binary-or-shlib-defines-rpath /lib/udev/vol_id ['/lib64']
Rpath is blocker in review, even such common path, fix it, please. https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath
* udev.x86_64: W: conffile-without-noreplace-flag /etc/modprobe.d/floppy-pnp.conf
Sure, this is in /etc but not expected to be changed by user but in spec file is expected to note, why you don't have %config(noreplace), see https://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files That's what Jon asked for.
* udev.x86_64: W: dangerous-command-in-%trigger rm * udev.x86_64: W: dangerous-command-in-%trigger rm
OK.
* udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post * udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post
Clear.
* udev.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/udev-post
Easy to fix, but somewhat useless.
* udev.x86_64: W: incoherent-init-script-name udev-post
Will you fix it to "udev", or what was the resolution?
* libudev-devel.x86_64: W: no-dependency-on libudev/libudev-libs/liblibudev
Bad guess, rpmlint. OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
Harald Hoyer harald@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(harald@redhat.com | |) |
--- Comment #15 from Harald Hoyer harald@redhat.com 2009-07-24 04:23:04 EDT --- next round, rawhide udev-145-2:
$ rpmlint udev.spec udev-145-2.fc12.src.rpm x86_64/*145-2* udev.spec:315: E: hardcoded-library-path in %{_prefix}/lib/ConsoleKit/run-session.d/udev-acl.ck
ConsoleKit lives there $ rpm -qf /usr/lib/ConsoleKit ConsoleKit-0.3.0-8.fc11.x86_64
udev.src: W: strange-permission start_udev 0755
should be ok
udev.src:315: E: hardcoded-library-path in %{_prefix}/lib/ConsoleKit/run-session.d/udev-acl.ck
see above
udev.x86_64: W: only-non-binary-in-usr-lib
well, it's a symlink
$ rpm -qplv x86_64/udev-145-2.fc12.x86_64.rpm |fgrep usr/lib lrw-r--r-- 1 root root 18 Jul 24 10:18 /usr/lib/ConsoleKit/run-session.d/udev-acl.ck -> /lib/udev/udev-acl
udev.x86_64: W: dangerous-command-in-%trigger rm udev.x86_64: W: dangerous-command-in-%trigger rm
OK
udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post
It has to be.
udev.x86_64: W: incoherent-init-script-name udev-post ('udev', 'udevd') 7 packages and 1 specfiles checked; 2 errors, 7 warnings.
I will not change it. It does not start udev or udevd. It's the same name as in other distributions.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #16 from Jon Ciesla limb@jcomserv.net 2009-07-27 15:24:45 EDT --- In attempting to take a look at this, I ran across:
checking for USBUTILS... configure: error: Package requirements (usbutils >= 0.82) were not met:
Looks like the BuildRequires should be versioned.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #17 from Jon Ciesla limb@jcomserv.net 2010-04-29 16:10:50 EDT --- Ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #18 from Jon Ciesla limb@jcomserv.net 2011-03-31 12:40:46 EDT --- Ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #19 from Harald Hoyer harald@redhat.com 2011-03-31 12:52:15 EDT --- (In reply to comment #16)
In attempting to take a look at this, I ran across:
checking for USBUTILS... configure: error: Package requirements (usbutils >= 0.82) were not met:
Looks like the BuildRequires should be versioned.
done...
$ grep usbutils udev.spec BuildRequires: usbutils >= 0.82
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #20 from Jon Ciesla limb@jcomserv.net 2011-03-31 13:20:21 EDT --- Cool, thanks!
Starting over on current rawhide SRPM:
udev.src:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 182) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
udev.src: W: invalid-url Source0: ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 <urlopen error ftp error: [Errno 111] Connection refused> The value should be a valid, public HTTP, HTTPS, or FTP URL.
These are the only things not addressed above.
These are new, and I'm imagining are ok:
udev.i686: W: devel-file-in-non-devel-package /usr/share/pkgconfig/udev.pc A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
udev.i686: W: cross-directory-hard-link /etc/udev/makedev.d /var/lib/udev File is hard linked across directories. This can cause problems in installations where the directories are located on different devices.
udev.i686: W: no-manual-page-for-binary start_udev Each executable in standard binary directories should have a man page.
Otherwise, it looks good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #21 from Harald Hoyer harald@redhat.com 2011-04-01 03:38:50 EDT --- (In reply to comment #20)
Cool, thanks!
Starting over on current rawhide SRPM:
udev.src:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 182) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
right.. will fix!
udev.src: W: invalid-url Source0: ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 <urlopen error ftp error: [Errno 111] Connection refused> The value should be a valid, public HTTP, HTTPS, or FTP URL.
huh? loads fine!
$ wget ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 --2011-04-01 09:39:27-- ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 => `udev-167.tar.bz2.1' Resolving ftp.kernel.org... 130.239.17.4, 199.6.1.164 Connecting to ftp.kernel.org|130.239.17.4|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD (1) /pub/linux/utils/kernel/hotplug ... done. ==> SIZE udev-167.tar.bz2 ... 594474 ==> PASV ... done. ==> RETR udev-167.tar.bz2 ... done. Length: 594474 (581K) (unauthoritative) ....
These are the only things not addressed above.
These are new, and I'm imagining are ok:
udev.i686: W: devel-file-in-non-devel-package /usr/share/pkgconfig/udev.pc A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
yes, that's needed
udev.i686: W: cross-directory-hard-link /etc/udev/makedev.d /var/lib/udev File is hard linked across directories. This can cause problems in installations where the directories are located on different devices.
huh?
# Deprecated, but keep the ownership %ghost %dir /var/lib/udev %ghost %dir %{_sysconfdir}/udev/makedev.d/
udev.i686: W: no-manual-page-for-binary start_udev Each executable in standard binary directories should have a man page.
that's ok, nobody should use it
Otherwise, it looks good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #22 from Jon Ciesla limb@jcomserv.net 2011-04-04 14:57:12 EDT --- Ok, once the space/tab thing is fixed, I'm good. The rest is justified, I think, and the source URL was apparently a fluke, because it works for me now and the md5sum matches.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #23 from Harald Hoyer harald@redhat.com 2011-04-06 04:53:47 EDT --- (In reply to comment #22)
Ok, once the space/tab thing is fixed, I'm good. The rest is justified, I think, and the source URL was apparently a fluke, because it works for me now and the md5sum matches.
already "untabify"ied in git master.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #24 from Jon Ciesla limb@jcomserv.net 2011-04-06 08:55:12 EDT --- Did you push the changes?
udev.spec:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 182) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
[limb@bamboo udev]$ git log commit 8df68695ff06d05f52b7187c24fa27969a5036c5 Merge: 0b0304c 58624e4 Author: Harald Hoyer harald@redhat.com Date: Thu Mar 31 18:32:08 2011 +0200
Merge branch 'f15/master'
commit 58624e426ed9b5d2b26f4a428cdc5cb8e4e6d4bf Author: Harald Hoyer harald@redhat.com Date: Thu Mar 31 18:30:08 2011 +0200
udev.spec: removed gtk-doc
commit cbf7ac132cb5c8c9c7169c763df6714c5ad45b17 Author: Harald Hoyer harald@redhat.com Date: Wed Mar 30 17:36:11 2011 +0200
removed libxslt buildreq and touch man pages, to prevent rebuild
commit 8cf0c7defa5e033369d66ac319ed380c3fe73882 Author: Harald Hoyer harald@redhat.com Date: Thu Mar 31 17:58:51 2011 +0200
- fixed udev-trigger.service
commit 0b0304cfe18782b99aaa0814f9610d7ec91fcc2b Author: Harald Hoyer harald@redhat.com Date: Thu Mar 31 17:58:51 2011 +0200
- fixed udev-trigger.service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
--- Comment #25 from Harald Hoyer harald@redhat.com 2011-04-08 04:05:01 EDT --- (In reply to comment #24)
Did you push the changes?
oops .. done :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |ERRATA Flag|fedora-review? |fedora-review+ Last Closed| |2011-04-08 08:59:22
--- Comment #26 from Jon Ciesla limb@jcomserv.net 2011-04-08 08:59:22 EDT --- Ah, there we are. Thanks so much!
APPROVED.
package-review@lists.fedoraproject.org