[Bug 1230149] New: Review Request: zathura-pdf-mupdf - PDF support for zathura via mupdf
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
Bug ID: 1230149 Summary: Review Request: zathura-pdf-mupdf - PDF support for zathura via mupdf Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: psabata@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://psabata.fedorapeople.org/pkgs/zathura-pdf-mupdf/zathura-pdf-mupdf.sp... SRPM URL: https://psabata.fedorapeople.org/pkgs/zathura-pdf-mupdf/zathura-pdf-mupdf-0.... Description: This plugin adds PDF support to zathura using the mupdf rendering engine. Fedora Account System Username: psabata
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1095455
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
tuxor tuxor1337@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tuxor1337@web.de
--- Comment #1 from tuxor tuxor1337@web.de --- You are listing `%{_libdir}/zathura/pdf.so.mupdf` twice (as %ghost and as an ordinary file). I suppose you want to list `%{_libdir}/zathura/pdf.so` as %ghost instead of `%{_libdir}/zathura/pdf.so.mupdf`.
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
--- Comment #2 from Petr Šabata psabata@redhat.com --- You're right, thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
--- Comment #3 from Petr Šabata psabata@redhat.com --- Spec URL: https://psabata.fedorapeople.org/pkgs/zathura-pdf-mupdf/zathura-pdf-mupdf.sp... SRPM URL: https://psabata.fedorapeople.org/pkgs/zathura-pdf-mupdf/zathura-pdf-mupdf-0....
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in zathura-pdf-mupdf See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database
Looks reasonable. I assume that you know what you are doing with the alternatives here.
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
--- Comment #5 from Petr Šabata psabata@redhat.com --- Thanks, updated. I'll fix the rest of our affected zathura plugins, too.
SPEC: https://psabata.fedorapeople.org/pkgs/zathura-pdf-mupdf/zathura-pdf-mupdf.sp... SRPM: https://psabata.fedorapeople.org/pkgs/zathura-pdf-mupdf/zathura-pdf-mupdf-0....
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- OK, looks good, and seems to work (pdf loads :)).
One issue: nothing owns /usr/lib64/zathura. Since all plugin packages depend on zathura, I think it would be best for zathura.rpm to own this directory.
[x] OK [-] not applicable [!] issue
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. OK.
[x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /var/tmp/1230149-zathura-pdf- mupdf/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/zathura [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/zathura See above.
[x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in zathura-pdf-mupdf [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Rpmlint ------- Checking: zathura-pdf-mupdf-0.2.8-3.fc23.x86_64.rpm zathura-pdf-mupdf-0.2.8-3.fc23.src.rpm zathura-pdf-mupdf.x86_64: W: desktopfile-without-binary /usr/share/applications/zathura-pdf-mupdf.desktop zathura 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (debuginfo) ------------------- Checking: zathura-pdf-mupdf-debuginfo-0.2.8-3.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
--- Comment #7 from Petr Šabata psabata@redhat.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
OK, looks good, and seems to work (pdf loads :)).
One issue: nothing owns /usr/lib64/zathura. Since all plugin packages depend on zathura, I think it would be best for zathura.rpm to own this directory.
Yes, that would be reasonable.
Package is APPROVED.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Petr Šabata psabata@redhat.com --- New Package SCM Request ======================= Package Name: zathura-pdf-mupdf Short Description: PDF support for zathura via mupdf Upstream URL: http://pwmt.org/projects/zathura/plugins/zathura-pdf-mupdf Owners: psabata Branches: InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1230149
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |zathura-pdf-mupdf-0.2.8-3.f | |c23 Resolution|--- |RAWHIDE Last Closed| |2015-07-03 04:33:17
--- Comment #10 from Petr Šabata psabata@redhat.com --- Package built in Rawhide. Thanks.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla