https://bugzilla.redhat.com/show_bug.cgi?id=1361672
Bug ID: 1361672 Summary: Review Request: python-fmn-sse - allows fedora users to view their fedmsg feed in realtime Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: skrzepto@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/fedora-infra/fmn.sse/master/python-fmn-sse... SRPM URL: https://github.com/fedora-infra/fmn.sse/blob/fedora_pkg_review/python-fmn-ss... Description: FMN is a family of systems to manage end-user notifications triggered by fedmsg, the Fedora Federated Message bus.FMN.SSE allows fedora users to view their fedmsg feed in realtime. Fedora Account System Username: skrzepto
https://bugzilla.redhat.com/show_bug.cgi?id=1361672
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The Summary is good, but the %description is a bit lacking: after reading it, I still don't know *what* this package does... I think you should spell it out in simple words.
No need to define %sum: just write the first Summary in full, and then you can refer to that text as %summary.
License tag needs a specific version for GPL. It needs to be one of the "short names" in https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses.
.egg-info doesn't need to be removed [https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...].
It doesn't work with python3? It would be nicer to package it as a Python3 application if possible.
I think that systemd-devel is probably not required. It is only used to compile C programs linked with the systemd libs.
python-fmn-sse.noarch: W: incoherent-version-in-changelog 0.1 ['0.1.0-1.fc24', '0.1.0-1'] python-fmn-sse.noarch: W: summary-ended-with-dot C FMN.SSE allows fedora users to view their fedmsg feed in realtime.
About the service file: the service most likely shouldn't run as root. Running a network-facing web server with full privileges is crazy. You should add a dedicated user (fmn-sse or similar) in %pre.
--
OK, after reading the spec and looking at the files, the biggest issues are: - can you provide a better overview in %description what the intent of this package is, this will make further review easier. - there needs to be some instructions how to enable the service. In particular I have no idea what the instance argument to the template should be. - the service should run with reduced privileges.
package-review@lists.fedoraproject.org