https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Bug ID: 2223081 Summary: Review Request: python-pyasyncore - Python module asyncore for Python 3.12 onwards Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: terje.rosten@ntnu.no QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://terjeros.fedorapeople.org/python-pyasyncore/python-pyasyncore.spec srpm: https://terjeros.fedorapeople.org/python-pyasyncore/python-pyasyncore-1.0.2-... desc: This package contains the asyncore module as found in Python versions prior to 3.12. It is provided so that existing code relying on import asyncore is able to continue being used without significant refactoring. koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=103392708 user: terjeros
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Terje Røsten terje.rosten@ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2219556
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2219556 [Bug 2219556] python-inotify doesn't work: imports asyncore removed in Python 3.12
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/simonrob | |/pyasyncore
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6174936 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Terje Røsten terje.rosten@ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Terje Røsten terje.rosten@ntnu.no --- spec: https://terjeros.fedorapeople.org/python-pyasyncore/python-pyasyncore.spec srpm: https://terjeros.fedorapeople.org/python-pyasyncore/python-pyasyncore-1.0.2-...
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1975911 --> https://bugzilla.redhat.com/attachment.cgi?id=1975911&action=edit The .spec file difference from Copr build 6174936 to 6174982
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6174982 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Pavel Raiskup praiskup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |praiskup@redhat.com
--- Comment #5 from Pavel Raiskup praiskup@redhat.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6233580 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
--- Comment #7 from Pavel Raiskup praiskup@redhat.com --- Don't you want to start with the `pyp2spec pyasyncore` template, according to the latest Python guidelines? https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Troy Curtis troy@troycurtisjr.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |troy@troycurtisjr.com
--- Comment #8 from Troy Curtis troy@troycurtisjr.com --- Also the license field should use the SPDX format: PSF-2.0
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Christian Stadelmann fedora@genodeftest.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@genodeftest.de
--- Comment #9 from Christian Stadelmann fedora@genodeftest.de --- The package is available now: https://packages.fedoraproject.org/pkgs/python-pyasyncore/python3-pyasyncore...
Does this mean that this bug can be closed?
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Terje Røsten terje.rosten@ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |CLOSED Last Closed| |2023-12-17 21:19:40
--- Comment #10 from Terje Røsten terje.rosten@ntnu.no --- Closed as dup of #2241084. I guess Adam forgot to search current package reviews.
*** This bug has been marked as a duplicate of bug 2241084 ***
https://bugzilla.redhat.com/show_bug.cgi?id=2223081
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@redhat.com
--- Comment #11 from Adam Williamson awilliam@redhat.com --- Sorry, I thought I did but I guess not!
package-review@lists.fedoraproject.org