https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Bug ID: 2103477 Summary: Review Request: rust-normapath - More reliable path manipulation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zbyszek@in.waw.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath-0.3.2-1.fc37.src.rpm Description: %summary Fedora Account System Username: zbyszek
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2027038 Doc Type|--- |If docs needed, set a value
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- This needs print_bytes>=0.4, which we apparently don't have.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2027038 [Bug 2027038] rust-fd-find-8.4.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2103480
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2103480 [Bug 2103480] Review Request: rust-print_bytes - Print bytes as losslessly as possible
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gotmax@e.email
--- Comment #2 from Maxwell G gotmax@e.email --- According to upstream's README:
### Third-party software
This crate includes copies and modifications of software developed by third parties:
- [src/cmp.rs] and [tests/rust.rs] contain modifications of code from The Rust Programming Language, licensed under the MIT License or the Apache License, Version 2.0.
- [src/common/localize/macos/fruity.rs] contains modifications of code from crate [fruity], licensed under the MIT License or the Apache License, Version 2.0.
See those files for more details.
Copies of third-party licenses can be found in [LICENSE-THIRD-PARTY].
I suppose these should have virtual Provides for `bundled(crate(fruity))` and `bundled(rust)`. The file headers have what commit hashes they were originally taken from, so you could use those as the version. The Rust Packaging Guidelines explicitly allow[1] bundling in this case.
[1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_bundled_dep...
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath-0.3.2-1.fc37.src.rpm Description: More reliable path manipulation. Fedora Account System Username: zbyszek
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Maxwell G from comment #2)
- [src/cmp.rs] and [tests/rust.rs] contain modifications of code from The
Rust Programming Language, licensed under the MIT License or the Apache License, Version 2.0.
I added Provides:bundled(rust) for this.
- [src/common/localize/macos/fruity.rs] contains modifications of code from crate [fruity], licensed under the MIT License or the Apache License, Version 2.0.
This is only in git, the released version doesn't have it yet.
Thanks. Updated versions: Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath-0.3.2-2.fc37.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rust-normapath - More |rust-normpath - More |reliable path manipulation |reliable path manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=2103477 Bug 2103477 depends on bug 2103480, which changed state.
Bug 2103480 Summary: Review Request: rust-print_bytes - Print bytes as losslessly as possible https://bugzilla.redhat.com/show_bug.cgi?id=2103480
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(gotmax@e.email) CC| |decathorpe@gmail.com
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Hi Maxwell, do you want to proceed with the review, or should I take it over?
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(gotmax@e.email) |
--- Comment #5 from Maxwell G gotmax@e.email --- Feel free to just take it over. I deliberately didn't assign it to myself.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review+
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
Two minor issues / warnings:
- If you're patching the print_bytes dependency, either bump it to plain "0.6" (which is what you have packaged), or, if you want to stay compatible with what upstream does, use ">=0.4,<0.7" instead.
Using open-ended ">=0.4" is slightly dangerous, because it is compatible with *any* version higher than 0.4, which is probably not what you want (and which will also lead to very confusing error messages if the print_bytes crate ever changes its APIs).
- Make sure that you import the correct files into dist-git. The linked SRPM is already mangled by rpmautospec for some reason.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zbyszek@in.waw.pl | |)
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- The repository for this package was created some time ago: https://src.fedoraproject.org/rpms/rust-normpath
Looks like fedscm-admin just bugged out, didn't push an initial commit, and didn't comment here. Please continue with importing the package.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Lumír Balhar lbalhar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lbalhar@redhat.com
--- Comment #8 from Lumír Balhar lbalhar@redhat.com --- *** Bug 2151234 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
--- Comment #9 from Fabio Valentini decathorpe@gmail.com --- https://pagure.io/fedora-infrastructure/issue/11035
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-856ea9cc50 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-856ea9cc50
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-856ea9cc50 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-856ea9cc50
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e38d8e2bfe has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e38d8e2bfe
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-856ea9cc50 has been pushed to the Fedora EPEL 9 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-856ea9cc50
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b8692f75ba has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b8692f75ba *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b8692f75ba
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e38d8e2bfe has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e38d8e2bfe *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e38d8e2bfe
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-01-22 01:41:55
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b8692f75ba has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e38d8e2bfe has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-856ea9cc50 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zbyszek@in.waw.pl | |) |
package-review@lists.fedoraproject.org