[Bug 197189] New: Review Request: fonts-sinhala

List overview All Threads
Download

newer

older

[Bug 226638] New: Merge Review:...

[Bug 226809] New: Merge Review:...

Red Hat Bugzilla

29 Jun 2006 29 Jun '06

6:25 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

Summary: Review Request: fonts-sinhala Product: Fedora Core Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: notting@redhat.com ReportedBy: llch@redhat.com QAContact: extras-qa@fedoraproject.org CC: eng-i18n-bugs@redhat.com,fedora-package- review@redhat.com

Spec URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala.spec SRPM URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala-0.2-1.src.rpm Packge Owner: dsantani@redhat.com Description: An essential font for Sinhala language for FC6. Size: noarch = 107k; SRPMS = 105k

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

29 Jun 29 Jun

6:43 a.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

------- Additional Comments From notting@redhat.com 2006-06-29 00:34 EST ------- Translations for this locale seem woefully incomplete. Aside from that, sounds OK.

Red Hat Bugzilla

5 Jul 5 Jul

8:45 a.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

llch@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jkeating@redhat.com

------- Additional Comments From llch@redhat.com 2006-07-05 02:36 EST ------- Jesse, please review and would be great to add the component.

Red Hat Bugzilla

12:38 p.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

------- Additional Comments From paskalis@di.uoa.gr 2006-07-05 06:29 EST ------- Some comments regarding the spec file:

...

BuildRoot: %{_tmppath}/%{name}-root

Please use the recommended BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

...

Prereq: fontconfig

This is not necessary in font packages, since they could be installed in systems without fontconfig. See a policy explanation in http://www.redhat.com/archives/fedora-extras-list/2005-May/msg00887.html Moreover, provisions are made in the spec file to check the presense of fc-cache before running it.

...

# %%ghost the fonts.cache-1 file touch $RPM_BUILD_ROOT%{_datadir}/fonts/sinhala/fonts.cache-1 %ghost %{_datadir}/fonts/sinhala/fonts.cache-1

This is not necessary for fontconfig > 2.3.93, i.e. for FC>=5. If this package is intended for Fedora >=5 only, ghosting this file is superfluous.

Red Hat Bugzilla

4:53 p.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

jkeating@redhat.com changed:

Red Hat Bugzilla

5:27 p.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

jkeating@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO_REPORTER

------- Additional Comments From jkeating@redhat.com 2006-07-05 11:18 EST ------- Other than the above comments, rpmlint has this to say:

W: fonts-sinhala wrong-file-end-of-line-encoding /usr/share/doc/fonts-sinhala-0.2/COPYING W: fonts-sinhala wrong-file-end-of-line-encoding /usr/share/doc/fonts-sinhala-0.2/license.txt

Those two files may have windows encoding or the like.

Fix that and the comments above and I'll be happy to approve this.

Red Hat Bugzilla

8 p.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

------- Additional Comments From notting@redhat.com 2006-07-05 13:52 EST ------- Do we have a plan in place to get translations for the desktops?

Red Hat Bugzilla

7 Jul 7 Jul

7:25 a.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

llch@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO_REPORTER |ASSIGNED

------- Additional Comments From llch@redhat.com 2006-07-07 01:17 EST ------- Thanks. It is updated. Jesse please approve:

Spec URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala.spec SRPM URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala-0.2-2.src.rpm Packge Owner: dsantani@redhat.com Description: An essential font for Sinhala language for FC6. Size: noarch = 107k; SRPMS = 105k

Red Hat Bugzilla

11 Jul 11 Jul

12:27 p.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

------- Additional Comments From paskalis@di.uoa.gr 2006-07-11 06:19 EST ------- The first and third issue (i.e. BuildRoot and superfluous %ghosting) are still in -2.

Red Hat Bugzilla

12 Jul 12 Jul

6:41 a.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

------- Additional Comments From llch@redhat.com 2006-07-12 00:32 EST ------- Jesse:

Spec URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala.spec SRPM URL: http://people.redhat.com/llch/fonts-sinhala/fonts-sinhala-0.2-3.src.rpm Packge Owner: dsantani@redhat.com Description: An essential font for Sinhala language for FC6. Size: noarch = 107k; SRPMS = 105k

Red Hat Bugzilla

13 Jul 13 Jul

5:55 a.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

jkeating@redhat.com changed:

------- Additional Comments From jkeating@redhat.com 2006-07-12 23:46 EST ------- Issues look resolved. RPMLINT is silent. Approving.

Adding to dist per notting's approval.

Red Hat Bugzilla

6:40 a.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

llch@redhat.com changed:

------- Additional Comments From llch@redhat.com 2006-07-13 00:31 EST ------- Thanks Jesse. Package is imported into cvs-dist and built in dist-fc6. But seems the owner should be dsantani@redhat.com instead.

Red Hat Bugzilla

3:10 p.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

------- Additional Comments From jkeating@redhat.com 2006-07-13 09:01 EST ------- fixed.

Red Hat Bugzilla

19 Jun 19 Jun

4:47 a.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-sinhala

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197189

bugzilla@redhat.com changed:

Red Hat Bugzilla

26 Sep 26 Sep

4:57 p.m.

New subject: [Bug 197189] Review Request: fonts-sinhala

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197189

Peter Lemenkov lemenkov@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |nobody@fedoraproject.org

--- Comment #13 from Peter Lemenkov lemenkov@gmail.com 2009-09-26 10:57:17 EDT --- *** Bug 226809 has been marked as a duplicate of this bug. ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5779

Age (days ago)

6964

Last active (days ago)

package-review@lists.fedoraproject.org

14 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla