12:55 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Bug ID: 2281985
Summary: Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
Product: Fedora
Version: rawhide
Status: NEW
Component: Package Review
Assignee: nobody(a)fedoraproject.org
Reporter: decathorpe(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-image-webp.spec
SRPM URL:
https://decathorpe.fedorapeople.org/rust-image-webp-0.1.2-1.fc40.src.rpm
Description:
WebP encoding and decoding in pure Rust.
Fedora Account System Username: decathorpe
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:55 p.m.
New subject: [Bug 2281985] Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
--- Comment #1 from Fabio Valentini <decathorpe(a)gmail.com> ---
This package built on koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=117955337
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
4:17 p.m.
New subject: [Bug 2281985] Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Fedora Review Service <fedora-review-bot(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://crates.io/crates/im
| |age-webp
--- Comment #2 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7467140
(failed)
Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network
unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
are listed in the "Depends On" field
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
2:37 p.m.
New subject: [Bug 2281985] Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Ben Beasley <code(a)musicinmybrain.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
CC| |code(a)musicinmybrain.net
Doc Type|--- |If docs needed, set a value
Assignee|nobody(a)fedoraproject.org |code(a)musicinmybrain.net
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
4:16 p.m.
New subject: [Bug 2281985] Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Ben Beasley <code(a)musicinmybrain.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Ben Beasley <code(a)musicinmybrain.net> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
The spec file is exactly as generated by rust2rpm without configuration,
greatly simplifying the review.
Issues:
=======
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/share/cargo/registry/image-
webp-0.1.2/LICENSE-APACHE
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
This is not a serious problem; if it should be fixed, then it should be fixed
in rust2rpm.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License
2.0",
"*No copyright* MIT License". 15 files have unknown license. Detailed
output of licensecheck in /home/ben/Downloads/review/2281985-rust-
image-webp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/cargo/registry, /usr/share/cargo,
/usr, /usr/share
This diagnostic is a fedora-review bug.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/cargo, /usr,
/usr/share, /usr/share/cargo/registry
This diagnostic is a fedora-review bug.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
image-webp-devel , rust-image-webp+default-devel
[x]: Package functions as described.
(tests pass)
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
https://koji.fedoraproject.org/koji/taskinfo?taskID=117955337
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: rust-image-webp-devel-0.1.2-1.fc41.noarch.rpm
rust-image-webp+default-devel-0.1.2-1.fc41.noarch.rpm
rust-image-webp-0.1.2-1.fc41.src.rpm
===========================================================================================
rpmlint session starts
==========================================================================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpk59h0vdt')]
checks: 32, packages: 3
rust-image-webp+default-devel.noarch: W: no-documentation
===================================================== 3 packages and 0
specfiles checked; 0 errors, 1 warnings, 12 filtered, 0 badness; has taken 0.2
s =====================================================
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2
rust-image-webp+default-devel.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0
badness; has taken 0.1 s
Source checksums
----------------
https://crates.io/api/v1/crates/image-webp/0.1.2/download#/image-webp-0.1...
:
CHECKSUM(SHA256) this package :
d730b085583c4d789dfd07fdcf185be59501666a90c97c40162b37e4fdad272d
CHECKSUM(SHA256) upstream package :
d730b085583c4d789dfd07fdcf185be59501666a90c97c40162b37e4fdad272d
Requires
--------
rust-image-webp-devel (rpmlib, GLIBC filtered):
(crate(byteorder-lite/default) >= 0.1.0 with crate(byteorder-lite/default)
< 0.2.0~)
(crate(thiserror/default) >= 1.0.47 with crate(thiserror/default) < 2.0.0~)
cargo
rust
rust-image-webp+default-devel (rpmlib, GLIBC filtered):
cargo
crate(image-webp)
Provides
--------
rust-image-webp-devel:
crate(image-webp)
rust-image-webp-devel
rust-image-webp+default-devel:
crate(image-webp/default)
rust-image-webp+default-devel
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2281985 --mock-options=--dnf
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: R, PHP, Haskell, Java, Python, C/C++, SugarActivity, Ocaml,
fonts, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:12 p.m.
New subject: [Bug 2281985] Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
--- Comment #4 from Fabio Valentini <decathorpe(a)gmail.com> ---
Thank you for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:13 p.m.
New subject: [Bug 2281985] Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
--- Comment #5 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org> ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-image-webp
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:40 p.m.
New subject: [Bug 2281985] Review Request: rust-image-webp - WebP encoding and
decoding in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Fixed In Version| |rust-image-webp-0.1.2-1.fc4
| |1
Resolution|--- |RAWHIDE
Last Closed| |2024-05-31 17:40:40
--- Comment #6 from Fabio Valentini <decathorpe(a)gmail.com> ---
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5737ed8b9f
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281985
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
3
days inactive
14
days old
package-review@lists.fedoraproject.org
7 comments
1 participants
participants (1)
-
bugzilla＠redhat.com