[Bug 1704312] New: Review Request: intel-undervolt - Intel CPU undervolting and throttling configuration tool
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
Bug ID: 1704312 Summary: Review Request: intel-undervolt - Intel CPU undervolting and throttling configuration tool Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ego.cordatus@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://atim.fedorapeople.org/for-review/intel-undervolt.spec SRPM URL: https://atim.fedorapeople.org/for-review/intel-undervolt-1.6-1.fc30.src.rpm
Description: intel-undervolt is a tool for undervolting and throttling limits alteration for Intel CPUs.
Undervolting works on Haswell and newer CPUs and based on the content of this article https://github.com/mihic/linux-intel-undervolt .
Fedora Account System Username: atim
Working COPR: https://copr.fedorainfracloud.org/coprs/atim/intel-undervolt
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Why?
%global debug_package %{nil}
You need to set Fedora default build flags:
%build %set_build_flags %make_build
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/intel- undervolt/review-intel-undervolt/licensecheck.txt [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: intel-undervolt-1.6-1.fc31.x86_64.rpm intel-undervolt-1.6-1.fc31.src.rpm intel-undervolt.x86_64: W: spelling-error Summary(en_US) undervolting -> undervaluing intel-undervolt.x86_64: W: spelling-error %description -l en_US undervolting -> undervaluing intel-undervolt.x86_64: W: spelling-error %description -l en_US Undervolting -> Undervaluing intel-undervolt.x86_64: W: unstripped-binary-or-object /usr/bin/intel-undervolt intel-undervolt.x86_64: W: non-conffile-in-etc /etc/intel-undervolt.conf intel-undervolt.x86_64: W: no-manual-page-for-binary intel-undervolt intel-undervolt.src: W: spelling-error Summary(en_US) undervolting -> undervaluing intel-undervolt.src: W: spelling-error %description -l en_US undervolting -> undervaluing intel-undervolt.src: W: spelling-error %description -l en_US Undervolting -> Undervaluing 2 packages and 0 specfiles checked; 0 errors, 9 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
--- Comment #2 from Artem ego.cordatus@gmail.com --- Fixed
Spec URL: https://atim.fedorapeople.org/for-review/intel-undervolt.spec SRPM URL: https://atim.fedorapeople.org/for-review/intel-undervolt-1.6-2.fc30.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
--- Comment #3 from Artem ego.cordatus@gmail.com --- Latest version with debuginfo
https://copr-be.cloud.fedoraproject.org/results/atim/intel-undervolt/fedora-...
https://copr-be.cloud.fedoraproject.org/results/atim/intel-undervolt/fedora-...
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- LGTM, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-undervolt
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-b31f3809c0 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b31f3809c0
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-7ec20d9f87 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7ec20d9f87
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- intel-undervolt-1.7-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7ec20d9f87
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- intel-undervolt-1.7-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b31f3809c0
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-01-13 02:19:49
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- intel-undervolt-1.7-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1704312
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- intel-undervolt-1.7-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com