https://bugzilla.redhat.com/show_bug.cgi?id=2238616
Bug ID: 2238616 Summary: Review Request: rust-imara-diff - Minimal terminfo libary Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/rust-imara-diff/rust-imara-diff.spec SRPM URL: https://blinxen.fedorapeople.org/rust-imara-diff/rust-imara-diff-0.1.5-1.fc4...
Description: Minimal terminfo libary.
Fedora Account System Username: blinxen
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
--- Comment #1 from blinxen h-k-81@hotmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=106099455
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- It looks like the package's description is copy-pasted from somewhere else? This is a diffing library and has nothing to do with terminfo -- maybe this can be fixed upstream?
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- You might also want to "exclude" the "/plots/" folder from being installed. It's 600 KB if image files that aren't useful for our purposes.
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
--- Comment #4 from blinxen h-k-81@hotmail.com ---
This is a diffing library and has nothing to do with terminfo -- maybe this can be fixed upstream?
It is already fixed upstream , that's probably why I missed this :D.
You might also want to "exclude" the "/plots/" folder from being installed. It's 600 KB if image files that aren't useful for our purposes.
I excluded `plots/` in `Cargo.toml`.
Here are the links to the updated files:
Spec URL: https://blinxen.fedorapeople.org/rust-imara-diff/rust-imara-diff.spec SRPM URL: https://blinxen.fedorapeople.org/rust-imara-diff/rust-imara-diff-0.1.5-1.fc4...
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Thanks! Looks good to me now.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (disabled with explanation) - latest version of the crate is packaged - license matches upstream specification (Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-imara-diff
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-ba85c7f470 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ba85c7f470
https://bugzilla.redhat.com/show_bug.cgi?id=2238616
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-09-17 18:47:07
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-ba85c7f470 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org