https://bugzilla.redhat.com/show_bug.cgi?id=2244984
Bug ID: 2244984 Summary: Review Request: openvr - OpenVR SDK Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/openvr/openvr.spec SRPM URL: https://dcavalca.fedorapeople.org/review/openvr/openvr-1.26.7-1.fc40.src.rpm
Description: OpenVR is an API and runtime that allows access to VR hardware from multiple vendors without requiring that applications have specific knowledge of the hardware they are targeting.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=107752390
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/ValveSof | |tware/openvr
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6546431 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
Tim Semeijn tim@goat.re changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tim@goat.re Doc Type|--- |If docs needed, set a value
--- Comment #3 from Tim Semeijn tim@goat.re --- This is an unofficial review as I am currently still being sponsored.
openvr-api.x86_64: E: invalid-soname /usr/lib64/libopenvr_api.so libopenvr_api.so
You should look into moving this library to a subdir of %{_libdir}.
- Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files.
Note: Documentation size is 7390917 bytes in 4 files.
You should consider moving the docs to a dedicated docs subpackage. The docs folder seems to provide API documentation which could be placed in the api subpackage. Regarding the controller_callouts docs I wonder if the devel subpackage is the right subpackage to ship these.
%files devel %license LICENSE
As the devel subpackage requires the api subpackage the %license does not have to be included here again.
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #4 from Davide Cavalca davide@cavalca.name --- Thanks for the review!
You should look into moving this library to a subdir of %{_libdir}.
That wouldn't work as this is a public library, if we move it other things linking to it wouldn't find it (short of messing with ld.so.conf, which isn't generally advisable). I'll see if I can patch the build system to make it versioned though, as unversioned .so aren't ideal.
You should consider moving the docs to a dedicated docs subpackage. The docs folder seems to provide API documentation which could be placed in the api subpackage. Regarding the controller_callouts docs I wonder if the devel subpackage is the right subpackage to ship these.
I'll move these to a -doc subpackage.
As the devel subpackage requires the api subpackage the %license does not have to be included here again.
Will remove, thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #5 from Davide Cavalca davide@cavalca.name --- Spec URL: https://dcavalca.fedorapeople.org/review/openvr/openvr.spec SRPM URL: https://dcavalca.fedorapeople.org/review/openvr/openvr-1.26.7-1.fc40.src.rpm
Changelog: - add soversion to the library (matching the one upstream uses on macOS) - move docs to -doc subpackage - drop unnecessary license in -devel subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1995349 --> https://bugzilla.redhat.com/attachment.cgi?id=1995349&action=edit The .spec file difference from Copr build 6546431 to 6563267
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6563267 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2246767
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2246767 [Bug 2246767] Review Request: qvr - QT library for VR applications
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint
There is a minor spec fixup you should do when importing though: "%{_libdir}/libopenvr_api.so.1*" is too greedy. Use "%{_libdir}/libopenvr_api.so.1{,.*}" instead.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/openvr
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0d10f094a0 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0d10f094a0
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-10-30 03:10:15
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0d10f094a0 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-10af6b1e28 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-10af6b1e28
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-10af6b1e28 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-10af6b1e28 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-10af6b1e28
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2244984
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-10af6b1e28 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org