[Bug 541462] New: Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rasmol - Molecular Graphics Visualization Tool

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Summary: Review Request: rasmol - Molecular Graphics
                    Visualization Tool
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://www.five-ten-sg.com/rasmol.spec
SRPM URL: http://www.five-ten-sg.com/rasmol-2.7.5-3.fc12.src.rpm
Description: RasMol is an X Window System tool intended for the visualization
of
proteins and nucleic acids. It reads Brookhaven Protein Database (PDB)
files and interactively renders them in a variety of formats on either
an 8-bit or 24/32-bit color display.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #1 from Carl Byington   2009-11-28 16:46:05 EDT ---
koji scratch build now works.

http://www.five-ten-sg.com/rasmol.spec
http://www.five-ten-sg.com/rasmol-2.7.5-5.fc12.src.rpm

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Stefan Riemens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Stefan Riemens   2009-11-29 16:10:12 EDT ---
Just a really quick comment after skimming over the spec:

%{__cp} -a data %buildroot%{_datadir}/%{name}
%{__mv} %buildroot%{_libdir}/%{name}/* %buildroot%{_datadir}/%{name}
%{__install} -D -m 644 src/%{name}.png
%buildroot%{_datadir}/icons/hicolor/48x48/apps/%{name}.png

Please use %{buildroot} consistently...

Stefan

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #3 from Carl Byington   2009-11-29 17:39:15 EDT ---
Fixed.

http://www.five-ten-sg.com/rasmol.spec
http://www.five-ten-sg.com/rasmol-2.7.5-6.fc12.src.rpm

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #4 from Carl Byington   2009-11-30 10:55:19 EDT ---
scratch build koji reference:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1838391

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #5 from Carl Byington   2009-12-01 00:15:21 EDT ---
http://www.five-ten-sg.com/rasmol.spec
http://www.five-ten-sg.com/rasmol-2.7.5-7.fc12.src.rpm

changes from ghemical review:
- create desktop file in %%prep
- remove __ macros

http://koji.fedoraproject.org/koji/taskinfo?taskID=1839653

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Thomas Spura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Thomas Spura   2009-12-03 19:37:31 EDT ---
I don't find the relevant section in the guidelines, but I *believe* to
remember, that you are not allowed to package 5 packages into this one.

Don't you *have* to package cqrlib, cvector, neartree and cbflib first and at
the end rasmol on its own??

As already said, I could be wrong here, but don't think so...

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

tjyuviaej  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from tjyuviaej   2009-12-03 20:15:47 EDT ---
I have RPMs for packages of cqrlib, cvector, neartree and cbflib and they
available at
http://t-matsuu.sakura.ne.jp/install-memo/fedora/repoview/

I can fit them to fedora.

After fitting my RPMs to Fedora, I'll create Fedora account and create review
process shortly.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #8 from Takanori MATSUURA   2009-12-03 20:36:57 EDT ---
Please ignore the account for comment #7.
It's for crash reporter account.

Anyway, I'll make RPMs for Fedora.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #9 from Takanori MATSUURA   2009-12-07 07:46:07 EDT ---
Package review of cbflib, cqrlib, cvector, and neartree are filed in bug
545044, bug 545045, bug 545046, and bug 545047 respectively.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #10 from Takanori MATSUURA   2009-12-09 07:52:19 EDT ---
For CBFlib, see bug 523877.
Sorry.  I forgot to check it.

I suggest this bug is depended on bug 523877, bug 545045, bug 545046, and bug
545047.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Carl Byington  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |523877, 545045, 545046,
                   |                            |545047

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #11 from Dmitrij S. Kryzhevich  2010-08-24 07:49:24 EDT ---
(In reply to comment #10)
> For CBFlib, see bug 523877.
> Sorry.  I forgot to check it.
>
> I suggest this bug is depended on bug 523877, bug 545045, bug 545046, and bug
> 545047.

If nobody want to continue the work on including rasmol and other packages from
list above into Fedora repo I could try to do it (need sponsor but could).

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #12 from Takanori MATSUURA  2010-08-24 11:30:01 EDT ---
(In reply to comment #11)
> If nobody want to continue the work on including rasmol and other packages from
> list above into Fedora repo I could try to do it (need sponsor but could).

For dependent packages which are assigned to me, I'm now in training to get
sponsor. See bug 545046.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #13 from Dmitrij S. Kryzhevich  2010-08-24 21:31:42 EDT ---
Ah, grate! Waiting rasmol in Fedora repo.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Jussi Lehtola  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Jussi Lehtola  2010-08-25 01:50:31 EDT ---
(In reply to comment #6)
> I don't find the relevant section in the guidelines, but I *believe* to
> remember, that you are not allowed to package 5 packages into this one.
>
> Don't you *have* to package cqrlib, cvector, neartree and cbflib first and at
> the end rasmol on its own??
>
> As already said, I could be wrong here, but don't think so...

Yes, this is explicitly banned in the guidelines:

http://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_proj...
http://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_lib...

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Takanori MATSUURA  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(carl@five-ten-sg.
                   |                            |com)

Bug 541462 depends on bug 545046, which changed state.

Bug 545046 Summary: Review Request: CVector - ANSI C API for Dynamic Arrays
https://bugzilla.redhat.com/show_bug.cgi?id=545046

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED
             Status|MODIFIED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

Bug 541462 depends on bug 545045, which changed state.

Bug 545045 Summary: Review Request: CQRlib - ANSI C API for quaternion arithmetic and rotation
https://bugzilla.redhat.com/show_bug.cgi?id=545045

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #15 from Takanori MATSUURA  2010-12-09 06:29:42 EST ---
Where is the latest Spec and SRPM files?

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #16 from Chen Lei  2010-12-09 10:21:47 EST ---
(In reply to comment #15)
> Where is the latest Spec and SRPM files?

CBFlib isn't available in Fedora yet.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #17 from Takanori MATSUURA  2010-12-09 10:55:06 EST ---
I'd like to add GTK2 support for el6 and Fedora 13-15 based on Carl's SRPM
because it is reviewed here. However I cannot get spec and SRPM files from
www.five-ten-sg.com website.

If Carl doesn't have enough time, I can work.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Carl Byington  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(carl@five-ten-sg. |
                   |com)                        |

--- Comment #18 from Carl Byington  2010-12-09 21:11:34 EST ---
I don't have time to package the four dependencies cqrlib, cvector, neartree
and cbflib. I think the cleanest way is to autoconf them, which I did for
cqrlib. That same method should work for the other three.

http://www.five-ten-sg.com/cqrlib.spec
http://www.five-ten-sg.com/CQRlib-1.0.6.tar.gz
http://www.five-ten-sg.com/autoconf-files.tar.gz

http://www.five-ten-sg.com/CQRlib-1.0.6-1.fc12.src.rpm
http://www.five-ten-sg.com/rasmol.spec

Once those four are accepted into Fedora, there is not much more to do to get
rasmol itself accepted.

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

Dmitrij S. Kryzhevich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(carl@five-ten-sg.
                   |                            |com)

Bug 541462 depends on bug 545047, which changed state.

Bug 545047 Summary: Review Request: NearTree - An API for finding nearest neighbors
https://bugzilla.redhat.com/show_bug.cgi?id=545047

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

Bug 541462 depends on bug 523877, which changed state.

Bug 523877 Summary: Review Request: CBFlib - crystallography binary format library
https://bugzilla.redhat.com/show_bug.cgi?id=523877

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED
             Status|MODIFIED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #19 from Dmitrij S. Kryzhevich  2012-02-27 01:13:03 EST ---
Ping?

[Bug 541462] Review Request: rasmol - Molecular Graphics Visualization Tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541462

--- Comment #20 from Takanori MATSUURA  2012-02-27 05:50:24 EST ---
I'll catch up.