[Bug 880880] New: Review Request: php-scssphp - A compiler for SCSS written in PHP - package-review

List overview All Threads
Download

newer

[Bug 880880] New: Review Request: php-scssphp - A compiler for SCSS written in PHP

older

[Bug 903785] Review Request:...

[Bug 885120] New: Review Request:...

Red Hat Bugzilla

27 Nov 2012 27 Nov '12

8:25 p.m.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Bug ID: 880880 Summary: Review Request: php-scssphp - A compiler for SCSS written in PHP Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: shawn.iwinski@gmail.com

Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-scssphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-scssphp-0.0.4-1.fc17.src...

Description: SCSS (http://sass-lang.com/) is a CSS preprocessor that adds many features like variables, mixins, imports, color manipulation, functions, and tons of other powerful features.

The entire compiler comes in a single class file ready for including in any kind of project in addition to a command line tool for running the compiler from the terminal.

scssphp implements SCSS (3.1.20). It does not implement the SASS syntax, only the SCSS syntax.

Fedora Account System Username: siwinski

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by thread

Red Hat Bugzilla

27 Nov 27 Nov

8:26 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Shawn Iwinski shawn.iwinski@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |php-scssphp

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11 Dec 11 Dec

12:41 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Remi Collet fedora@famillecollet.com changed:

--- Comment #1 from Remi Collet fedora@famillecollet.com --- Created attachment 661594 --> https://bugzilla.redhat.com/attachment.cgi?id=661594&action=edit php-scssphp-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 880880

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rx8Nuv6MDR&a=cc_unsubscribe

Red Hat Bugzilla

12:49 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

--- Comment #2 from Remi Collet fedora@famillecollet.com --- MUST:

- Please clarify License (with upstream).

Only MIT file is provided, GPLv3 only list in composer.json file...

I also think it will be great to have License header in each file.

- no need to requires php-common

only need extensions, php-common is only required for version checking

- fix the shebang

Currently, in requires: /usr/bin/env

#!/usr/bin/env php => #!/usr/bin/php

This will fix the missing dependency on php-cli.

SHOULD:

- Like for a previous review, could probably be simpler to include %{libname}/scss.inc.php (without %{_datadir}/php) and override include_path for phpunit.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tZlrqqPQTq&a=cc_unsubscribe

Red Hat Bugzilla

18 Dec 18 Dec

8:22 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Shawn Iwinski shawn.iwinski@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady

--- Comment #3 from Shawn Iwinski shawn.iwinski@gmail.com --- (In reply to comment #2)

...

MUST:

Please clarify License (with upstream).

Only MIT file is provided, GPLv3 only list in composer.json file...

I also think it will be great to have License header in each file.

Awaiting https://github.com/leafo/scssphp/issues/31

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xBs6dabdu7&a=cc_unsubscribe

Red Hat Bugzilla

9 Mar 9 Mar

1:34 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Shawn Iwinski shawn.iwinski@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |

--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- This latest upstream snapshot should fix all blockers.

SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-scssphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-scssphp-0.0.4-2.20130301...

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u4WeuM3PQG&a=cc_unsubscribe

Red Hat Bugzilla

10 Mar 10 Mar

1:47 a.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #5 from Remi Collet fedora@famillecollet.com --- About removing php-common in my previous comment.

...

From Guidelines, you must requires all need extensions (so not the package

which provides an extension). php-common is only used for version check.

In your previous spec, requiring php-common without any version have no sense, the reason why I ask to remove it.

As in this new spec, you require a minimal version, you have to do the check on php-common (or better, on php(language) which is now available on EL-6)

As the shebang is now correct, the package have a auto detected dep on /usr/bin/php, so you don't need to require php-cli.

About %{__php}, this macro is only defined: - on Fedora - with php-devel installed

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pG240RYYsA&a=cc_unsubscribe

Red Hat Bugzilla

16 Mar 16 Mar

3:49 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #6 from Shawn Iwinski shawn.iwinski@gmail.com --- Spec changes: https://github.com/siwinski/rpms/commit/86c2c1044fbef3ffa5be8867aea665de5e8c...

SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-scssphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-scssphp-0.0.5-1.fc18.src...

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lPKBtiBNFZ&a=cc_unsubscribe

Red Hat Bugzilla

18 Mar 18 Mar

9:33 a.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Remi Collet fedora@famillecollet.com changed:

--- Comment #7 from Remi Collet fedora@famillecollet.com --- [x] Requires php(language) : Ok. [x] shebang : ok [x] %{__php} macro usage : ok

No blocker

== APPROVED ==

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vYNZOk8jTv&a=cc_unsubscribe

Red Hat Bugzilla

10:18 a.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Shawn Iwinski shawn.iwinski@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #8 from Shawn Iwinski shawn.iwinski@gmail.com --- THANKS for the review!

New Package SCM Request ======================= Package Name: php-scssphp Short Description: A compiler for SCSS written in PHP Owners: siwinski Branches: f18 f19 el6 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MtHSmGZOZk&a=cc_unsubscribe

Red Hat Bugzilla

10:23 a.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LIYMSQTMzH&a=cc_unsubscribe

Red Hat Bugzilla

1:45 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2qo3Mfz0rY&a=cc_unsubscribe

Red Hat Bugzilla

1:45 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-scssphp-0.0.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-scssphp-0.0.5-1.el6

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mj3h2EzxAh&a=cc_unsubscribe

Red Hat Bugzilla

1:45 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-scssphp-0.0.5-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-scssphp-0.0.5-1.fc18

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DTGpbEtBTt&a=cc_unsubscribe

Red Hat Bugzilla

5:30 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tG7LFAdiV4&a=cc_unsubscribe

Red Hat Bugzilla

5:30 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-scssphp-0.0.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H5UROo0SRI&a=cc_unsubscribe

Red Hat Bugzilla

28 Mar 28 Mar

8:24 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6vthn2f7rX&a=cc_unsubscribe

Red Hat Bugzilla

8:24 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-scssphp-0.0.5-1.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=53oPf4c0KF&a=cc_unsubscribe

Red Hat Bugzilla

2 Apr 2 Apr

9:02 p.m.

New subject: [Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-scssphp-0.0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XljKj9qsrg&a=cc_unsubscribe

4494

Age (days ago)

4620

Last active (days ago)

package-review@lists.fedoraproject.org

18 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla