https://bugzilla.redhat.com/show_bug.cgi?id=1302871
Bug ID: 1302871 Summary: Review Request: tar-split - tar archive assembly/disassembly Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: amurdaca@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/runcom/fedora-pkgs/blob/master/golang-github-vbatts-tar-s... SRPM URL: https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-sp...
Koji builds:
- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12715095 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12715092
Description: Pristinely disassembling a tar archive, and stashing needed raw bytes and offsets to reassemble a validating original archive. Fedora Account System Username: runcom Additional information: this is just providing the devel package for v0.9.11
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
--- Comment #1 from Antonio Murdaca amurdaca@redhat.com --- This is missing cmd/ command directory which needs to be packaged as well - so tar-split provides a cmd/ and devel.
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
--- Comment #2 from Antonio Murdaca amurdaca@redhat.com --- spec and SRPM updated
Spec URL: https://raw.githubusercontent.com/runcom/fedora-pkgs/master/golang-github-vb... SRPM URL: https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-sp...
Koji builds:
- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12738989 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12738992
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
--- Comment #3 from Antonio Murdaca amurdaca@redhat.com --- Updated package to v0.9.12
spec and SRPM updated
Spec URL: https://raw.githubusercontent.com/runcom/fedora-pkgs/master/golang-github-vb... SRPM URL: https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-sp...
Koji builds:
- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12755197 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12755203
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jchaloup@redhat.com
--- Comment #4 from Jan Chaloupka jchaloup@redhat.com --- Can you create PR with your spec file and srpm here [1]? Github allows us to comment each line of a spec file. So we don't have to comment affected lines here and get confused what does it actually means.
Steps: 1) create directory with expected package name 2) create spec file (with patches and other important files) and srpm in that directory 3) create PR. 4) post link to the PR here.
In future, I would like to recommend using Github for golang related comments.
[1] https://github.com/gofed/reviews
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
--- Comment #5 from Antonio Murdaca amurdaca@redhat.com --- https://github.com/gofed/reviews/pull/1
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jchaloup@redhat.com Flags| |fedora-review+
--- Comment #6 from Jan Chaloupka jchaloup@redhat.com --- $ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-vbatts-tar-split-0.9.12-1.fc20.src.rpm golang-github-vbatts-tar-split.src: W: spelling-error Summary(en_US) disassembly -> disassemble, dis assembly, dis-assembly golang-github-vbatts-tar-split.src: W: summary-not-capitalized C tar archive assembly/disassembly golang-github-vbatts-tar-split.src: W: spelling-error %description -l en_US Pristinely -> Pristine golang-github-vbatts-tar-split.src: E: description-line-too-long C Pristinely disassembling a tar archive, and stashing needed raw bytes and offsets to reassemble a validating original archive. golang-github-vbatts-tar-split.src: W: invalid-license BSD 3-clause 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
In summary - license should be "BSD" - capitalize summary - break description into two lines
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+
--- Comment #7 from Jan Chaloupka jchaloup@redhat.com --- Summary: - golang side of the spec file fine - license ok - rpmlint ok
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
--- Comment #8 from Antonio Murdaca amurdaca@redhat.com --- Spec URL: https://github.com/gofed/reviews/raw/master/golang-github-vbatts-tar-split/g... SRPM URL: https://github.com/gofed/reviews/raw/master/golang-github-vbatts-tar-split/g...
Koji builds:
- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12774264 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12774380
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/tar-split
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
Antonio Murdaca amurdaca@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: tar-split - |Review Request: |tar archive |golang-github-vbatts-tar-sp |assembly/disassembly |lit - tar archive | |assembly/disassembly
https://bugzilla.redhat.com/show_bug.cgi?id=1302871
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/golang-github-vbatts-tar-split
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla