[Bug 1668731] New: Review Request: joda-parent - Joda-Parent is the parent pom.xml for other Joda.org projects.
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
Bug ID: 1668731 Summary: Review Request: joda-parent - Joda-Parent is the parent pom.xml for other Joda.org projects. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mkoncek@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/terminus-brut/joda-parent/blob/master/joda-parent.spec SRPM URL: https://github.com/terminus-brut/joda-parent/blob/master/joda-parent-1.4.0-1... Description: This package contains the parent pom file for other joda packages. Fedora Account System Username: mkoncek
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
Marián Konček mkoncek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1546408
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1546408 [Bug 1546408] joda-convert-v2.1.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Please use a more adequate name for your archive:
Source0: https://github.com/JodaOrg/joda-parent/archive/v%%7Bversion%7D/%%7Bname%7D-%...
- Build error:
[ERROR] UndeclaredThrowableException: InvocationTargetException: Plugin org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1 or one of its dependencies could not be resolved: Cannot access central (https://repo.maven.apache.org/maven2) in offline mode and the artifact org.apache.maven.plugins:maven-enforcer-plugin:jar:3.0.0-M1 has not been downloaded from it before.
[ERROR] UndeclaredThrowableException: InvocationTargetException: Plugin org.apache.felix:maven-bundle-plugin:4.1.0 or one of its dependencies could not be resolved: Cannot access central (https://repo.maven.apache.org/maven2) in offline mode and the artifact org.apache.felix:maven-bundle-plugin:jar:4.1.0 has not been downloaded from it before. [ERROR]
Add:
BuildRequires: mvn(org.apache.maven.plugins:maven-enforcer-plugin) BuildRequires: mvn(org.apache.felix:maven-bundle-plugin)
- Remove the dot at the end of the summary
W: summary-ended-with-dot C Joda-Parent is the parent pom.xml for other Joda.org projects.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/joda-parent/review-joda- parent/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local
Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Java: [ ]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: joda-parent-1.4.0-1.fc30.noarch.rpm joda-parent-1.4.0-1.fc30.src.rpm joda-parent.noarch: W: spelling-error Summary(en_US) xml -> XML, ml, x ml joda-parent.noarch: W: summary-ended-with-dot C Joda-Parent is the parent pom.xml for other Joda.org projects. joda-parent.noarch: W: name-repeated-in-summary C Joda-Parent joda-parent.src: W: spelling-error Summary(en_US) xml -> XML, ml, x ml joda-parent.src: W: summary-ended-with-dot C Joda-Parent is the parent pom.xml for other Joda.org projects. joda-parent.src: W: name-repeated-in-summary C Joda-Parent 2 packages and 0 specfiles checked; 0 errors, 6 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
--- Comment #2 from Marián Konček mkoncek@redhat.com --- I addressed some of the mentioned issues
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Do not repeat the name of the package in the Summary.
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
--- Comment #4 from Marián Konček mkoncek@redhat.com --- That is also fixed now.
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
Mattia Verga mattia.verga@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |NEW Assignee|zebob.m@gmail.com |nobody@fedoraproject.org Flags|fedora-review+ |needinfo?(mkoncek@redhat.co | |m)
--- Comment #5 from Mattia Verga mattia.verga@protonmail.com --- Review stalled
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
Marián Konček mkoncek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2021-06-29 07:10:11
--- Comment #6 from Marián Konček mkoncek@redhat.com --- As it turned out, this package is no longer required in our dependency chain.
https://bugzilla.redhat.com/show_bug.cgi?id=1668731
Marián Konček mkoncek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mkoncek@redhat.co | |m) |
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com