[Bug 250417] New: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

Summary: Review Request: guile-cairo - The Cairo graphics library
                    for Guile Scheme
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo.spec
SRPM URL: http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo-1.4.0-2.fc8.sr...

Description:
Guile-Cairo wraps the Cairo graphics library for Guile Scheme

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-01 14:25 EST -------
For 1.4.0-2:

* Dependency for main/subpackage
  - Usually the dependency for main/subpackage must be version-release
    specific.

* Redundant BuildRequires
  - cairo-devel requires freetype-devel
  - cairo-devel requires pkgconfig (also see below)

* pkgconfig dependency
  - Packages containing pkgconfig .pc file must have
    "Requires: pkgconfig"

* "#include" message in header files
  - Check the dependency of -devel package, especially check what
    files the header files in -devel package needs to "include".

The initial check can be done by:
----------------------------------------------------------------
$ grep -h 'include ' `rpm -ql guile-cairo-devel` | sort | uniq
#include <cairo-svg.h>
#include <cairo.h>
#include <guile-cairo-enum-types.h>
#include <guile-cairo-smob-types.h>
#include <guile-cairo-vector-types.h>
#include <libguile.h>
----------------------------------------------------------------
    And actually /usr/include/guile-cairo/guile-cairo.h contains:
----------------------------------------------------------------
    26  
    27  #include <cairo.h>
    28  #include <libguile.h>
    29  
----------------------------------------------------------------
    , which means that -devel package must require
    cairo-devel and guile-devel.

* Documents
  - Please add the following:
-----------------------------------------------------------------
NEWS
TODO
-----------------------------------------------------------------

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-02 09:25 EST -------
Good point,
all issues above has been fixed.

SPEC: http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo.spec
SRPM:
http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo-1.4.0-3.fc8.sr...

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-02 11:16 EST -------
(In reply to comment #1)
> For 1.4.0-2:
> Dependency for main/subpackage
> Usually the dependency for main/subpackage must be version-release
> specific.

- Well, this means that -devel subpackage should have:
    "Requires: %{name} = %{version}-%{release}", not
    "Requiers: %{name} = %{version}".
> pkgconfig dependency
> Packages containing pkgconfig .pc file must have
> "Requires: pkgconfig"

- -devel package contains .pc file so -devel package should have
    "Requires: pkgconfig", not main package.

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-02 13:35 EST -------
oops,
Sorry for the typo.

I've just fix this in the same release *-3 (as its spawned to cleanly fix those
issues)

http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo.spec
http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo-1.4.0-3.fc8.sr...

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-02 14:48 EST -------
(In reply to comment #4)
> oops,
> Sorry for the typo.
>
> I've just fix this in the same release *-3 (as its spawned to cleanly fix those
> issues)
>
> http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo.spec
> http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo-1.4.0-3.fc8.sr...

It seems your srpm does not fix the issue?
>

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-02 15:33 EST -------
my bad, i uploaded the main package instead of the fixed srpm.

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-02 15:44 EST -------
Okay, the right one has been uploaded, same location.

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2007-08-03 08:17 EST -------
For -3:

* License
  - Well, as we now see the discussion of the license tag on
    -devel list, license tag policy is changed.
    https://www.redhat.com/archives/fedora-devel-list/2007-August/msg00108.html

For this package, please use "LGPLv2+".

--------------------------------------------------------------
   This package (guile-cairo) is APPROVED by me
--------------------------------------------------------------

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-03 08:29 EST -------
Sure, it'll done before importing ;).

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-08-03 08:31 EST -------
New Package CVS Request
=======================
Package Name: guile-cairo
Short Description: The Cairo graphics library for Guile Scheme
Owners: [e-mail]
Branches: FC-6 F-7 EL-4 EL-5 Devel
InitialCC:

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-08-03 12:54 EST -------
cvs done.

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-08-03 14:19 EST -------
Imported & built.

Thanks all.

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-04 10:02 EST -------
This is a typo in the spec file, that unables the installation of guile-cairo
http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo.spec

Line 30: Requires:       pkconfig
It should be:
Requires:       pkg-config

[root@goorah chitlesh]# rpm -Uvh guile-cairo-*
error: Failed dependencies:
        pkconfig is needed by guile-cairo-devel-1.4.0-3.fc7.i386
(rpms from: http://koji.fedoraproject.org/koji/buildinfo?buildID=12758 )

Can you fix it and build them as should as possible to prevent yum failures ?

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-04 10:16 EST -------
(In reply to comment #13)
> This is a typo in the spec file, that unables the installation of guile-cairo
> http://laxathom.fedorapeople.org/RPMS/guile-cairo/guile-cairo.spec
>
> Line 30: Requires:       pkconfig

- Ah.. Sorry I didn't notify it (note I don't have the right to
  fix this)
> It should be:
> Requires:       pkg-config

Well, it should be "Requires: pkgconfig", not pkg-config

[Bug 250417] Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guile-cairo - The Cairo graphics library for Guile Scheme

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250417

------- Additional Comments From [e-mail]  2007-08-04 11:26 EST -------
Fixed & rebuilt.
Thanks for notify