[Bug 225839] New: Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

Summary: Merge Review: gnome-terminal
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: gnome-terminal

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-terminal/
Initial Owner: [e-mail]

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-02-04 15:15 EST -------
Reza is working on this.

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]          |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-12 12:32 EST -------
Output of src.rpm rpmlint:
W: gnome-terminal mixed-use-of-spaces-and-tabs (spaces: line 75, tab: line 92)

Output of i386.rpm rpmlint:
W: gnome-terminal non-conffile-in-etc /etc/gconf/schemas/gnome-terminal.schemas
(Respecting http://lists.debian.org/debian-gtk-gnome/2004/01/msg00020.html ,
We can ignore this warning.)

RPM name is OK.
spec file name is OK.
License: GPL. [OK]
Source gnome-terminal-2.17.90.tar.bz2 is the same as upstream.
Builds fine in mock for i386.

Comparing package Requires and BuildRequires with configure.in :
configure.in                          spec
-----------------------------         -----------------------------
GTK_REQUIRED=2.10.0                   %define gtk2_version 2.6.0
VTE_REQUIRED=0.13.4                   %define vte_version 0.12.0-2
GNOMEVFS_REQUIRED=2.4                 ?
libglade-2.0                          ?
libgnomeui-2.0                        %define libgnomeui_version 2.3.0
pangoxft >= 1.1.1                     %define pango_version 1.8.0

GConf2 >= 2.14 is repeated three times, could be defined as a macro.

There is no URL of source tarball.

There are 3 patches and one .po file in cvs but just one is applied.
They should be removed.

Configure flags are not documented. (--with-widget=vte --disable-scrollkeeper)

Parallel make flag is not used.

%makeinstall is used instead of 'make install DESTDIR=%{buildroot}'. [BLOCKER]

"gnome" is used as vendor for desktop-file-install.
However that was "gnome" for FC4 SRPM too, and vendor_id should be constant for
the life of a package. So it's ok.

'rm -r $RPM_BUILD_ROOT/var/scrollkeeper' has not any comment/document.
(Does it have effect on %find_lang ?)

Files list:

%{_datadir}/gnome/help/gnome-terminal
*** No dependency to owner of %{_datadir}/gnome/help/ nor %{_datadir}/gnome/
[BLOCKER]

%{_sysconfdir}/gconf/schemas/gnome-terminal.schemas
*** No dependency to owner of %{_sysconfdir}/gconf/schemas/ nor
%{_sysconfdir}/gconf/
[BLOCKER]

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

------- Additional Comments From [e-mail]  2007-02-14 09:25 EST -------
I've addressed most of these points in 2.17.91-2.fc7, except for

/etc/gconf/schemas, which is not a problem, since we have a dependency on GConf2
which owns it, and

/usr/share/gnome/help/ where I don't see any non-borken resolution yet.

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]
               Flag|fedora-review-              |fedora-review?

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

------- Additional Comments From [e-mail]  2007-02-19 10:07 EST -------
two little problems:

$ rpmlint gnome-terminal-2.17.91-3.src.rpm
W: gnome-terminal mixed-use-of-spaces-and-tabs (spaces: line 68, tab: line 71)

Unused patches are not removed from cvs.

And /usr/share/gnome/help/, which package should owns this directory?

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

------- Additional Comments From [e-mail]  2007-04-11 06:15 EST -------
> Unused patches are not removed from cvs.

Irrelevant for a package review.
> And /usr/share/gnome/help/, which package should owns this directory?

There has been discussion about doing a filesystem-desktop or filesystem-gnome
package.

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

------- Additional Comments From [e-mail]  2007-04-11 19:23 EST -------
(In reply to comment #4)
> two little problems:
>
> $ rpmlint gnome-terminal-2.17.91-3.src.rpm
> W: gnome-terminal mixed-use-of-spaces-and-tabs (spaces: line 68, tab: line 71)
>
> Unused patches are not removed from cvs.

Both fixed.

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]          |[e-mail]
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-04-12 07:40 EST -------
rpmlint output of source package:
W: gnome-terminal mixed-use-of-spaces-and-tabs (spaces: line 91, tab: line 68)
(cvs revision: 1.78)

[Bug 225839] Merge Review: gnome-terminal

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-terminal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 22:36 EST -------
review done.