Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226562
Summary: Merge Review: xkeyboard-config Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: krh@redhat.com
Fedora Merge Review: xkeyboard-config
http://cvs.fedora.redhat.com/viewcvs/devel/xkeyboard-config/ Initial Owner: krh@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xkeyboard-config
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226562
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
mgarski@post.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgarski@post.pl
------- Additional Comments From mgarski@post.pl 2007-04-21 09:02 EST ------- It would be good to add URL: http://freedesktop.org/wiki/Software_2fXKeyboardConfig and update to 0.9 (bug 237369).
Of course this is not a review :) Just my comment.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xkeyboard-config
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226562
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
mgarski@post.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://freedesktop.org/wiki/ | |Software/XKeyboardConfig
------- Additional Comments From mgarski@post.pl 2007-06-22 06:07 EST ------- New URL: http://freedesktop.org/wiki/Software/XKeyboardConfig
BTW. Any progress here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226562
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com, | |peter.hutterer@redhat.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226562
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2010-07-19 12:00:05 EDT --- 1)rpmlint reported xkeyboard-config.src:45: E: use-of-RPM_SOURCE_DIR ===>you use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use a directory for building, use $RPM_BUILD_ROOT instead.
xkeyboard-config.src: W: patch-not-applied Patch2: 0001-Add-Euro-and-New-Shekel-sign-to-israeli-layout.patch xkeyboard-config.src: W: patch-not-applied Patch3: 0001-symbols-de-remove-BKSP-from-neo-layout.patch xkeyboard-config.src: W: patch-not-applied Patch4: 0001-Remove-duplicate-BKSL-key-mappings-from-hin-wx-layou.patch ==>here patch is applied in different way, so ignore this xkeyboard-config.noarch: W: no-documentation
2)timestamps should be preserved.Use INSTALL="install -p" when installing to preserve timestamps.
3)Should use https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
4) I will suggest this pacakge to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226562
--- Comment #4 from Parag AN(पराग) panemade@gmail.com 2010-07-19 12:31:09 EDT --- Created an attachment (id=432942) --> (https://bugzilla.redhat.com/attachment.cgi?id=432942) xkeyboard-config-spec-cleanup.patch
I am not sure how to fix rpmlint error message for %{_sourcedir} as this is needed for patches.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226562
--- Comment #5 from Michael Schwendt mschwendt@gmail.com 2010-07-19 12:48:18 EDT --- Created an attachment (id=432948) --> (https://bugzilla.redhat.com/attachment.cgi?id=432948) spec patch to get rid of awk 'Patch' file extraction madness
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226562
Peter Hutterer peter.hutterer@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #6 from Peter Hutterer peter.hutterer@redhat.com 2010-07-19 20:58:36 EDT --- (In reply to comment #4)
Created an attachment (id=432942)
--> (https://bugzilla.redhat.com/attachment.cgi?id=432942) [details]
xkeyboard-config-spec-cleanup.patch
I am not sure how to fix rpmlint error message for %{_sourcedir} as this is needed for patches.
committed, thanks.
(In reply to comment #5)
Created an attachment (id=432948)
--> (https://bugzilla.redhat.com/attachment.cgi?id=432948) [details]
spec patch to get rid of awk 'Patch' file extraction madness
call me lazy, but I prefer it that way. saves me from updating two parts of the spec file for patches.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226562
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@gmail.com
--- Comment #7 from Michael Schwendt mschwendt@gmail.com 2010-07-21 02:55:36 EDT --- Sure, ... I also see the value in the awk command, if to be used with many more than three patch files and no conditionally applied ones. Still, when explicitly using the %{PATCHn} macros, rpmlint and Fedora pkg cvs Makefile at least __could__ try to get the warning about unapplied patches right.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226562
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #8 from Parag AN(पराग) panemade@gmail.com 2010-07-23 04:36:16 EDT --- Marking it as Reviewed. Leaving the applying patch issue to its package maintainer.
APPROVED.
package-review@lists.fedoraproject.org