https://bugzilla.redhat.com/show_bug.cgi?id=2214390
Bug ID: 2214390 Summary: Review Request: rust-hdrhistogram - Port of HdrHistogram to Rust Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-hdrhistogram.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-hdrhistogram-7.5.2-1.fc38.src.rpm
Description: A port of HdrHistogram to Rust.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2214390
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=102073789
https://bugzilla.redhat.com/show_bug.cgi?id=2214390
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |h-k-81@hotmail.com Doc Type|--- |If docs needed, set a value CC| |h-k-81@hotmail.com Flags| |fedora-review+ Status|NEW |POST
--- Comment #2 from blinxen h-k-81@hotmail.com --- Taking this review
General comments:
- Package was generated with rust2rpm and tests were deactivated - Tests were deactivated because of missing dependencies --> Should be OK but as always running tests would be preffered
Questions:
- The cargo.toml file defines:
``` [profile.release] debug=true ```
From my understanding [1] this would only make sense when building a binary. Does this have any affect on library crates? (This is not really an issue, so approving should be OK)
[1] https://doc.rust-lang.org/cargo/reference/profiles.html#debug
APPROVED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "*No copyright* Apache License (v2.0) or MIT license". 57 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rust-hdrhistogram/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- hdrhistogram-devel , rust-hdrhistogram+default-devel , rust- hdrhistogram+base64-devel , rust-hdrhistogram+bench_private-devel , rust-hdrhistogram+crossbeam-channel-devel , rust- hdrhistogram+flate2-devel , rust-hdrhistogram+nom-devel , rust- hdrhistogram+serialization-devel , rust-hdrhistogram+sync-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: rust-hdrhistogram-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+default-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+base64-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+bench_private-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+crossbeam-channel-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+flate2-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+nom-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+serialization-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram+sync-devel-7.5.2-1.fc38.noarch.rpm rust-hdrhistogram-7.5.2-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgthn7mhm')] checks: 31, packages: 10
rust-hdrhistogram+base64-devel.noarch: W: no-documentation rust-hdrhistogram+bench_private-devel.noarch: W: no-documentation rust-hdrhistogram+crossbeam-channel-devel.noarch: W: no-documentation rust-hdrhistogram+default-devel.noarch: W: no-documentation rust-hdrhistogram+flate2-devel.noarch: W: no-documentation rust-hdrhistogram+nom-devel.noarch: W: no-documentation rust-hdrhistogram+serialization-devel.noarch: W: no-documentation rust-hdrhistogram+sync-devel.noarch: W: no-documentation 10 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken 0.3 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 9
rust-hdrhistogram+flate2-devel.noarch: W: no-documentation rust-hdrhistogram+crossbeam-channel-devel.noarch: W: no-documentation rust-hdrhistogram+serialization-devel.noarch: W: no-documentation rust-hdrhistogram+default-devel.noarch: W: no-documentation rust-hdrhistogram+base64-devel.noarch: W: no-documentation rust-hdrhistogram+bench_private-devel.noarch: W: no-documentation rust-hdrhistogram+nom-devel.noarch: W: no-documentation rust-hdrhistogram+sync-devel.noarch: W: no-documentation 9 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken 0.1 s
Source checksums ---------------- https://crates.io/api/v1/crates/hdrhistogram/7.5.2/download#/hdrhistogram-7.... : CHECKSUM(SHA256) this package : 7f19b9f54f7c7f55e31401bb647626ce0cf0f67b0004982ce815b3ee72a02aa8 CHECKSUM(SHA256) upstream package : 7f19b9f54f7c7f55e31401bb647626ce0cf0f67b0004982ce815b3ee72a02aa8
Requires -------- rust-hdrhistogram-devel (rpmlib, GLIBC filtered): (crate(byteorder/default) >= 1.0.0 with crate(byteorder/default) < 2.0.0~) (crate(num-traits/default) >= 0.2.0 with crate(num-traits/default) < 0.3.0~) cargo
rust-hdrhistogram+default-devel (rpmlib, GLIBC filtered): cargo crate(hdrhistogram) crate(hdrhistogram/serialization) crate(hdrhistogram/sync)
rust-hdrhistogram+base64-devel (rpmlib, GLIBC filtered): (crate(base64/default) >= 0.13.0 with crate(base64/default) < 0.14.0~) cargo crate(hdrhistogram)
rust-hdrhistogram+bench_private-devel (rpmlib, GLIBC filtered): cargo crate(hdrhistogram)
rust-hdrhistogram+crossbeam-channel-devel (rpmlib, GLIBC filtered): (crate(crossbeam-channel/default) >= 0.5.0 with crate(crossbeam-channel/default) < 0.6.0~) cargo crate(hdrhistogram)
rust-hdrhistogram+flate2-devel (rpmlib, GLIBC filtered): (crate(flate2/default) >= 1.0.3 with crate(flate2/default) < 2.0.0~) cargo crate(hdrhistogram)
rust-hdrhistogram+nom-devel (rpmlib, GLIBC filtered): (crate(nom/default) >= 7.0.0 with crate(nom/default) < 8.0.0~) cargo crate(hdrhistogram)
rust-hdrhistogram+serialization-devel (rpmlib, GLIBC filtered): cargo crate(hdrhistogram) crate(hdrhistogram/base64) crate(hdrhistogram/flate2) crate(hdrhistogram/nom)
rust-hdrhistogram+sync-devel (rpmlib, GLIBC filtered): cargo crate(hdrhistogram) crate(hdrhistogram/crossbeam-channel)
Provides -------- rust-hdrhistogram-devel: crate(hdrhistogram) rust-hdrhistogram-devel
rust-hdrhistogram+default-devel: crate(hdrhistogram/default) rust-hdrhistogram+default-devel
rust-hdrhistogram+base64-devel: crate(hdrhistogram/base64) rust-hdrhistogram+base64-devel
rust-hdrhistogram+bench_private-devel: crate(hdrhistogram/bench_private) rust-hdrhistogram+bench_private-devel
rust-hdrhistogram+crossbeam-channel-devel: crate(hdrhistogram/crossbeam-channel) rust-hdrhistogram+crossbeam-channel-devel
rust-hdrhistogram+flate2-devel: crate(hdrhistogram/flate2) rust-hdrhistogram+flate2-devel
rust-hdrhistogram+nom-devel: crate(hdrhistogram/nom) rust-hdrhistogram+nom-devel
rust-hdrhistogram+serialization-devel: crate(hdrhistogram/serialization) rust-hdrhistogram+serialization-devel
rust-hdrhistogram+sync-devel: crate(hdrhistogram/sync) rust-hdrhistogram+sync-devel
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-hdrhistogram --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-38-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, C/C++, Perl, Haskell, Ocaml, SugarActivity, R, Python, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2214390
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2214390
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hdrhistogram
https://bugzilla.redhat.com/show_bug.cgi?id=2214390
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Fixed In Version| |rust-hdrhistogram-7.5.2-1.f | |c39 Status|POST |CLOSED Last Closed| |2023-07-06 00:15:57
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f4b70e6687
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com