Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Package review: libipathverbs - Driver library for libibverbs
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Summary: Package review: libipathverbs - Driver library for libibverbs Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dledford@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
libipathverbs is a simple package that provides a low level hardware driver for the libibverbs package. The current package requires libibverbs-1.1.3 or later to compile, and prebuilt versions as well as the spec file and srpm can be found on my person web page at:
http://xsintricity.com/dledford/Package_Review/
rpmlint shows the following:
[dledford@firewall Package_Review]$ rpmlint libipathverbs* libipathverbs.src:11: W: unversioned-explicit-provides libibverbs-driver libipathverbs.x86_64: W: non-conffile-in-etc /etc/libibverbs.d/ipath.driver libipathverbs.spec:11: W: unversioned-explicit-provides libibverbs-driver libipathverbs-static.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 4 warnings. [dledford@firewall Package_Review]$
The first and third ones are correct as it's a psuedo provides that only exists for the purpose of causing a yum install of libibverbs to pull in all the hardware drivers that make libibverbs operate.
The second is a side effect of the libibverbs package. It requires the file in this location, but the file is not user changable and should not therefore be labeled as a conf file.
The final one is because the -static package only has one file, the static library. All the docs are in the base package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
--- Comment #1 from Michael Schwendt mschwendt@gmail.com 2009-12-05 07:11:25 EDT --- The same questions I've added to "libnes" apply here. Not just because of the virtual Provides this looks more like a driver/module/plugin than an ordinary shared library for software development. Without any dependency on a package that provides some headers it's questionable to create the two -devel packages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
--- Comment #2 from Doug Ledford dledford@redhat.com 2009-12-05 10:27:44 EDT --- Ditto the responses in the libnes bug. You are correct that this is a driver plugin or libibverbs and not something directly usable by the user.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mschwendt@gmail.com AssignedTo|nobody@fedoraproject.org |mschwendt@gmail.com Flag| |fedora-review+
--- Comment #3 from Michael Schwendt mschwendt@gmail.com 2010-06-24 08:08:50 EDT --- * Correct Source URL would be: http://www.openfabrics.org/downloads/libipathverbs/libipathverbs-1.2.tar.gz
$ sha1sum libipathverbs-1.2.tar.gz 462c07f85b4d568ef72846865ee48ba0af4bb015 libipathverbs-1.2.tar.gz
Provides: %{name}-devel = %{version}-%{release}
Nowadays, automatic package name "Provides" would also add a second target-specific Provides for %{?_isa}, so also adding that one to explicit Provides would make sense:
%if "no%{?_isa}" != "no" Provides: %{name}-devel%{_isa} = %{version}-%{release} %endif
* openSUSE also build the package for 32-bit and only "ExcludeArch: s390 s390x". A .spec comment explaining your "ExlusiveArch: x86_64" would be helpful.
The spec file included in the tarball is not excluding x86 either. But it may be mistaken, since it also marks /etc/libibverbs.d/ipath.driver as %config, which you've said would be incorrect.
* Verified:
$ repoquery --whatprovides /etc/libibverbs.d libibverbs-0:1.1.3-4.fc13.i686 libibverbs-0:1.1.3-4.fc13.x86_64
Directory meanwhile is owned correctly by libiverbs.
* ldconfig calls not needed. They would be useless due to the chosen driver library SONAME.
* Placement of the static driver lib in a separate -static subpackage follows the packaging guidelines.
* There are three other libibverbs-driver packages, which are packaged in the same way. Things mentioned in this comment could be fixed in fedora pkg cvs, so:
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Doug Ledford dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Doug Ledford dledford@redhat.com 2010-07-09 13:34:55 EDT --- Michael, thanks for the review.
Rel-eng: I'd like an F-13 and devel branch for the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2010-07-09 14:15:54 EDT --- Please add a cvs template here (see http://fedoraproject.org/wiki/CVS_admin_requests )
and reset the fedora-cvs flag to ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Doug Ledford dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Doug Ledford dledford@redhat.com 2010-07-09 15:11:26 EDT --- New Package CVS Request ======================= Package Name: libipathverbs Short Description: Hardware driver for QLogic iPath hardware, used by libibverbs Owners: dledford Branches: F-13,devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2010-07-12 13:15:02 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Doug Ledford dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2012-01-03 16:00:17
package-review@lists.fedoraproject.org