https://bugzilla.redhat.com/show_bug.cgi?id=2117232
Bug ID: 2117232 Summary: Review Request: python-m3u8 - Python module %srcname parser Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@netcom-mail.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.1.0-1.fc36.src....
Description: <description here> Fedora Account System Username: martinkg
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90672614
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from leigh scott leigh123linux@googlemail.com --- The buildrequires you have added are totally insane, this package doesn't need perl* or python-devel to compile.
BuildRequires: perl(Test::More::UTF8) BuildRequires: perl(Test::WWW::Mechanize) BuildRequires: perl-rpm-build-perl BuildRequires: perl-podlators BuildRequires: python3-devel BuildRequires: python3dist(iso8601) BuildRequires: python3dist(setuptools) BuildRequires: python3dist(pytest) BuildRequires: python3dist(urllib3) BuildRequires: python3dist(wheel)
Try using these only.
BuildRequires: python3 BuildRequires: python3-rpm-macros BuildRequires: python3-iso8601 BuildRequires: python3-pytest BuildRequires: python3-setuptools
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #2 from MartinKG mgansser@netcom-mail.de --- Thanks for the hint !
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.1.0-2.fc36.src....
%changelog * Mon Aug 08 2022 Martin Gansser martinkg@fedoraproject.org 3.1.0-2 - Delete superfluous dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
MartinKG mgansser@netcom-mail.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: python-m3u8 |Review Request: python-m3u8 |- Python module %srcname |- Python module m3u8 parser |parser |
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #3 from MartinKG mgansser@netcom-mail.de --- Update
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.3.0-1.fc37.src....
%changelog * Mon Aug 08 2022 Martin Gansser martinkg@fedoraproject.org 3.3.0-1 - Update to 3.3.0
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #4 from MartinKG mgansser@netcom-mail.de --- Update to 3.4.0
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-1.fc37.src....
%changelog * Fri Mar 03 2023 Martin Gansser martinkg@fedoraproject.org 3.4.0-1 - Update to 3.4.0
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/globocom | |/m3u8
--- Comment #5 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589713 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
Felix Wang topazus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |topazus@outlook.com
--- Comment #6 from Felix Wang topazus@outlook.com --- There is a line existed in %prep of SPEC file: sed -i -e 's|3.2.0|3.3.0|' setup.py why does it exist?
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #7 from Felix Wang topazus@outlook.com --- 2. I suggest change %{python3_sitelib}/%{srcname}-%{version}-py?.??.egg-info to %{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info 3. There is a naming rule about python library, which add a subpackage using the python3- prefix. ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_nami...
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #8 from MartinKG mgansser@netcom-mail.de --- (In reply to Felix Wang from comment #6)
There is a line existed in %prep of SPEC file: sed -i -e 's|3.2.0|3.3.0|' setup.py why does it exist?
The developer forgot to change the version in the setup.py file when updating to version 3.3.0 and I forgot to remove it when updating again.
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #9 from MartinKG mgansser@netcom-mail.de --- (In reply to Felix Wang from comment #7)
- I suggest change %{python3_sitelib}/%{srcname}-%{version}-py?.??.egg-info
to %{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info 3. There is a naming rule about python library, which add a subpackage using the python3- prefix. ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ #_naming
fix package:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-2.fc37.src....
%changelog * Sun Mar 05 2023 Martin Gansser martinkg@fedoraproject.org 3.4.0-2 - remove version fix in setup.py - use python3 version naming for info file - use naming rule for python library
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #10 from Felix Wang topazus@outlook.com --- Sorry for the latest response, I am busy with many other stuff.
%description Summary: %{summary}
%description -n python3-%{srcname} Summary: %{summary}
The Summary tag was included in description, it should be removed.
%global _unpackaged_files_terminate_build 1
Without this line, it can also build successfully. Any ideas with this line?
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #11 from MartinKG mgansser@netcom-mail.de --- fix package:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-3.fc38.src....
%changelog * Wed Mar 29 2023 Martin Gansser martinkg@fedoraproject.org 3.4.0-3 - Cleanup specfile
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #12 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1954362 --> https://bugzilla.redhat.com/attachment.cgi?id=1954362&action=edit The .spec file difference from Copr build 5589713 to 5725941
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #13 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5725941 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #14 from Felix Wang topazus@outlook.com --- After looking at the .spec file and review.txt, I approved the package.
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
Felix Wang topazus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #15 from MartinKG mgansser@netcom-mail.de --- @Felix Wang Thanks for reviewing the request.
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
--- Comment #16 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-m3u8
https://bugzilla.redhat.com/show_bug.cgi?id=2117232
MartinKG mgansser@netcom-mail.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2023-03-29 13:39:04
package-review@lists.fedoraproject.org