[Bug 1667680] New: Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Bug ID: 1667680
           Summary: Review Request: python-gast - Python AST that
                    abstracts the underlying Python version
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-gast.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-gast-0.2.2-1.fc29.src.rpm

Description:
A generic AST to represent Python2 and Python3's Abstract Syntax Tree (AST).
GAST provides a compatibility layer between the AST of various Python versions,
as produced by ast.parse from the standard ast module.

Fedora Account System Username: churchyard

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Depends On|                            |1667661

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1667661
[Bug 1667661] Review Request: python-astunparse - An AST unparser for Python

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Patrik Kopkan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #1 from Patrik Kopkan  ---
Looks good to me. I would approve this if I were sponsored. There is some
warning from rpmlint about language which is irrelevant.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD 3-clause "New" or "Revised" License", "Unknown or
     generated", "*No copyright* BSD (unspecified)". 15 files have unknown
     license. Detailed output of licensecheck in
     /home/pkopkan/Documents/review/1667680-python-gast/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: python3-gast-0.2.2-1.fc30.noarch.rpm
          python-gast-0.2.2-1.fc30.src.rpm
python3-gast.noarch: W: spelling-error %description -l en_US ast -> sat, as, at
python-gast.src: W: spelling-error %description -l en_US ast -> sat, as, at
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Requires
--------
python3-gast (rpmlib, GLIBC filtered):
    python(abi)

Provides
--------
python3-gast:
    python3-gast
    python3.7dist(gast)
    python3dist(gast)

Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/gast/gast-0.2.2.tar.gz :
  CHECKSUM(SHA256) this package     :
fe939df4583692f0512161ec1c880e0a10e71e6a232da045ab8edd3756fbadf0
  CHECKSUM(SHA256) upstream package :
fe939df4583692f0512161ec1c880e0a10e71e6a232da045ab8edd3756fbadf0

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
                 CC|                            |[e-mail]
           Assignee|[e-mail]          |[e-mail]
              Flags|                            |fedora-review+

--- Comment #2 from Robert-André Mauchin  ---
Approving Patrik's review.

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Patrik Kopkan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]           |[e-mail]
              Flags|fedora-review+              |fedora-review?

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Patrik Kopkan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Patrik Kopkan  ---
refreshing approval

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-gast

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680
Bug 1667680 depends on bug 1667661, which changed state.

Bug 1667661 Summary: Review Request: python-astunparse - An AST unparser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1667661

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2019-06-26 15:26:47

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

--- Comment #5 from Fedora Update System  ---
FEDORA-2019-10d20de9a3 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-10d20de9a3

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

--- Comment #6 from Fedora Update System  ---
python-astunparse-1.6.2-1.fc30, python-gast-0.2.2-1.fc30 has been pushed to the
Fedora 30 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-10d20de9a3

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

--- Comment #7 from Fedora Update System  ---
FEDORA-2019-10d20de9a3 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-10d20de9a3

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

--- Comment #8 from Fedora Update System  ---
python-astunparse-1.6.2-1.fc30, python-beniget-0.1.0-1.fc30,
python-gast-0.2.2-1.fc30 has been pushed to the Fedora 30 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-10d20de9a3

[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version

https://bugzilla.redhat.com/show_bug.cgi?id=1667680

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|RAWHIDE                     |ERRATA

--- Comment #9 from Fedora Update System  ---
python-astunparse-1.6.2-1.fc30, python-beniget-0.1.0-1.fc30,
python-gast-0.2.2-1.fc30 has been pushed to the Fedora 30 stable repository. If
problems still persist, please make note of it in this bug report.