[Bug 2070578] New: Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.

https://bugzilla.redhat.com/show_bug.cgi?id=2070578

Bug ID: 2070578
           Summary: Review Request: python-sqladmin - SQLAdmin is a
                    flexible Admin interface for SQLAlchemy models.
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://pagure.io/python-sqladmin/raw/main/f/python-sqladmin.spec
SRPM URL: https://pagure.io/python-sqladmin/raw/main/f/
python-sqladmin-0.1.7-1.fc36.src.rpm
Description: SQLAdmin is a flexible Admin interface for SQLAlchemy models.
Fedora Account System Username: thunderbirdtr

[Bug 2070578] Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.

https://bugzilla.redhat.com/show_bug.cgi?id=2070578

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]

--- Comment #1 from Jakub Kadlčík  ---
Hello Onuralp,
thank you for the package.
> Version:       0.1.7

There is already a 0.5.0 version on GitHub, can you please update?
> License:       MIT

I believe this is not true (anymore?). According to the pyproject.toml
and LICENSE.md, the project is available under a BSD license.
> %{?python_enable_dependency_generator}

I think this is the default, so this line can IMHO be deleted. Per

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatica...
> In an emergency, you can opt-out from running the requires generator
> by adding %{?python_disable_dependency_generator} to the package
> (usually, just before the main package’s %description).
> %description
> %{summary}.

Heh, I like the period at the end :D

Joking aside, please let's try to avoid duplicating the Summary. Can
you please write 2-3 sentences or points about the package?

[Bug 2070578] Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.

https://bugzilla.redhat.com/show_bug.cgi?id=2070578

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]

needinfo canceled: [Bug 2070578] Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.

Product: Fedora
Version: rawhide
Component: Package Review

Jakub Kadlčík  has canceled Package Review
's request for Jakub Kadlčík
's needinfo:
Bug 2070578: Review Request: python-sqladmin - SQLAdmin is a flexible Admin
interface for SQLAlchemy models.
https://bugzilla.redhat.com/show_bug.cgi?id=2070578

--- Comment #3 from Jakub Kadlčík  ---
> If you're not interested in reviewing this ticket anymore

I am interested in reviewing this ticket but there is no response from the
contributor.

[Bug 2070578] Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.

https://bugzilla.redhat.com/show_bug.cgi?id=2070578

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jkadlcik@redhat.c |
                   |om)                         |

--- Comment #3 from Jakub Kadlčík  ---
> If you're not interested in reviewing this ticket anymore

I am interested in reviewing this ticket but there is no response from the
contributor.

[Bug 2070578] Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.

https://bugzilla.redhat.com/show_bug.cgi?id=2070578

Ben Beasley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(thunderbirdtr@gma
                   |                            |il.com)

--- Comment #6 from Ben Beasley  ---
Are you still pursuing this package review?

If so, could you please update it to the latest version and rewrite the spec
file to follow the modern Python packaging guidelines?

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/