[Bug 1231354] New: Review Request: php-oojs-ui - Object-Oriented JavaScript – User Interface - package-review

List overview All Threads
Download

newer

[Bug 1231354] New: Review Request: php-oojs-ui - Object-Oriented JavaScript – User Interface

older

[Bug 1177725] New: Branch EPEL7:...

[Bug 1231351] New: Review Request:...

Red Hat Bugzilla

12 Jun 2015 12 Jun '15

2:18 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Bug ID: 1231354 Summary: Review Request: php-oojs-ui - Object-Oriented JavaScript – User Interface Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@cchtml.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: http://michael.cronenworth.com/RPMS/php-oojs-ui.spec SRPM URL: http://michael.cronenworth.com/RPMS/php-oojs-ui-0.11.4-1.fc21.src.rpm Description: Object-Oriented JavaScript – User Interface, split out of mediawiki Fedora Account System Username: mooninite

$ rpmlint php-oojs-ui.newpkg/php-oojs-ui.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/SRPMS/php-oojs-ui-0.11.4-1.fc21.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

12 Jun 12 Jun

2:26 p.m.

New subject: [Bug 1231354] Review Request: php-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Michael Cronenworth mike@cchtml.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1230630

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1230630 [Bug 1230630] MediaWiki fails with "requires the PSR-3 logging library to be present"

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:58 p.m.

New subject: [Bug 1231354] Review Request: php-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Shawn Iwinski shawn.iwinski@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.iwinski@gmail.com

--- Comment #1 from Shawn Iwinski shawn.iwinski@gmail.com --- * Shouldn't source come from https://github.com/wikimedia/oojs-ui as that's where Composer installs from? -- https://packagist.org/packages/oojs/oojs-ui

* Per https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme, name should be "php-oojs-oojs-ui"

* Per https://fedoraproject.org/wiki/Packaging:PHP#File_Placement, install path should be "/usr/share/php/OOUI/*" to be PSR-0 compliant

* Per https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages, need to provide "php-composer(oojs/oojs-ui) = %{version}"

* Tests are provided so they should be run in %check

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

13 Jun 13 Jun

3:30 p.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Michael Cronenworth mike@cchtml.com changed:

--- Comment #2 from Michael Cronenworth mike@cchtml.com --- http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui.spec http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui-0.11.4-2.fc21.src.rpm

Upstream is Wikimedia's git. Why is it preferred to use the github mirror? The provided test can only be loaded through composer.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Jun 16 Jun

10:19 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com

--- Comment #3 from Remi Collet fedora@famillecollet.com ---

...

The provided test can only be loaded through composer.

This is never true. composer is just a way to get an autoloader.

Trivial solution:

phpab --output php/autoload.php php phpunit --bootstrap php/autoload.php

Missing composr.json as %doc

...

From phpcompatinfo report:

Requires: php-json, php-pcre

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

23 Jun 23 Jun

1:36 p.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

--- Comment #4 from Michael Cronenworth mike@cchtml.com --- Requires, autoloader, tests and composer.json added.

http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui.spec http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui-0.11.4-3.fc22.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

24 Jun 24 Jun

3:34 p.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

--- Comment #5 from Michael Cronenworth mike@cchtml.com --- Updated to the 0.11.6 release.

http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui.spec http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui-0.11.6-1.fc22.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

25 Jun 25 Jun

2:09 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Remi Collet fedora@famillecollet.com changed:

--- Comment #6 from Remi Collet fedora@famillecollet.com --- Created attachment 1042976 --> https://bugzilla.redhat.com/attachment.cgi?id=1042976&action=edit phpci.log

phpCompatInfo version 4.3.0 DB built Jun 21 2015 20:17:04 CEST static analyze results

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:10 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

--- Comment #7 from Remi Collet fedora@famillecollet.com --- Created attachment 1042977 --> https://bugzilla.redhat.com/attachment.cgi?id=1042977&action=edit review.txt

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:11 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #8 from Remi Collet fedora@famillecollet.com --- [~]: Requires correct, justified where necessary. missing php-spl (introduced by the autoloader)

Please add it after import (not a blocker, spl is always there, cannot be build shared, but still required by Guidelines)

=== APPROVED ===

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:52 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

--- Comment #9 from Michael Cronenworth mike@cchtml.com --- I will add spl. Thanks for the review.

New Package SCM Request ======================= Package Name: php-oojs-oojs-ui Short Description: Object-Oriented JavaScript – User Interface Upstream URL: http://www.mediawiki.org/wiki/OOjs_UI Owners: mooninite Branches: f21 f22 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:53 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Michael Cronenworth mike@cchtml.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:22 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:22 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:03 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:03 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-oojs-oojs-ui-0.11.6-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-oojs-oojs-ui-0.11.6-1.fc22

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:04 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-oojs-oojs-ui-0.11.6-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-oojs-oojs-ui-0.11.6-1.fc21

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

26 Jun 26 Jun

1:39 a.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-oojs-oojs-ui-0.11.6-1.fc22 has been pushed to the Fedora 22 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Jul 4 Jul

3:13 p.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Fedora Update System updates@fedoraproject.org changed:

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-oojs-oojs-ui-0.11.6-1.fc21 has been pushed to the Fedora 21 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:13 p.m.

New subject: [Bug 1231354] Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface

https://bugzilla.redhat.com/show_bug.cgi?id=1231354

Fedora Update System updates@fedoraproject.org changed:

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-oojs-oojs-ui-0.11.6-1.fc22 has been pushed to the Fedora 22 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3671

Age (days ago)

3693

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla