https://bugzilla.redhat.com/show_bug.cgi?id=1491710
Bug ID: 1491710 Summary: Review Request: GLee - GL Easy Extension library Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: lkundrak@v3.sk QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
This is a re-review of a package that used to be in Fedora but got orphaned. Sadly orphaning it caused atanua to be dropped too.
SPEC: http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/varia/GLee.git/plain... SRPM: https://copr-be.cloud.fedoraproject.org/results/lkundrak/varia/fedora-rawhid... mock: https://copr-be.cloud.fedoraproject.org/results/lkundrak/varia/fedora-rawhid...
Description:
GLee (GL Easy Extension library) is a free cross-platform extension loading library for OpenGL. It provides seamless support for OpenGL functions up to version 3.0 and 399 extensions.
https://bugzilla.redhat.com/show_bug.cgi?id=1491710
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1491712
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1491712 [Bug 1491712] Review Request: atanua - Real Time Logic Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1491710
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Hello,
- Group: is not used in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- Not needed:
Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig
- make %{?_smp_mflags} → %make_build
- make install → %make_install
- You forgot to bump Release: to 12:
Release: 12%{?dist}
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "NTP", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/GLee /review-GLee/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/GL [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in GLee- devel , GLee-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: GLee-5.4.0-12.fc28.x86_64.rpm GLee-devel-5.4.0-12.fc28.x86_64.rpm GLee-debuginfo-5.4.0-12.fc28.x86_64.rpm GLee-5.4.0-12.fc28.src.rpm GLee-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1491710
--- Comment #2 from Lubomir Rintel lkundrak@v3.sk --- (In reply to Robert-André Mauchin from comment #1)
Hello,
- Group: is not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- Not needed:
Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig
make %{?_smp_mflags} → %make_build
make install → %make_install
You forgot to bump Release: to 12:
Release: 12%{?dist}
Thanks. Adjusted everything but the "make install", since "%make_install" is used for autotools based stuff that uses DESTDIR -- not relevant here.
New package:
SPEC: http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/varia/GLee.git/plain... SRPM: https://copr-be.cloud.fedoraproject.org/results/lkundrak/varia/fedora-25-x86...
https://bugzilla.redhat.com/show_bug.cgi?id=1491710
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- You forgot to remove Group:. If you plan to provide it for EPEL you can keep it but otherwise it's not needed.
It's trivial, so the pacakge is accepted.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com