[Bug 709290] New: Review Request: perl-LWP-Protocol-http10 - Legacy HTTP/1.0 support for LWP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-LWP-Protocol-http10 - Legacy HTTP/1.0 support for LWP
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Summary: Review Request: perl-LWP-Protocol-http10 - Legacy HTTP/1.0 support for LWP Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rc040203@freenet.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-LWP-Protocol-http10.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-LWP-Protocol-http10-6.02-1.fc...
Description: The LWP::Protocol::http10 module provide support for using HTTP/1.0 protocol with LWP. To use it you need to call LWP::Protocol::implementor() to override the standard handler for http URLs.
Notes: 1) This package does not build on Fedora < 16, because Fedora < 16 does not provide sufficiently new modules this package depends upon. 2) This package is an optional dependency of perl-Plack's testsuite.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |665096
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com AssignedTo|nobody@fedoraproject.org |ppisar@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
--- Comment #1 from Petr Pisar ppisar@redhat.com 2011-06-09 10:09:17 EDT --- Standalone and in-SRPM spec files differ in changelog entry. I will review the standalone one as its time stamp is newer.
Source tar ball is original. Ok. Summary verified from lib/LWP/Protocol/http10.pm. Ok. License verified from lib/LWP/Protocol/http10.pm. Ok. No perl C binding, noarch architecture is Ok. Description verified from lib/LWP/Protocol/http10.pm. Ok.
TODO: Description contains orthographic mistake: `module _provide_ support'. There should be `provides'.
TODO: No tests are presented, thus the package in question is not executed at build time. You can remove all BuildRequires except perl(ExtUtils::MakeMaker).
TODO: Remove %defattr from %files section as this is implicit already.
$ rpmlint perl-LWP-Protocol-http10.spec ../SRPMS/perl-LWP-Protocol-http10-6.02-1.fc16.src.rpm ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-1.fc16.noarch.rpm perl-LWP-Protocol-http10.src: W: spelling-error %description -l en_US implementor -> implement or, implement-or, implementer perl-LWP-Protocol-http10.src: W: spelling-error %description -l en_US http -> HTTP, HP, HT perl-LWP-Protocol-http10.noarch: W: spelling-error %description -l en_US implementor -> implement or, implement-or, implementer perl-LWP-Protocol-http10.noarch: W: spelling-error %description -l en_US http -> HTTP, HP, HT 2 packages and 1 specfiles checked; 0 errors, 4 warnings. These are literals. Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-1.fc16.noarch.rpm drwxr-xr-x 2 root root 0 Jun 9 15:56 /usr/share/doc/perl-LWP-Protocol-http10-6.02 -rw-r--r-- 1 root root 470 Apr 9 12:17 /usr/share/doc/perl-LWP-Protocol-http10-6.02/Changes -rw-r--r-- 1 root root 866 Apr 9 12:15 /usr/share/doc/perl-LWP-Protocol-http10-6.02/README -rw-r--r-- 1 root root 2164 Jun 9 15:56 /usr/share/man/man3/LWP::Protocol::http10.3pm.gz drwxr-xr-x 2 root root 0 Jun 9 15:56 /usr/share/perl5/vendor_perl/LWP drwxr-xr-x 2 root root 0 Jun 9 15:56 /usr/share/perl5/vendor_perl/LWP/Protocol -rw-r--r-- 1 root root 8857 Apr 9 12:15 /usr/share/perl5/vendor_perl/LWP/Protocol/http10.pm File permissions and layout is Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-1.fc16.noarch.rpm |sort |uniq -c 1 perl(HTTP::Response) >= 6 1 perl(HTTP::Status) >= 6 1 perl(IO::Select) 1 perl(IO::Socket) 1 perl(LWP::Protocol) >= 6 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Require perl(URI::Escape) (lib/LWP/Protocol/http10.pm:74).
$ rpm -q --provides -p ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-1.fc16.noarch.rpm |sort |uniq -c 1 perl(LWP::Protocol::http10) = 6.02 1 perl-LWP-Protocol-http10 = 6.02-1.fc16 Binary provides Ok.
$ ~/bin/resolvedeps rawhide ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-1.fc16.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3121698). Ok.
Otherwise package is in line with Fedora and perl packaging guidelines.
Please correct all `FIX' prefixed issues, consider fixing `TODO' items, and provide new spec file.
Resolution: Package NOT approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
--- Comment #2 from Ralf Corsepius rc040203@freenet.de 2012-01-16 02:55:00 EST --- Updated package:
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-LWP-Protocol-http10.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-LWP-Protocol-http10-6.02-3.fc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppisar@redhat.com 2012-01-16 07:57:28 EST --- Spec file changes:
--- perl-LWP-Protocol-http10.spec 2011-05-31 11:52:07.000000000 +0200 +++ perl-LWP-Protocol-http10.spec.1 2012-01-16 08:53:32.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-LWP-Protocol-http10 Version: 6.02 -Release: 1%{?dist} +Release: 3%{?dist} Summary: Legacy HTTP/1.0 support for LWP License: GPL+ or Artistic Group: Development/Libraries @@ -11,21 +11,19 @@ BuildRequires: perl(HTTP::Response) >= 6 BuildRequires: perl(HTTP::Status) >= 6 BuildRequires: perl(LWP::Protocol) >= 6 + Requires: perl(HTTP::Response) >= 6 +%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\(HTTP::Response\) Requires: perl(HTTP::Status) >= 6 +%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\(HTTP::Status\) Requires: perl(LWP::Protocol) >= 6 +%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\(LWP::Protocol\) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) - -%{?filter_setup: -# Filter unversioned versions of versioned Requires: -%filter_from_requires /^perl(HTTP::Response)/d -%filter_from_requires /^perl(HTTP::Status)/d -%filter_from_requires /^perl(LWP::Protocol)/d -%?perl_default_filter -} +# Make optional dependency mandatory +Requires: perl(URI::Escape)
%description -The LWP::Protocol::http10 module provide support for using HTTP/1.0 +The LWP::Protocol::http10 module provides support for using HTTP/1.0 protocol with LWP. To use it you need to call LWP::Protocol::implementor() to override the standard handler for http URLs.
@@ -54,6 +52,11 @@ %{_mandir}/man3/*
%changelog -* Tue May 31 2011 Ralf Corsépius corsepiu@fedoraproject.org 6.02-1 -- Initial Fedora package. +* Mon Jan 16 2012 Ralf Corsépius corsepiu@fedoraproject.org 6.02-3 +- Rework filters. + +* Fri Jun 19 2011 Ralf Corsépius corsepiu@fedoraproject.org 6.02-2 +- Reflect feedback from package review.
+* Mon Apr 18 2011 Ralf Corsépius corsepiu@fedoraproject.org 6.02-1 +- Specfile autogenerated by cpanspec 1.78.
TODO: Description contains orthographic mistake: `module _provide_ support'. There should be `provides'.
%description -The LWP::Protocol::http10 module provide support for using HTTP/1.0 +The LWP::Protocol::http10 module provides support for using HTTP/1.0 Ok.
TODO: No tests are presented, thus the package in question is not executed at build time. You can remove all BuildRequires except perl(ExtUtils::MakeMaker).
Not addressed. Ok.
TODO: Remove %defattr from %files section as this is implicit already.
Not addressed. Ok.
$ rpmlint perl-LWP-Protocol-http10.spec ../SRPMS/perl-LWP-Protocol-http10-6.02-3.fc17.src.rpm ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-3.fc17.noarch.rpm perl-LWP-Protocol-http10.src: W: spelling-error %description -l en_US implementor -> implementer, implement or, implement-or perl-LWP-Protocol-http10.src: W: spelling-error %description -l en_US http -> HTTP perl-LWP-Protocol-http10.noarch: W: spelling-error %description -l en_US implementor -> implementer, implement or, implement-or perl-LWP-Protocol-http10.noarch: W: spelling-error %description -l en_US http -> HTTP 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint Ok.
FIX: Require perl(URI::Escape) (lib/LWP/Protocol/http10.pm:74).
+# Make optional dependency mandatory +Requires: perl(URI::Escape) Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-3.fc17.noarch.rpm |sort |uniq -c 1 perl(HTTP::Response) >= 6 1 perl(HTTP::Status) >= 6 1 perl(IO::Select) 1 perl(IO::Socket) 1 perl(LWP::Protocol) >= 6 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(URI::Escape) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-LWP-Protocol-http10-6.02-3.fc17.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3705662). Ok.
Resolution: Package APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Ralf Corsepius rc040203@freenet.de 2012-01-18 02:10:11 EST --- New Package SCM Request ======================= Package Name: perl-LWP-Protocol-http10 Short Description: Legacy HTTP/1.0 support for LWP Owners: corsepiu Branches: f15 f16 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2012-01-18 08:35:03 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2012-01-18 12:51:14 EST --- perl-LWP-Protocol-http10-6.02-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-LWP-Protocol-http10-6.02-3.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2012-01-18 20:32:53 EST --- perl-LWP-Protocol-http10-6.02-3.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709290
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-LWP-Protocol-http10-6. | |02-3.fc16 Resolution| |ERRATA Last Closed| |2012-01-26 17:56:16
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2012-01-26 17:56:16 EST --- perl-LWP-Protocol-http10-6.02-3.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla