https://bugzilla.redhat.com/show_bug.cgi?id=1821305
Bug ID: 1821305 Summary: Review Request: zgrab2 - Application Layer Scanner Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/zgrab2.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/zgrab2-0.1.5-1.fc31.src.rpm
Project URL: https://github.com/zmap/zgrab2
Description: Go Application Layer Scanner.
Koji scratch build: fails due to missing dependencies
rpmlint output: $ rpmlint zgrab2-0.1.5-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint zgrab2-0.1.5-1.fc31.x86_64.rpm zgrab2.x86_64: W: no-manual-page-for-binary http zgrab2.x86_64: W: no-manual-page-for-binary zgrab2 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1821305
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |563471 (FE-SECLAB) Depends On| |1819317 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages https://bugzilla.redhat.com/show_bug.cgi?id=1819317 [Bug 1819317] Review Request: golang-github-zmap-zflags - Go command line option parser
https://bugzilla.redhat.com/show_bug.cgi?id=1821305 Bug 1821305 depends on bug 1819317, which changed state.
Bug 1819317 Summary: Review Request: golang-github-zmap-zflags - Go command line option parser https://bugzilla.redhat.com/show_bug.cgi?id=1819317
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1821305
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Bump to 0.1.7
- License seems co be ISC and ASL 2:0:
License: ISC and ASL 2.0
- There's an API mismatch:
# github.com/zmap/zgrab2 _build/src/github.com/zmap/zgrab2/utility.go:52:39: parser.ParseCommandLine undefined (type *flags.Parser has no field or method ParseCommandLine) /usr/lib/golang/pkg/tool/linux_amd64/buildid -w $WORK/b168/_pkg_.a # internal
Seems to be linked to zflags. 1.4.0-beta.1 has ParseCommandLine.
Zcrypto needs updating too:
# github.com/zmap/zgrab2/modules/http _build/src/github.com/zmap/zgrab2/modules/http/scanner.go:229:31: undefined: "github.com/zmap/zcrypto/tls".SigAndHash
After all this is updated, it works:
- Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved. Please fix the License before import.
https://bugzilla.redhat.com/show_bug.cgi?id=1821305
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/zgrab2
https://bugzilla.redhat.com/show_bug.cgi?id=1821305
Mattia Verga mattia.verga@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mattia.verga@protonmail.com Flags| |needinfo?(mail@fabian-affol | |ter.ch)
--- Comment #3 from Mattia Verga mattia.verga@protonmail.com --- Package never imported, Fabian are you still interested in finalizing this?
https://bugzilla.redhat.com/show_bug.cgi?id=1821305
Mattia Verga mattia.verga@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ | |needinfo?(mail@fabian-affol | |ter.ch) | Status|POST |CLOSED Assignee|zebob.m@gmail.com |nobody@fedoraproject.org Resolution|--- |NOTABUG Blocks| |201449 (FE-DEADREVIEW) Last Closed| |2021-10-11 07:47:55
--- Comment #4 from Mattia Verga mattia.verga@protonmail.com --- Closing as DEADREVIEW Filed https://pagure.io/releng/issue/10332
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com