[Bug 599291] New: Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: maven-ear-plugin - Maven EAR Plugin

https://bugzilla.redhat.com/show_bug.cgi?id=599291

Summary: Review Request: maven-ear-plugin - Maven EAR Plugin
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://huwang.fedorapeople.org/packages/maven-ear-plugin/maven-ear-plugin.sp...
SRPM URL:
http://huwang.fedorapeople.org/packages/maven-ear-plugin/maven-ear-plugin-2....
Description: Generates a J2EE Enterprise Archive (EAR) file.

Scratch built in koji :
http://koji.fedoraproject.org/koji/taskinfo?taskID=2226405

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-review?              |

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Alexander Kurtakov  2010-06-04 09:54:35 EDT ---
I'll take this one.

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

--- Comment #2 from Alexander Kurtakov  2010-06-04 10:08:03 EDT ---
Review:

OK: rpmlint must be run on every package. Output:
maven-ear-plugin.noarch: W: no-documentation
maven-ear-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-ear-plugin

False positives.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8.    
OK: Provides/Obsoletes are good.

FIXIT: The package should at least Requires: maven2 maybe there are even others
missing.

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

--- Comment #3 from huwang  2010-06-06 22:42:57 EDT ---
(In reply to comment #2)
> Review:
>
> OK: rpmlint must be run on every package. Output:
> maven-ear-plugin.noarch: W: no-documentation
> maven-ear-plugin.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/maven-ear-plugin
>
> False positives.
>
> OK: The package must be named according to the Package Naming Guidelines .
> OK: The spec file name must match the base package %{name}, in the format
> %{name}.spec unless your package has an exemption. 
> OK: The package must meet the Packaging Guidelines .
> OK: The package must be licensed with a Fedora approved license and meet the
> Licensing Guidelines .
> OK: The License field in the package spec file must match the actual license.
> OK: If (and only if) the source package includes the text of the license(s) in
> its own file, then that file, containing the text of the license(s) for the
> package must be included in %doc.
> OK: The spec file must be written in American English. 
> OK: The spec file for the package MUST be legible. 
> OK: The sources used to build the package must match the upstream source, as
> provided in the spec URL. 
> OK: The package MUST successfully compile and build into binary rpms on at
> least one primary architecture. 
> OK: All build dependencies must be listed in BuildRequires, except for any that
> are listed in the exceptions section of the Packaging Guidelines ; inclusion of
> those as BuildRequires is optional. Apply common sense.
> OK: Packages must NOT bundle copies of system libraries.
> OK: A package must own all directories that it creates. If it does not create a
> directory that it uses, then it should require a package which does create that
> directory. 
> OK: A Fedora package must not list a file more than once in the spec file's
> %files listings. 
> OK: Permissions on files must be set properly. Executables should be set
> with executable permissions, for example. Every %files section must include a
> %defattr(...) line. 
> OK: Each package must consistently use macros. 
> OK: The package must contain code, or permissable content. 
> OK: Large documentation files must go in a -doc subpackage. 
> OK: If a package includes something as %doc, it must not affect the runtime of
> the application. 
> OK: Packages must not own files or directories already owned by other packages. 
> OK: All filenames in rpm packages must be valid UTF-8.    
> OK: Provides/Obsoletes are good.
>
> FIXIT: The package should at least Requires: maven2 maybe there are even others
> missing.

Fixed. Please review again, thanks.

Spec URL:
http://huwang.fedorapeople.org/packages/maven-ear-plugin/maven-ear-plugin.sp...
SRPM URL:
http://huwang.fedorapeople.org/packages/maven-ear-plugin/maven-ear-plugin-2....
Scratch build in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2234492

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Alexander Kurtakov  2010-06-07 01:34:53 EDT ---
Thanks, 
Looks good.

Package is APPROVED.

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

--- Comment #5 from huwang  2010-06-07 02:00:00 EDT ---
New Package CVS Request
=======================
Package Name: maven-ear-plugin
Short Description: Maven EAR Plugin
Owners: huwang
Branches: 
InitialCC:

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

--- Comment #6 from Kevin Fenzi  2010-06-07 17:10:27 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=599291

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #7 from huwang  2010-06-08 04:21:58 EDT ---
Built in koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=177248