[Bug 604501] New: Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick - package-review

List overview All Threads
Download

newer

[Bug 604501] New: Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

older

[Bug 743615] New: Review Request:...

[Bug 626004] New: Review Request:...

Red Hat Bugzilla

16 Jun 2010 16 Jun '10

5:56 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Summary: Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: gracca@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://sites.google.com/site/gracca/gtk-chtheme.spec

SRPM URL: http://sites.google.com/site/gracca/gtk-chtheme-0.3.1-3.fc13.src.rpm

Description: As the name suggests, this little program lets you change your Gtk+ 2.0 theme. The aim is to make theme preview and selection as slick as possible. Themes installed on the system are presented for selection and previewed on the fly. A large variety of widgets provides a comprehensive demonstration.

$ rpmlint SPECS/gtk-chtheme.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint SRPMS/gtk-chtheme-0.3.1-3.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint RPMS/i686/gtk-chtheme-0.3.1-3.fc13.i686.rpm gtk-chtheme.i686: W: unstripped-binary-or-object /usr/bin/gtk-chtheme gtk-chtheme.i686: W: spurious-executable-perm /usr/share/man/man1/gtk-chtheme.1.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fabian, you said in Bug 541724 that it is not necessary to change the attribute of the man file, so I didn't changed it.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

16 Jun 16 Jun

11:31 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Terje RÃ¸sten terjeros@phys.ntnu.no changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@phys.ntnu.no

--- Comment #1 from Terje RÃ¸sten terjeros@phys.ntnu.no 2010-06-16 06:31:50 EDT --- Please fix exec bits on man page, no reason not to fix that.

desktop file has Icon=style , however no style image is shipped.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Jun 17 Jun

8:21 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #2 from Germán Racca gracca@gmail.com 2010-06-17 03:18:53 EDT --- OK, both issues fixed. Please find updated files here:

Spec URL: http://sites.google.com/site/gracca/gtk-chtheme.spec

SRPM URL: http://sites.google.com/site/gracca/gtk-chtheme-0.3.1-4.fc13.src.rpm

Cheers, German.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:43 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Fabian Affolter fabian@bernewireless.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |iamdexpl@gmail.com

--- Comment #3 from Fabian Affolter fabian@bernewireless.net 2010-06-17 14:43:02 EDT --- *** Bug 541724 has been marked as a duplicate of this bug. ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

28 Jun 28 Jun

11:15 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #4 from Germán Racca gracca@gmail.com 2010-06-28 18:15:09 EDT --- Files moved to fedorapeople.org:

Spec URL: http://skytux.fedorapeople.org/packages/gtk-chtheme.spec

SRPM URL: http://skytux.fedorapeople.org/packages/gtk-chtheme-0.3.1-4.fc13.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 Jul 11 Jul

10:48 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Terje RÃ¸sten terjeros@phys.ntnu.no changed:

--- Comment #5 from Terje RÃ¸sten terjeros@phys.ntnu.no 2010-07-11 05:48:57 EDT ---

ok rpmlint ok named and versioned according to the Package Naming Guidelines ok spec file name matches base package name ok license : GPLv2+ tag correct and all files with license info ok COPYING packaged as %doc ok source matches upstream: dbea31f4092877e786fe040fae1374238fada94a gtk-chtheme-0.3.1.tar.bz2 dbea31f4092877e786fe040fae1374238fada94a gtk-chtheme-0.3.1.tar.bz2.1 ! builds in koji: something is wrong here, might be missing #include, please have a look. Ref: http://koji.fedoraproject.org/koji/taskinfo?taskID=2310790 http://koji.fedoraproject.org/koji/getfile?taskID=2310792&name=build.log ok no missing BuildRequires (builds in mock) ok no translations, so translation/locale guidelines don't apply ok no shared libraries, so no ldconfig calls neeed ok no duplicated system libraries ok package not relocatable ok directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories) ok no duplicate files in %files ! permissions correct, defattr used correctly please drop %attr on man page, change to correct mode in %install. %attr is for special cases. ok macros ok no non-code content ok no large documentation files, so no -doc package needed ok no %doc files required at runtime ok no header files which would need to be in a -devel subpackage ok no static libraries, so no -static package needed ok no devel symlinks which would need to be in a -devel subpackage ok no -devel package, ok no .la files ok .desktop file ok desktop-file-validate is used in %install and the .desktop file passes validation ok all filenames are valid UTF-8 ok complies with the FHS ok proper changelog, tags, BuildRoot, BuildRequires, Summary, Description ok no macros in Summary and Description ok no non-UTF-8 characters ok all relevant documentation included as %doc ok RPM_OPT_FLAGS are used (%cmake macro) ok debuginfo package is valid ok no rpaths ok no configuration files, so %config guideline doesn't apply ok no init scripts, so init script guideline doesn't apply ok no timestamp-clobbering file commands ok _smp_mflags used ok not a web application, so web application guideline doesn't apply ok no conflicts

Please have a look on items marked with ! .

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

14 Jul 14 Jul

3:06 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #6 from Germán Racca gracca@gmail.com 2010-07-13 22:06:27 EDT --- Hello Terje:

Thanks for the full review! But I can't find what is the problem in the build for F-14. For F-12 and F-13 it builds fine. With respect to the man page, no problem, I'll correct it, but please can you give me some hints about the build error?

Regards, German.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:54 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #7 from Terje RÃ¸sten terjeros@phys.ntnu.no 2010-07-14 04:54:48 EDT --- Seems like a change in GTK is the problem, I added a patch and it built fine:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2318320

spec: http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme.spec srpm: http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme-0.3.1-5.fc12.src.rp...

Note: only built, not tested.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #8 from Terje RÃ¸sten terjeros@phys.ntnu.no 2010-07-14 05:00:03 EDT --- Forgot: patch might work on all active Fedora releases, no special cace for F-14 needed.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Jul 15 Jul

7:35 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #9 from Germán Racca gracca@gmail.com 2010-07-15 14:35:12 EDT --- (In reply to comment #7)

...

Seems like a change in GTK is the problem, I added a patch and it built fine:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2318320

spec: http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme.spec srpm: http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme-0.3.1-5.fc12.src.rp...

Note: only built, not tested.

Hello Terje:

Many thanks for your help with the patch! I also have corrected the permission of the man page in the right way. I've tested it under FC13 and works fine.

Koji builds from scratch:

dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2322311 dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2322367 dist-rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2322382

$ rpmlint rpmbuild/{SPECS,SRPMS,RPMS/i686}/gtk-chtheme* gtk-chtheme.i686: W: unstripped-binary-or-object /usr/bin/gtk-chtheme 2 packages and 1 specfiles checked; 0 errors, 1 warnings.

Please find the updated files here:

Spec: http://skytux.fedorapeople.org/packages/gtk-chtheme.spec SRPM: http://skytux.fedorapeople.org/packages/gtk-chtheme-0.3.1-6.fc13.src.rpm

Regards, German.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:49 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Terje RÃ¸sten terjeros@phys.ntnu.no changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #10 from Terje RÃ¸sten terjeros@phys.ntnu.no 2010-07-15 18:49:42 EDT --- Thanks, all is good.

The package gtk-chtheme is APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

16 Jul 16 Jul

12:15 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #11 from Germán Racca gracca@gmail.com 2010-07-15 19:15:10 EDT --- (In reply to comment #10)

...

Thanks, all is good.

The package gtk-chtheme is APPROVED.

Thank you very much for the review Terje!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:18 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Germán Racca gracca@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #12 from Germán Racca gracca@gmail.com 2010-07-15 19:18:45 EDT --- New Package CVS Request ======================= Package Name: gtk-chtheme Short Description: Gtk+ 2.0 theme preview and selection made slick Owners: skytux Branches: F-12 F-13 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:30 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #13 from Kevin Fenzi kevin@tummy.com 2010-07-16 13:30:02 EDT --- CVS done (by process-cvs-requests.py).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:40 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-07-16 16:40:58 EDT --- gtk-chtheme-0.3.1-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/gtk-chtheme-0.3.1-6.fc12

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:46 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-07-16 16:46:47 EDT --- gtk-chtheme-0.3.1-6.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gtk-chtheme-0.3.1-6.fc13

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:09 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Germán Racca gracca@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Aug 6 Aug

12:34 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-08-05 19:34:30 EDT --- gtk-chtheme-0.3.1-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:34 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:53 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-08-05 19:53:24 EDT --- gtk-chtheme-0.3.1-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:53 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|gtk-chtheme-0.3.1-6.fc12 |gtk-chtheme-0.3.1-6.fc13

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

29 Feb 29 Feb

1:05 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Germán Racca gracca@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

--- Comment #18 from Germán Racca gracca@gmail.com 2012-02-29 08:05:45 EST --- Package Change Request ====================== Package Name: gtk-chtheme New Branches: el6 Owners: splinux skytux

I'm authorizing the user splinux to co-maintain this epel branch for gtk-chtheme.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:22 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #19 from Jon Ciesla limburgher@gmail.com 2012-02-29 08:22:51 EST --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

30 Mar 30 Mar

9:30 a.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

--- Comment #20 from Fedora Update System updates@fedoraproject.org 2012-03-30 04:30:16 EDT --- gtk-chtheme-0.3.1-11.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gtk-chtheme-0.3.1-11.el6

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

14 Apr 14 Apr

6:58 p.m.

New subject: [Bug 604501] Review Request: gtk-chtheme - Gtk+ 2.0 theme preview and selection made slick

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604501

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|gtk-chtheme-0.3.1-6.fc13 |gtk-chtheme-0.3.1-11.el6

--- Comment #21 from Fedora Update System updates@fedoraproject.org 2012-04-14 13:58:36 EDT --- gtk-chtheme-0.3.1-11.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4461

Age (days ago)

5129

Last active (days ago)

package-review@lists.fedoraproject.org

24 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla