https://bugzilla.redhat.com/show_bug.cgi?id=2160202
Bug ID: 2160202 Summary: Review Request: golang-github-d2g-hardwareaddr - Generate Hardware Addresses Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: gotmax@e.email QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gotmax23.fedorapeople.org/reviews/golang-github-d2g-hardwareaddr/gol... SRPM URL: https://gotmax23.fedorapeople.org/reviews/golang-github-d2g-hardwareaddr/gol...
Description: Generate Hardware Addresses.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=96016853
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2045489 Doc Type|--- |If docs needed, set a value CC| |zebob.m@gmail.com
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2045489 [Bug 2045489] golang-github-d2g-dhcp4server: FTBFS in Fedora rawhide/f36
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5218064 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |sergio@serjux.com CC| |sergio@serjux.com
--- Comment #2 from Sergio Basto sergio@serjux.com --- Rpmlint ------- Checking: golang-github-d2g-hardwareaddr-devel-0-0.1.20230111gite7d9fbe.fc38.noarch.rpm golang-github-d2g-hardwareaddr-0-0.1.20230111gite7d9fbe.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4pgjw64t')] checks: 31, packages: 2
golang-github-d2g-hardwareaddr.spec: W: no-%build-section golang-github-d2g-hardwareaddr-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/d2g/hardwareaddr/.goipath golang-github-d2g-hardwareaddr-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/d2g/hardwareaddr/README.md /usr/share/doc/golang-github-d2g-hardwareaddr-devel/README.md 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
golang-github-d2g-hardwareaddr-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/d2g/hardwareaddr/.goipath golang-github-d2g-hardwareaddr-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/d2g/hardwareaddr/README.md /usr/share/doc/golang-github-d2g-hardwareaddr-devel/README.md 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.0 s
Source checksums ---------------- https://github.com/d2g/hardwareaddr/archive/e7d9fbe030e4b7b08e3bdd128e2e8180... : CHECKSUM(SHA256) this package : 867c8ffc592e672ca8f10e10a6a1860d716b03d03d915484bf7b73adbe6ae18d CHECKSUM(SHA256) upstream package : 867c8ffc592e672ca8f10e10a6a1860d716b03d03d915484bf7b73adbe6ae18d
the very simple spec , makes easy to review , the source code of this package is 34 lines
Package APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
--- Comment #3 from Maxwell G gotmax@e.email --- Thank you for the review, Sergio
https://pagure.io/releng/fedora-scm-requests/issue/50559
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e09a03e788 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e09a03e788
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-01-22 22:33:52
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e09a03e788 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0c69afdc55 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c69afdc55
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0c69afdc55 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0c69afdc55` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c69afdc55
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2160202
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0c69afdc55 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org