https://bugzilla.redhat.com/show_bug.cgi?id=2358213
Bug ID: 2358213 Summary: Review Request: chinese-segmentation - Chinese segmentation software Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: benson_muite@emailplus.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://fed500.fedorapeople.org/chinese-segmentation.spec srpm: https://fed500.fedorpeople.org/chinese-segmentation-0.%5E20240206git4a6b092-...
description: Convert hanzi to pinyin and traditional chinese to simplified.
fas: fed500
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |Tom.Rix@amd.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |Tom.Rix@amd.com
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
--- Comment #1 from Tom.Rix@amd.com --- srpm link in broken, fedorpeople -> fedorapeople
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
spec: https://fed500.fedorapeople.org/chinese-segmentation.spec srpm: https://fed500.fedorapeople.org/chinese-segmentation-0.%5E20240206git4a6b092...
description: Convert hanzi to pinyin and traditional chinese to simplified.
fas: fed500
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Edited it. Will likely need to update download link as Gitee requires authentication from most ip addresses, so may need to add a comment about that.
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org)
--- Comment #3 from Tom.Rix@amd.com --- Thanks for the update, I was able to run a local fedora-review, I think there is an issue with the source, here is the first part of the output.
Issues: ======= - Dist tag is present. - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /sfs/fedora-review/review- chinese-segmentation/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
can you review your src and the upstream's ?
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- Added a script to download from git
spec: https://fed500.fedorapeople.org/chinese-segmentation.spec srpm: https://fed500.fedorapeople.org/chinese-segmentation-1.0.01-1.fc42.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitee.com/openkylin | |/chinese-segmentation/
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9381360 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358213
--- Comment #6 from Tom.Rix@amd.com --- How are you running the fedora-review command? it is stumbling on source0,1
How are you getting this line ? License: GPL-3.0-or-later AND MIT AND NTP
[!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
It looks like this project has a few bundled projects with their license files stripped out, these are the ones i could easily find.
This is the cppjieba/limonp is really this https://github.com/yanyiwu/limonp/tree/master/include/limonp
And cppjiaba is really this https://github.com/yanyiwu/cppjieba
A package can not strip other embedded license files.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com