[Bug 596074] New: Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: multithreadedtc - A framework for testing concuurent Java application

https://bugzilla.redhat.com/show_bug.cgi?id=596074

Summary: Review Request: multithreadedtc - A framework for
                    testing concuurent Java application
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc.spec
SRPM URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc-1.0....
Description: MultithreadedTC is a framework for testing concurrent
applications. 
It features a metronome that is used to provide fine control over the sequence
of activities in multiple threads.

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #1 from huwang  2010-05-26 05:36:10 EDT ---
Notes:
- Built in koji with dist-f14-maven221 target, the link is
http://koji.fedoraproject.org/koji/taskinfo?taskID=2210222

- Adding build.patch that remove retrotranslator dependency and pom, the
package link is http://huwang.fedorapeople.org/packages/multithreadedtc

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #2 from huwang  2010-05-26 05:55:46 EDT ---
I rebuild this package in koji with dist-f14-maven221 target, here is the link:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2210261

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Alexander Kurtakov  2010-05-26 07:15:53 EDT ---
Please add a depmap for multithreadedtc-jdk14 to point to the multithreadedtc
jar.

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #4 from Alexander Kurtakov  2010-05-26 11:09:27 EDT ---
I'll take this one.

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #5 from Alexander Kurtakov  2010-05-26 11:26:31 EDT ---
* Why don't you use upstream tarball
http://multithreadedtc.googlecode.com/files/MultithreadedTC-1.01-source.zip ?
Please use it.
Note that you'll have to remove the jars from it.

* You're missing 
Requires: jpackage-utils
Requires(post): jpackage-utils
Requires(postun): jpackage-utils
They are needed because you invoke update_maven_depmap

* You're missing 
Requires:       jpackage-utils 
for the javadoc subpackage

* Please remove  ls -lR from install section

* Please fix the following rpmlint warnings:
multithreadedtc.noarch: E: description-line-too-long C It features a metronome
that is used to provide fine control over the sequence of activities in
multiple threads.

Fix line length

multithreadedtc.noarch: W: no-documentation

You should include LICENSE.txt and README.txt as %doc

multithreadedtc-javadoc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/javadoc/multithreadedtc-1.0.1/package-list
multithreadedtc-javadoc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/javadoc/multithreadedtc-1.0.1/stylesheet.css

You should fix these by doing sed -i 's/\r//' <file_to_strip>  for both of them
in the %prep section.

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #6 from huwang  2010-05-27 03:49:07 EDT ---
(In reply to comment #5)
> Why don't you use upstream tarball
>
> http://multithreadedtc.googlecode.com/files/MultithreadedTC-1.01-source.zip ?
> Please use it.
> Note that you'll have to remove the jars from it.
> You're missing
>
> Requires: jpackage-utils
> Requires(post): jpackage-utils
> Requires(postun): jpackage-utils
> They are needed because you invoke update_maven_depmap
> You're missing
>
> Requires:       jpackage-utils 
> for the javadoc subpackage
>
> Please remove  ls -lR from install section
>
> Please fix the following rpmlint warnings:
>
> multithreadedtc.noarch: E: description-line-too-long C It features a metronome
> that is used to provide fine control over the sequence of activities in
> multiple threads.
>
> Fix line length
>
> multithreadedtc.noarch: W: no-documentation
>
> You should include LICENSE.txt and README.txt as %doc
>
> multithreadedtc-javadoc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/javadoc/multithreadedtc-1.0.1/package-list
> multithreadedtc-javadoc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/javadoc/multithreadedtc-1.0.1/stylesheet.css
>
> You should fix these by doing sed -i 's/\r//' <file_to_strip>  for both of them
> in the %prep section.

Fixed all, please review again, thanks.

Spec URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc.spec
SRPM URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc-1.01...
package link : http://huwang.fedorapeople.org/packages/multithreadedtc

Here is the scratch built in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2212150

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #7 from huwang  2010-05-27 04:12:00 EDT ---
Added missing %add_to_maven_depmap.
Spec URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc.spec
SRPM URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc-1.01...

package link : http://huwang.fedorapeople.org/packages/multithreadedtc

Here is the scratch built in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2212175

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #8 from huwang  2010-05-27 05:35:30 EDT ---
Fix some issues.

Spec URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc.spec
SRPM URL:
http://huwang.fedorapeople.org/packages/multithreadedtc/multithreadedtc-1.01...

package link : http://huwang.fedorapeople.org/packages/multithreadedtc

Here is the scratch built in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2212245

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #9 from Alexander Kurtakov  2010-05-27 05:53:39 EDT ---
Review:

FIXIT: rpmlint must be run on every package. Output:
multithreadedtc.noarch: W: spelling-error Summary(en_US) concuurent ->
concurrent, concurrency, concurrence
multithreadedtc.noarch: W: non-conffile-in-etc
/etc/maven/fragments/multithreadedtc

Not a problem.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other
packages. 
OK: All filenames in rpm packages must be valid UTF-8.

This package is APPROVED.

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #10 from huwang  2010-05-27 06:01:47 EDT ---
New Package CVS Request
=======================
Package Name: multithreadedtc
Short Description: A framework for testing concurent Java application
Owners: huwang
Branches: 
InitialCC:

[Bug 596074] Review Request: multithreadedtc - A framework for testing concuurent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #11 from huwang  2010-05-27 06:09:18 EDT ---
Sorry, make a mistake in Comment 10, please ignore it.

New Package CVS Request
=======================
Package Name: multithreadedtc
Short Description: A framework for testing concurrent Java application
Owners: huwang
Branches: 
InitialCC:

[Bug 596074] Review Request: multithreadedtc - A framework for testing concurrent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |multithreadedtc - A         |multithreadedtc - A
                   |framework for testing       |framework for testing
                   |concuurent Java application |concurrent Java application

[Bug 596074] Review Request: multithreadedtc - A framework for testing concurrent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #12 from Alexander Kurtakov  2010-05-28 09:10:25 EDT ---
You have to put the fedora-cvs flag.

[Bug 596074] Review Request: multithreadedtc - A framework for testing concurrent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 596074] Review Request: multithreadedtc - A framework for testing concurrent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #13 from Kevin Fenzi  2010-05-31 15:23:47 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 596074] Review Request: multithreadedtc - A framework for testing concurrent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

--- Comment #14 from huwang  2010-05-31 22:01:09 EDT ---
Koji build;
http://koji.fedoraproject.org/koji/packageinfo?packageID=10423

[Bug 596074] Review Request: multithreadedtc - A framework for testing concurrent Java application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=596074

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE