Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: deletemail - A non-interactive tool for deleting mails
https://bugzilla.redhat.com/show_bug.cgi?id=480254
Summary: Review Request: deletemail - A non-interactive tool for deleting mails Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/deletemail.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/deletemail-0.5-1.fc9.src.rpm
Project URL: http://www.jhweiss.de/software/deletemail.html
Description: deletemail is a non-interactive tool for removing mail which is older than a configurable number of days from one or more IMAP mailboxes. By default, mail which is not marked as seen on the server will not be deleted. If, for example, fetchmail is used for receiving mail from an IMAP server, deletemail might be useful, since fetchmail deletes mail either immediately or not at all. Thus, you could use fetchmails keep option (so that fetchmail never deletes anything) and let deletemail handle the removal of mail. Currently, the IMAP4 and IMAP4rev1 protocols are supported, optionally using SSL/TLS for secure IMAP connections.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1056944
rpmlint output: [fab@laptop024 i386]$ rpmlint deletemail* 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[fab@laptop024 SRPMS]$ rpmlint deletemail-0.5-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review+
--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2009-02-06 19:11:56 EDT --- This is tiny and it might be useful, so I'll take a look.
COPYING does indeed contain an MIT license, and many of the source files do as well, but a couple (strcasestr.c, strncasecmp.c) carry the BSD license. However, it doesn't seem as though those two source files are used when building on Linux, and so the resulting package I believe still has the MIT license as you have indicated, so that's OK.
Honestly I don't see anything else to comment on.
* source files match upstream. sha256sum: 25600727a3fba9eb4e97762e0f675a2fb82e6eec454d74761525fd8c11fe8468 deletemail-0.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: deletemail = 0.5-1.fc11 deletemail(x86-64) = 0.5-1.fc11 = libcrypto.so.8()(64bit) libssl.so.8()(64bit)
* I tested the package and it seems to work as advertised. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files.
APPROVED
The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2009-02-07 16:35:27 EDT --- New Package CVS Request ======================= Package Name: deletemail Short Description: A non-interactive tool for deleting mails Owners: fab Branches: F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-02-08 17:01:18 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2009-02-20 07:01:19 EDT --- Pushed to testing
https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1549 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1578
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-03-04 11:25:23 EDT --- deletemail-0.5-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.5-1.fc9 Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-03-04 11:25:38 EDT --- deletemail-0.5-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480254
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.5-1.fc9 |0.5-1.fc10
package-review@lists.fedoraproject.org