[Bug 492130] New: Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)
Alias: mingw32-gtkmm24

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Summary: Review Request: mingw32-gtkmm24 - MinGW Windows C++
                    interface for GTK2 (a GUI library for X)
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]
        Depends on: 492125
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://sailer.fedorapeople.org/mingw32-gtkmm24.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-gtkmm24-2.15.0-1.fc11.src.rpm
Description:
MinGW Windows C++ interface for GTK2 (a GUI library for X)

Approved MinGW packaging guidelines are here:
http://fedoraproject.org/wiki/Packaging/MinGW

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |491614(mingw32-libglademm24
                   |                            |)

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Mattias Ellert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

Bug 492130 depends on bug 492125, which changed state.

Bug 492125 Summary: Review Request: mingw32-pangomm - MinGW Windows C++ interface for Pango
https://bugzilla.redhat.com/show_bug.cgi?id=492125

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

--- Comment #1 from Mattias Ellert   2009-04-18 11:28:09 EDT ---
Fedora review mingw32-gtkmm24-2.15.0-1.fc11.src.rpm 2009-04-18

* OK
! needs attention

* rpmlint output
  Only expected Errors/Warnings from a mingw package

* Package is named according to Fedora mingw packaging guidelines

* Spec file is named as the package

* Package follows the Fedora mingw packaging guidelines

* The stated license (LGPLv2+) is a Fedora approved license

* The stated license is the same as the one for the corresponding
  Fedora package

* The package contains the license file (COPYING) which is LGPL v2.1

! The package also includes another license file (COPYING.tools) from
  the source tarball which is the GPL2 license. Is any of the
  components in the package released under this license? If there are
  components in the package released under this license the License
  tag should reflect this. If there are no components in the package
  released under this license this file shouldn't be in the package.
  The corresponding native Fedora package gtkmm24 doesn't seem to
  package this file.

* The spec file is written in legible English

* Sources matches upstream
  b1b3e8efa33425bf91ba49922fab13ac  gtkmm-2.15.0.tar.bz2
  b1b3e8efa33425bf91ba49922fab13ac  SRPM/gtkmm-2.15.0.tar.bz2

! Accoding to guidelines the version should match the version of the
  corresponding Fedora package. The current version of the native
  package (in F11 and devel) is 2.16.0.

* Package builds in mock (Fedora 10).

! Since the documentation is deleted anyway after the build, wouldn't
  it make sense to pass --disable-doc to configure so that it is not
  built in the first place?

* BuildRequires look sane

* Owns the directories it creates

* No duplicate files

* %files has %defattr

* %clean clears %buildroot

* Specfile uses macros consistently

* Package does not own other's directories

* %install clears %buildroot

* Installed filenames are valid UTF8

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

--- Comment #2 from Thomas Sailer   2009-04-18 14:35:11 EDT ---
Thanks for taking the review!

In order to update mingw32-gtkmm24 to 2.16.0, mingw32-gtk2 also needs to be
updated to 2.16.0 or later, otherwise gtkmm24 won't compile.

I have applied for ACL's on mingw32-gtk2 to be able to do that, so stay
tuned...

COPYING.tools needs not be included, as the binary rpm does not distribute any
of the tools in the ./tools directory.

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Erik van Pienbroek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Erik van Pienbroek   2009-04-18 14:49:33 EDT ---
Hi,

I already have commit access to mingw32-gtk2, so I can update it to 2.16.1 if
necessary. Does an update of gtk2 suffice or does glib2 also need to be updated
to 2.20.1 ?

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

--- Comment #4 from Thomas Sailer   2009-04-18 15:03:34 EDT ---
Erik, I'd be glad if you could update mingw32-gtk2. I have already updated
mingw32-glib2 to 2.20.1.

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

--- Comment #5 from Erik van Pienbroek   2009-04-18 15:21:11 EDT ---
mingw32-gtk2 2.16.1 is now being build for Rawhide/F12:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1306975

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

--- Comment #6 from Thomas Sailer   2009-04-18 18:14:25 EDT ---
Ok, I've updated the package:

Spec URL: http://sailer.fedorapeople.org/mingw32-gtkmm24.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-gtkmm24-2.16.0-1.fc11.src.rpm

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Mattias Ellert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Mattias Ellert   2009-04-19 13:21:59 EDT ---
Package approved.

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from Thomas Sailer   2009-04-19 14:25:51 EDT ---
Thank you for the review!

New Package CVS Request
=======================
Package Name: mingw32-gtkmm24
Short Description: MinGW Windows C++ interface for GTK2 (a GUI library for X)
Owners: sailer rjones
Branches: F-10 F-11
InitialCC:

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |496718(mingw32-plotmm)

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #9 from Kevin Fenzi   2009-04-21 15:54:20 EDT ---
cvs done.

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

--- Comment #10 from Fedora Update System   2009-04-30 03:00:33 EDT ---
mingw32-gtkmm24-2.14.3-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-gtkmm24-2.14.3-1.fc10

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

--- Comment #11 from Fedora Update System   2009-05-02 12:29:43 EDT ---
mingw32-gtkmm24-2.14.3-1.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 492130] Review Request: mingw32-gtkmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=492130

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |2.14.3-1.fc10
         Resolution|                            |NEXTRELEASE