https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Bug ID: 2294337 Summary: Review Request: clean-rpm-gpg-pubkey - Remove old PGP keys from the RPM database Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mavit@mavit.org.uk QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mavit.fedorapeople.org/rpm/clean-rpm-gpg-pubkey.spec SRPM URL: https://mavit.fedorapeople.org/rpm/clean-rpm-gpg-pubkey-0-1.20210505gitebb9a... Description: Remove old PGP keys from the RPM database Fedora Account System Username: mavit
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7667922 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Petr Pisar ppisar@redhat.com --- By the way there is a similar plugin for DNF under development https://github.com/rpm-software-management/dnf-plugins-core/pull/533.
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags|requires_doc_text? |fedora-review? Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sergio@serjux.com
--- Comment #3 from Sergio Basto sergio@serjux.com --- BTW my solution was https://discussion.fedoraproject.org/t/header-v3-rsa-sha1-signature-key-id-d...
do we really need a package to run one script ? , can't the script be add to rpm package for example .
Thank you
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #4 from Petr Pisar ppisar@redhat.com --- URL and Source addresses are OK. Source archive (SHA-512 f5973480a383b23d45a469df3b438ee2d66ab27096ef2f616205502a717991adf79c278ecf38acff1036ff83b76485b66488d2284a05cc0ef9a1484984bf3d5e) is original. Ok. Summary is Ok. Description is Ok. License verified from COPYING. Ok. No XS code, noarch BuildArch is Ok.
FIX: Do not build-require 'perl'. It's not used at build-time. FIX: Package COPYING file with %license macro. That's the only file which declares the license.
$ rpmlint clean-rpm-gpg-pubkey.spec ../SRPMS/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.src.rpm ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3
clean-rpm-gpg-pubkey.noarch: W: no-manual-page-for-binary clean-rpm-gpg-pubkey clean-rpm-gpg-pubkey.spec: W: no-%build-section clean-rpm-gpg-pubkey.spec: W: no-%build-section clean-rpm-gpg-pubkey.spec:10: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 10) clean-rpm-gpg-pubkey.spec:10: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 10) === 2 packages and 1 specfiles checked; 0 errors, 5 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
FIX: Normalize white spaces in the spec file.
$ rpm -q -lv -p ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm -rwxr-xr-x 1 root root 2952 Jun 26 02:00 /usr/bin/clean-rpm-gpg-pubkey drwxr-xr-x 2 root root 0 Jun 26 02:00 /usr/share/doc/clean-rpm-gpg-pubkey -rw-r--r-- 1 root root 812 May 5 2021 /usr/share/doc/clean-rpm-gpg-pubkey/README.md drwxr-xr-x 2 root root 0 Jun 26 02:00 /usr/share/licenses/clean-rpm-gpg-pubkey -rw-r--r-- 1 root root 35147 May 5 2021 /usr/share/licenses/clean-rpm-gpg-pubkey/COPYING.GPL File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm | sort -f | uniq -c 1 /usr/bin/curl 1 /usr/bin/gpg2 1 /usr/bin/perl 1 /usr/bin/rpm 1 fedora-repos 1 perl(File::Temp) 1 perl(Getopt::Long) 1 perl(IO::File) 1 perl(POSIX) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Run-require "fedora-release-common" (clean-rpm-gpg-pubkey:33).
$ rpm -q --provides -p ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm | sort -f | uniq -c 1 clean-rpm-gpg-pubkey = 0-1.20210505gitebb9ab1.fc41 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm Binary dependencies are resolvable. Ok.
The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=119629819). Ok.
Otherwise, the package is in-line with Fedora and Perl packaging guidelines.
Please correct the FIX items and provide an updated spec file.
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #5 from Peter Oliver mavit@mavit.org.uk --- (In reply to Petr Pisar from comment #4)
Please correct the FIX items and provide an updated spec file.
Done. Updated spec and SRPM at the same URL. Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #6 from Peter Oliver mavit@mavit.org.uk --- (In reply to Sergio Basto from comment #3)
do we really need a package to run one script ? , can't the script be add to rpm package for example .
It's Fedora-specific, so it'd belong somewhere like Miroslav Suchý's remove-retired-packages, perhaps. However, https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Petr Pisar ppisar@redhat.com --- Spec file changes:
$ diff -u clean-rpm-gpg-pubkey.spec{.old,} --- clean-rpm-gpg-pubkey.spec.old 2024-06-25 23:19:48.000000000 +0200 +++ clean-rpm-gpg-pubkey.spec 2024-06-26 18:05:46.000000000 +0200 @@ -7,16 +7,16 @@ Version: 0 Release: %{autorelease} Summary: Remove old PGP keys from the RPM database -License: GPL-3.0-only +License: GPL-3.0-only URL: %{forgeurl} Source: %{forgesource}
BuildArch: noarch -BuildRequires: perl BuildRequires: perl-generators Requires: /usr/bin/curl Requires: /usr/bin/gpg2 Requires: /usr/bin/rpm +Requires: fedora-release-common Requires: fedora-repos
%{?perl_default_filter} @@ -39,6 +39,7 @@
%files %doc README.md +%license COPYING %license COPYING.GPL %{_bindir}/%{name}
$ rpmlint clean-rpm-gpg-pubkey.spec ../SRPMS/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.src.rpm ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3
clean-rpm-gpg-pubkey.noarch: W: no-manual-page-for-binary clean-rpm-gpg-pubkey clean-rpm-gpg-pubkey.spec: W: no-%build-section clean-rpm-gpg-pubkey.spec: W: no-%build-section === 2 packages and 1 specfiles checked; 0 errors, 3 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm -rwxr-xr-x 1 root root 2952 Jun 27 02:00 /usr/bin/clean-rpm-gpg-pubkey drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/doc/clean-rpm-gpg-pubkey -rw-r--r-- 1 root root 812 May 5 2021 /usr/share/doc/clean-rpm-gpg-pubkey/README.md drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/licenses/clean-rpm-gpg-pubkey -rw-r--r-- 1 root root 70 May 5 2021 /usr/share/licenses/clean-rpm-gpg-pubkey/COPYING -rw-r--r-- 1 root root 35147 May 5 2021 /usr/share/licenses/clean-rpm-gpg-pubkey/COPYING.GPL File layout and permissions is Ok.
$ rpm -q --requires -p ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm | sort -f | uniq -c 1 /usr/bin/curl 1 /usr/bin/gpg2 1 /usr/bin/perl 1 /usr/bin/rpm 1 fedora-release-common 1 fedora-repos 1 perl(File::Temp) 1 perl(Getopt::Long) 1 perl(IO::File) 1 perl(POSIX) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok.
$ resolvedeps rawhide ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm Binary dependencies are resolvable. Ok.
The package build in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=119683282).
The package is in-line with Fedora packaging guidelines. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/clean-rpm-gpg-pubkey
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-8f1ff5de6d (clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8f1ff5de6d
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-06-27 14:41:26
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-8f1ff5de6d (clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-d74995274a (clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d74995274a
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-e2d6620120 (clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e2d6620120
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-e2d6620120 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e2d6620120 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e2d6620120
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2294337
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-d74995274a has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d74995274a *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d74995274a
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
package-review@lists.fedoraproject.org