[Bug 433045] New: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=433045

Summary: Review Request: php-pear-propel_generator - An Object
                    Relational Mapping (ORM) framework for PHP5
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://akahl.fedorapeople.org/php-pear-propel/php-pear-propel_generator.spec
SRPM URL: http://akahl.fedorapeople.org/php-pear-propel/php-pear-propel_generator-1.2....
Description: 
Propel is an Object Relational Mapping (ORM) framework for PHP5.
It allows you to access your database using a set of objects,
providing a simple API for storing and retrieving data.

Propel allows you, the web application developer, to work with
databases in the same way you work with other classes and objects
in PHP.

This package contains the generator component of Propel.

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |351441
              nThis|                            |

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

------- Additional Comments From [e-mail]  2008-06-01 09:33 EST -------
Updated Spec URL:
http://akahl.fedorapeople.org/php-pear-propel/php-pear-propel_generator.spec
Updated SRPM URL:
http://akahl.fedorapeople.org/php-pear-propel/php-pear-propel_generator-1.3....

Changes:
- update to 1.3.0-rc1
- ownership of %%{pear_phpdir}/propel now claimed by both -runtime and
  -generator packages
- dependencies update

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

------- Additional Comments From [e-mail]  2008-07-03 04:18 EST -------
Updated Spec URL:
http://akahl.fedorapeople.org/php-pear-propel/php-pear-propel_generator.spec
Updated SRPM URL:
http://akahl.fedorapeople.org/php-pear-propel/php-pear-propel_generator-1.3....

Changes:
- dropped Obsoletes

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-07-03 23:38 EST -------
Since you fixed this package up with the changes from the propel_runtime review,
I might as well take care of it as well.

All rpmlint has to complain about is the lack of documentation, which is fine.

* source files match upstream:
   f8f5d1743defa37c08b6c28122a02c03a082ed25edc6e14c15026cd8fac68fa6  
   propel_generator-1.3.0RC1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   php-pear(pear.phpdb.org/propel_generator) = 1.3.0
   php-pear-propel_generator = 1.3.0-0.2.rc1.fc10
  =
   /bin/sh
   /usr/bin/pear
   php-channel(pear.phpdb.org)
   php-cli >= 5.2.0
   php-dom
   php-pdo
   php-pear
   php-pear-phing >= 2.3.0
   php-xml
   php-xsl

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.

APPROVED

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-07-06 08:02 EST -------
New Package CVS Request
=======================
Package Name:      php-pear-propel_generator
Short Description: An Object Relational Mapping (ORM) framework for PHP5
Owners:            akahl
Branches:          F-8 F-9
InitialCC: 
Cvsextras Commits: yes

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-07-06 22:10 EST -------
Does this package and the php-pear-propel_runtime really have the exact same
Short Description? That seems odd.

cvs done. Feel free to reset the fedora-cvs flag if the Short Description needs
to be updated here.

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

------- Additional Comments From [e-mail]  2008-07-08 17:03 EST -------
Well, in fact they are distributed as one php package but two pear packages or
components able to run completely autonomously with no interdependencies. Since
there is a limit of 50 characters for the short description, we could rename
both of them like:
"An ORM framework for PHP5 - runtime component"
"An ORM framework for PHP5 - generator component"
losing some verbosity on the packages' purposes but it's an acceptable drawback
I guess. Is it feasible to change the short descriptions after the source import
at all..?

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-07-09 12:51 EST -------
Yes, the short description is just used in pkgdb, otherwise you can change the
Summary in the spec file as you like.

There is not a pkgdb interface for users to change the Short Description
currently, so you need a cvsadmin to do so.

Would you like me to change them as above? Or just leave them for now?

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

------- Additional Comments From [e-mail]  2008-07-10 04:07 EST -------
Please change them as above - the long description reveals the meaning of "ORM"
and it's surely better to have distinct short descriptions. I'll adapt them in
the spec files.
Thank you!

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-07-10 19:07 EST -------
cvs done.

[Bug 433045] Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5

https://bugzilla.redhat.com/show_bug.cgi?id=433045

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-07-11 04:43 EST -------
All packages rebuilt with updated summary. Thanks again Kevin!