8:12 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Bug ID: 2071646
Summary: Review Request: stdman - C++ standard library man
pages
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mohd.akram(a)outlook.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedo...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedo...
Description: C++ standard library man pages generated from cppreference.com
HTML files
Fedora Account System Username: mohd-akram
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
5:35 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
CC| |zbyszek(a)in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Hmm, how is the License tag derived?
The content is from cppreference.com, but I couldn't find a license
specification anywhere.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
7:06 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #2 from Mohamed Akram <mohd.akram(a)outlook.com> ---
MIT license is for stdman itself, the other two are for cppreference (see
https://en.cppreference.com/w/Cppreference:FAQ).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
2:58 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Ah, the link is
https://en.cppreference.com/w/Cppreference:FAQ#What_can_I_do_with_the_mat...
Please add that in a comment in the spec file.
So this looks all good, but the license should *not* include MIT
[https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...]:
The License: field refers to the licenses of the contents of the
binary rpm.
I'd suggest %autorelease+%autochangelog to reduce the maintenance burden:
https://docs.pagure.org/fedora-infra.rpmautospec/opting-in.html
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
6:23 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #4 from Mohamed Akram <mohd.akram(a)outlook.com> ---
Ah, I was wondering about that. Should I also remove the %license from the
files?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
7:49 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Yes.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
9:48 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Mohamed Akram <mohd.akram(a)outlook.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedo...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedo...
Description: C++ standard library man pages generated from cppreference.com
HTML files
Fedora Account System Username: mohd-akram
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
9:49 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #6 from Mohamed Akram <mohd.akram(a)outlook.com> ---
Cool, I updated the files with the changes.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
12:50 p.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
Flags| |fedora-review+
--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
+ package name is OK
+ license is acceptable (GFDL and CC-BY-SA)
+ license is specified correctly
+ builds and installs OK
+ latest version
+ R/P/BR look OK
rpmlint complains that there's a number of identical files. Certain files are
copied even 5 times.
It's not a big deal: the whole package is 4 MB. If you wanted to fix this, it'd
be possible to either
use symlinks, or to replace the content in duplicate files with '.so
<name-of-the-real-file>'.
But it's probably not worth the trouble.
Package is APPROVED.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
1:52 p.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #8 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Maybe the following:
BuildRequires: jdupes
%prep:
...
sed -i /gzip/d do_install
%install:
...
jdupes -r -l %{buildroot}%{_mandir}
This has also the advantage that the distro compression settings are used.
gzip is now used by default, but I think we'll be switching to zstd at some
point.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
8:07 a.m.
New subject: [Bug 2071646] Review Request: stdman - C++ standard library man
pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(zbyszek(a)in.waw.pl |
|) |
--- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
I can re-review if an update is submitted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
8:07 a.m.
New subject: needinfo canceled: [Bug 2071646] Review Request: stdman - C++
standard library man pages
Product: Fedora
Version: rawhide
Component: Package Review
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> has canceled Package Review
<package-review(a)lists.fedoraproject.org>'s request for Zbigniew
Jędrzejewski-Szmek <zbyszek(a)in.waw.pl>'s needinfo:
Bug 2071646: Review Request: stdman - C++ standard library man pages
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
I can re-review if an update is submitted.
99
days inactive
813
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
bugzilla＠redhat.com